tobias/waybar
1
0
Fork 0
mirror of https://github.com/rad4day/Waybar.git synced 2023-12-21 10:22:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(sway): ipc client crash when compiled with -D_GLIBCXX_ASSERTIONS

Browse Source 
reserve() does not change string size and any access beyond data() + size() is UB
This commit is contained in:
Aleksei Bavshin 2019-03-14 17:53:45 -07:00
parent 6d2dcd8ac7
commit 00176c9514
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/modules/sway/ipc/client.cpp
View File

@ -64,7 +64,7 @@ struct waybar::modules::sway::Ipc::ipc_response
waybar::modules::sway::Ipc::recv(int fd) const
{
std::string header;
header.reserve(ipc_header_size_);
header.resize(ipc_header_size_);
auto data32 = reinterpret_cast<uint32_t *>(header.data() + ipc_magic_.size());
size_t total = 0;
@ -83,7 +83,7 @@ struct waybar::modules::sway::Ipc::ipc_response
total = 0;
std::string payload;
payload.reserve(data32[0] + 1);
payload.resize(data32[0]);
while (total < data32[0]) {
auto res = ::recv(fd, payload.data() + total, data32[0] - total, 0);
if (res < 0) {
@ -91,7 +91,6 @@ struct waybar::modules::sway::Ipc::ipc_response
}
total += res;
}
payload[data32[0]] = 0;
return { data32[0], data32[1], &payload.front() };
}
@ -100,7 +99,7 @@ struct waybar::modules::sway::Ipc::ipc_response
const std::string& payload) const
{
std::string header;
header.reserve(ipc_header_size_);
header.resize(ipc_header_size_);
auto data32 = reinterpret_cast<uint32_t *>(header.data() + ipc_magic_.size());
memcpy(header.data(), ipc_magic_.c_str(), ipc_magic_.size());
data32[0] = payload.size();