tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

folder/IMAP: cleanup getmessage()

Browse Source 
Add some comments how the data structures actually look like.
Describe the function properly, and make sure we only hold on to the
data connection as quickly as possible.

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
This commit is contained in:
Sebastian Spaeth 2011-04-26 15:18:54 +02:00 committed by Nicolas Sebrecht
parent 3b09695236
commit 1ff628bd5c
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
offlineimap/folder/IMAP.py
View File

@ -209,16 +209,25 @@ class IMAPFolder(BaseFolder):
return self.messagelist
def getmessage(self, uid):
"""Retrieve message with UID from the IMAP server (incl body)
:returns: the message body
"""
imapobj = self.imapserver.acquireconnection()
try:
imapobj.select(self.getfullname(), readonly = 1)
initialresult = imapobj.uid('fetch', '%d' % uid, '(BODY.PEEK[])')
self.ui.debug('imap', 'Returned object from fetching %d: %s' % \
(uid, str(initialresult)))
return initialresult[1][0][1].replace("\r\n", "\n")
res_type, data = imapobj.uid('fetch', '%d' % uid, '(BODY.PEEK[])')
finally:
self.imapserver.releaseconnection(imapobj)
assert res_type == 'OK', "Fetching message with UID '%d' failed" % uid
# data looks now e.g. [('320 (UID 17061 BODY[]
# {2565}','msgbody....')] we only asked for one message,
# and that msg is in data[0]. msbody is in [0][1]
data = data[0][1]
self.ui.debug('imap', '%s bytes returned from fetching %d: %s...%s' % \
(len(data), uid, data[0:100], data[-100:]))
return data.replace("\r\n", "\n")
def getmessagetime(self, uid):
return self.messagelist[uid]['time']