chore: v0.4.0

Disable backlight module if no backlights found

.gitignore

@@ -5,7 +5,7 @@ vgcore.*
 *.swp
 packagecache
 /subprojects/**/
-/build
+/build*
 /dist
 /meson.egg-info
 

.travis.yml

@@ -6,7 +6,7 @@ services:
 env:
     - distro: debian
     - distro: archlinux
-    - distro: opensuse
+    # - distro: opensuse
 
 before_install:
     - docker pull alexays/waybar:${distro}

Dockerfiles/opensuse

@@ -2,4 +2,4 @@ FROM opensuse/tumbleweed:latest
 
 RUN zypper -n up && \
     zypper -n install -t pattern devel_C_C++ && \
-    zypper -n install git meson clang libinput-devel libwayland-client0 libwayland-cursor0 wayland-protocols-devel wayland-devel Mesa-libEGL-devel Mesa-libGLESv2-devel libgbm-devel libxkbcommon-devel libudev-devel libpixman-1-0-devel gtkmm3-devel jsoncpp-devel
+    zypper -n install git meson clang libinput10 libinput-devel libwayland-client0 libwayland-cursor0 wayland-protocols-devel wayland-devel Mesa-libEGL-devel Mesa-libGLESv2-devel libgbm-devel libxkbcommon-devel libudev-devel libpixman-1-0-devel gtkmm3-devel jsoncpp-devel

README.md

@@ -1,4 +1,4 @@
-# Waybar [![Travis](https://travis-ci.org/Alexays/Waybar.svg?branch=master)](https://travis-ci.org/Alexays/Waybar) [![Licence](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE)<br>![Waybar](https://raw.githubusercontent.com/alexays/waybar/master/preview-2.png)
+# Waybar [![Travis](https://travis-ci.org/Alexays/Waybar.svg?branch=master)](https://travis-ci.org/Alexays/Waybar) [![Licence](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE) [![Paypal Donate](https://img.shields.io/badge/Donate-Paypal-2244dd.svg)](https://paypal.me/ARouillard)<br>![Waybar](https://raw.githubusercontent.com/alexays/waybar/master/preview-2.png)
 **Proof of concept**
 
 > Highly customizable Wayland bar for Sway and Wlroots based compositors.<br>
@@ -14,6 +14,7 @@
 - Memory
 - Cpu load average
 - Custom scripts
+- Multiple output configuration
 - And much more customizations
 
 **Configuration and Styling**

include/ALabel.hpp

@@ -17,6 +17,8 @@ public:
   virtual operator Gtk::Widget &();
 
 protected:
+  bool tooltipEnabled();
+
   Gtk::EventBox event_box_;
   Gtk::Label label_;
   const Json::Value &config_;

include/bar.hpp

@@ -7,6 +7,7 @@
 #include <gtkmm/window.h>
 #include "wlr-layer-shell-unstable-v1-client-protocol.h"
 #include "xdg-output-unstable-v1-client-protocol.h"
+#include "idle-inhibit-unstable-v1-client-protocol.h"
 #include "IModule.hpp"
 
 namespace waybar {
@@ -44,6 +45,9 @@ class Bar {
     static void layerSurfaceHandleClosed(void *,
       struct zwlr_layer_surface_v1 *);
 
+    void initBar();
+    bool isValidOutput(const Json::Value &config);
+    void destroyOutput();
     auto setupConfig() -> void;
     auto setupWidgets() -> void;
     auto setupCss() -> void;

include/client.hpp

@@ -24,6 +24,7 @@ class Client {
     struct zwlr_layer_shell_v1 *layer_shell = nullptr;
     struct zxdg_output_manager_v1 *xdg_output_manager = nullptr;
     struct wl_seat *seat = nullptr;
+    struct zwp_idle_inhibit_manager_v1 *idle_inhibit_manager = nullptr;
     std::vector<std::unique_ptr<Bar>> bars;
 
   private:

include/factory.hpp

@@ -7,6 +7,7 @@
 #include "modules/sway/workspaces.hpp"
 #include "modules/sway/window.hpp"
 #endif
+#include "modules/idle_inhibitor.hpp"
 #include "modules/battery.hpp"
 #include "modules/memory.hpp"
 #include "modules/cpu.hpp"
@@ -16,6 +17,9 @@
 #ifdef HAVE_LIBNL
 #include "modules/network.hpp"
 #endif
+#ifdef HAVE_LIBUDEV
+#include "modules/backlight.hpp"
+#endif
 #ifdef HAVE_LIBPULSE
 #include "modules/pulseaudio.hpp"
 #endif

include/modules/backlight.hpp

@@ -0,0 +1,67 @@
+#pragma once
+
+#include <optional>
+#include <string>
+#include <string_view>
+#include <vector>
+
+#include "ALabel.hpp"
+#include "util/json.hpp"
+#include "util/sleeper_thread.hpp"
+
+struct udev;
+struct udev_device;
+
+namespace waybar::modules {
+
+class Backlight : public ALabel {
+  class BacklightDev {
+  public:
+    BacklightDev() = default;
+    BacklightDev(std::string name, int actual, int max);
+    std::string_view name() const;
+    int get_actual() const;
+    void set_actual(int actual);
+    int get_max() const;
+    void set_max(int max);
+    friend inline bool operator==(const BacklightDev &lhs,
+                                  const BacklightDev &rhs) {
+      return lhs.name_ == rhs.name_ && lhs.actual_ == rhs.actual_ &&
+             lhs.max_ == rhs.max_;
+    }
+
+  private:
+    std::string name_;
+    int actual_ = 1;
+    int max_ = 1;
+  };
+
+public:
+  Backlight(const std::string &, const Json::Value &);
+  ~Backlight();
+  auto update() -> void;
+
+private:
+  template <class ForwardIt>
+  static const BacklightDev *best_device(ForwardIt first, ForwardIt last,
+                                         std::string_view);
+  template <class ForwardIt, class Inserter>
+  static void upsert_device(ForwardIt first, ForwardIt last, Inserter inserter,
+                            udev_device *dev);
+  template <class ForwardIt, class Inserter>
+  static void enumerate_devices(ForwardIt first, ForwardIt last,
+                                Inserter inserter, udev *udev);
+
+  const std::string name_;
+  const std::string preferred_device_;
+  static constexpr int EPOLL_MAX_EVENTS = 16;
+
+  std::optional<BacklightDev> previous_best_;
+  std::string previous_format_;
+
+  std::mutex udev_thread_mutex_;
+  std::vector<BacklightDev> devices_;
+  // thread must destruct before shared data
+  waybar::util::SleeperThread udev_thread_;
+};
+} // namespace waybar::modules

include/modules/custom.hpp

@@ -22,6 +22,7 @@ class Custom : public ALabel {
 
     const std::string name_;
     std::string text_;
+    std::string alt_;
     std::string tooltip_;
     std::string class_;
     std::string prevclass_;

include/modules/idle_inhibitor.hpp

@@ -0,0 +1,23 @@
+#pragma once
+
+#include <fmt/format.h>
+#include "bar.hpp"
+#include "client.hpp"
+#include "ALabel.hpp"
+
+namespace waybar::modules {
+
+class IdleInhibitor: public ALabel {
+  public:
+    IdleInhibitor(const std::string&, const waybar::Bar&, const Json::Value&);
+    ~IdleInhibitor();
+    auto update() -> void;
+  private:
+    bool onClick(GdkEventButton* const& ev);
+
+    const Bar& bar_;
+    std::string status_;
+    struct zwp_idle_inhibitor_v1 *idle_inhibitor_;
+};
+
+}

include/modules/network.hpp

@@ -20,6 +20,8 @@ class Network : public ALabel {
     ~Network();
     auto update() -> void;
   private:
+    static const uint8_t MAX_RETRY = 5;
+
     static int handleEvents(struct nl_msg*, void*);
     static int handleScan(struct nl_msg*, void*);
 

include/modules/sway/workspaces.hpp

@@ -19,11 +19,12 @@ class Workspaces : public IModule {
     operator Gtk::Widget &();
   private:
     void worker();
-    void addWorkspace(Json::Value);
+    void addWorkspace(const Json::Value&);
-    std::string getIcon(std::string, Json::Value);
+    std::string getIcon(const std::string&, const Json::Value&);
     bool handleScroll(GdkEventScroll*);
     std::string getPrevWorkspace();
     std::string getNextWorkspace();
+    uint16_t getWorkspaceIndex(const std::string &name);
     std::string trimWorkspaceName(std::string);
 
     const Bar& bar_;

meson.build

@@ -1,6 +1,6 @@
 project(
     'waybar', 'cpp', 'c',
-    version: '0.3.0',
+    version: '0.4.0',
     license: 'MIT',
     default_options : [
         'cpp_std=c++17',
@@ -55,6 +55,7 @@ sigcpp = dependency('sigc++-2.0')
 libnl = dependency('libnl-3.0', required: get_option('libnl'))
 libnlgen = dependency('libnl-genl-3.0', required: get_option('libnl'))
 libpulse = dependency('libpulse', required: get_option('pulseaudio'))
+libudev = dependency('libudev', required: get_option('libudev'))
 
 src_files = files(
     'src/factory.cpp',
@@ -64,6 +65,7 @@ src_files = files(
     'src/modules/clock.cpp',
     'src/modules/custom.cpp',
     'src/modules/cpu.cpp',
+	'src/modules/idle_inhibitor.cpp',
     'src/main.cpp',
     'src/bar.cpp',
     'src/client.cpp'
@@ -99,6 +101,11 @@ if dbusmenu_gtk.found()
     )
 endif
 
+if libudev.found()
+    add_project_arguments('-DHAVE_LIBUDEV', language: 'cpp')
+    src_files += 'src/modules/backlight.cpp'
+endif
+
 subdir('protocol')
 
 executable(
@@ -119,7 +126,8 @@ executable(
         giounix,
         libnl,
         libnlgen,
-        libpulse
+        libpulse,
+        libudev
     ],
     include_directories: [include_directories('include')],
     install: true,

meson_options.txt

@@ -1,4 +1,5 @@
 option('libnl', type: 'feature', value: 'auto', description: 'Enable libnl support for network related features')
+option('libudev', type: 'feature', value: 'auto', description: 'Enable libudev support for udev related features')
 option('pulseaudio', type: 'feature', value: 'auto', description: 'Enable support for pulseaudio')
 option('dbusmenu-gtk', type: 'feature', value: 'auto', description: 'Enable support for tray')
 option('out', type: 'string', value : '/', description: 'output prefix directory')

protocol/meson.build

@@ -24,6 +24,7 @@ wayland_scanner_client = generator(
 client_protocols = [
 	[wl_protocol_dir, 'stable/xdg-shell/xdg-shell.xml'],
 	[wl_protocol_dir, 'unstable/xdg-output/xdg-output-unstable-v1.xml'],
+	[wl_protocol_dir, 'unstable/idle-inhibit/idle-inhibit-unstable-v1.xml'],
 	['wlr-layer-shell-unstable-v1.xml'],
 ]
 

resources/config

@@ -6,7 +6,7 @@
     // Choose the order of the modules
     "modules-left": ["sway/workspaces", "sway/mode", "custom/spotify"],
     "modules-center": ["sway/window"],
-    "modules-right": ["pulseaudio", "network", "cpu", "memory", "battery", "battery#bat2", "clock", "tray"],
+    "modules-right": ["idle_inhibitor", "pulseaudio", "network", "cpu", "memory", "backlight", "battery", "battery#bat2", "clock", "tray"],
     // Modules configuration
     // "sway/workspaces": {
     //     "disable-scroll": true,
@@ -26,11 +26,19 @@
     "sway/mode": {
         "format": "<span style=\"italic\">{}</span>"
     },
+    "idle_inhibitor": {
+        "format": "{icon}",
+        "format-icons": {
+            "activated": "",
+            "deactivated": ""
+        }
+    },
     "tray": {
         // "icon-size": 21,
         "spacing": 10
     },
     "clock": {
+        "tooltip-format": "{:%Y-%m-%d | %H:%M}",
         "format-alt": "{:%Y-%m-%d}"
     },
     "cpu": {
@@ -39,6 +47,11 @@
     "memory": {
         "format": "{}% "
     },
+    "backlight": {
+        // "device": "acpi_video1",
+        "format": "{percent}% {icon}",
+        "format-icons": ["", ""]
+    },
     "battery": {
         "states": {
             // "good": 95,

resources/style.css

@@ -12,6 +12,7 @@ window#waybar {
     color: white;
 }
 
+/* https://github.com/Alexays/Waybar/wiki/FAQ#the-workspace-buttons-have-a-strange-hover-effect */
 #workspaces button {
     padding: 0 5px;
     background: transparent;
@@ -29,7 +30,7 @@ window#waybar {
     border-bottom: 3px solid white;
 }
 
-#clock, #battery, #cpu, #memory, #network, #pulseaudio, #custom-spotify, #tray, #mode {
+#clock, #battery, #cpu, #memory, #backlight, #network, #pulseaudio, #custom-spotify, #tray, #mode, #idle_inhibitor {
     padding: 0 10px;
     margin: 0 5px;
 }
@@ -55,7 +56,7 @@ window#waybar {
     }
 }
 
-#battery.warning:not(.charging) {
+#battery.critical:not(.charging) {
     background: #f53c3c;
     color: white;
     animation-name: blink;
@@ -74,6 +75,10 @@ window#waybar {
     background: #9b59b6;
 }
 
+#backlight {
+    background: #90b1b1;
+}
+
 #network {
     background: #2980b9;
 }
@@ -100,3 +105,7 @@ window#waybar {
 #tray {
     background-color: #2980b9;
 }
+
+#idle_inhibitor {
+    background-color: #2d3436;
+}

src/ALabel.cpp

@@ -27,7 +27,7 @@ waybar::ALabel::ALabel(const Json::Value& config, const std::string format, uint
       sigc::mem_fun(*this, &ALabel::handleToggle));
   }
   if (config_["on-scroll-up"].isString() || config_["on-scroll-down"].isString()) {
-    event_box_.add_events(Gdk::SCROLL_MASK);
+    event_box_.add_events(Gdk::SCROLL_MASK | Gdk::SMOOTH_SCROLL_MASK);
     event_box_.signal_scroll_event().connect(
       sigc::mem_fun(*this, &ALabel::handleScroll));
   }
@@ -86,8 +86,8 @@ bool waybar::ALabel::handleScroll(GdkEventScroll* e) {
   return true;
 }
 
-std::string waybar::ALabel::getIcon(uint16_t percentage,
+std::string waybar::ALabel::getIcon(uint16_t percentage, const std::string& alt)
-                                    const std::string& alt) {
+{
   auto format_icons = config_["format-icons"];
   if (format_icons.isObject()) {
     if (!alt.empty() && (format_icons[alt].isString() || format_icons[alt].isArray())) {
@@ -107,4 +107,9 @@ std::string waybar::ALabel::getIcon(uint16_t percentage,
   return "";
 }
 
+bool waybar::ALabel::tooltipEnabled()
+{
+  return config_["tooltip"].isBool() ? config_["tooltip"].asBool() : true;
+}
+
 waybar::ALabel::operator Gtk::Widget&() { return event_box_; }

src/bar.cpp

@@ -33,8 +33,11 @@ waybar::Bar::Bar(const Client& client,
   GdkWindow *gdk_window = gtk_widget_get_window(wrap);
   gdk_wayland_window_set_use_custom_surface(gdk_window);
   surface = gdk_wayland_window_get_wl_surface(gdk_window);
+}
 
-  std::size_t layer_top = config_["layer"] == "top"
+void waybar::Bar::initBar()
+{
+    std::size_t layer_top = config_["layer"] == "top"
     ? ZWLR_LAYER_SHELL_V1_LAYER_TOP : ZWLR_LAYER_SHELL_V1_LAYER_BOTTOM;
   layer_surface = zwlr_layer_shell_v1_get_layer_surface(
     client.layer_shell, surface, *output, layer_top, "waybar");
@@ -43,8 +46,7 @@ waybar::Bar::Bar(const Client& client,
     .configure = layerSurfaceHandleConfigure,
     .closed = layerSurfaceHandleClosed,
   };
-  zwlr_layer_surface_v1_add_listener(layer_surface,
+  zwlr_layer_surface_v1_add_listener(layer_surface, &layer_surface_listener, this);
-    &layer_surface_listener, this);
 
   std::size_t anchor = ZWLR_LAYER_SURFACE_V1_ANCHOR_LEFT
     | ZWLR_LAYER_SURFACE_V1_ANCHOR_RIGHT;
@@ -84,11 +86,50 @@ void waybar::Bar::handleDone(void* /*data*/,
   // Nothing here
 }
 
+bool waybar::Bar::isValidOutput(const Json::Value &config)
+{
+  bool found = true;
+  if (config["output"].isArray()) {
+    bool in_array = false;
+    for (auto const &output : config["output"]) {
+      if (output.isString() && output.asString() == output_name) {
+        in_array = true;
+        break;
+      }
+    }
+    found = in_array;
+  }
+  if (config["output"].isString() && config["output"].asString() != output_name) {
+    found = false;
+  }
+  return found;
+}
+
 void waybar::Bar::handleName(void* data, struct zxdg_output_v1* /*xdg_output*/,
   const char* name)
 {
 	auto o = static_cast<waybar::Bar *>(data);
   o->output_name = name;
+  bool found = true;
+  if (o->config_.isArray()) {
+    bool in_array = false;
+    for (auto const &config : o->config_) {
+      if (config.isObject() && o->isValidOutput(config)) {
+        in_array = true;
+        o->config_ = config;
+        break;
+      }
+    }
+    found = in_array;
+  } else {
+    found = o->isValidOutput(o->config_);
+  }
+  if (!found) {
+    wl_output_destroy(*o->output);
+    zxdg_output_v1_destroy(o->xdg_output_);
+  } else {
+    o->initBar();
+  }
 }
 
 void waybar::Bar::handleDescription(void* /*data*/,
@@ -102,7 +143,6 @@ void waybar::Bar::layerSurfaceHandleConfigure(void* data,
   uint32_t height)
 {
   auto o = static_cast<waybar::Bar *>(data);
-  o->window.show_all();
   zwlr_layer_surface_v1_ack_configure(surface, serial);
   if (width != o->width_ || height != o->height_) {
     o->width_ = width;
@@ -221,4 +261,5 @@ auto waybar::Bar::setupWidgets() -> void
   for (auto const& module : modules_right_) {
     right_.pack_end(*module, false, false, 0);
   }
+  window.show_all();
 }

src/client.cpp

@@ -55,6 +55,10 @@ void waybar::Client::handleGlobal(void *data, struct wl_registry *registry,
       o->xdg_output_manager = static_cast<struct zxdg_output_manager_v1 *>(
         wl_registry_bind(registry, name,
         &zxdg_output_manager_v1_interface, ZXDG_OUTPUT_V1_NAME_SINCE_VERSION));
+  } else if (strcmp(interface, zwp_idle_inhibit_manager_v1_interface.name) == 0) {
+    o->idle_inhibit_manager = static_cast<struct zwp_idle_inhibit_manager_v1 *>(
+        wl_registry_bind(registry, name,
+        &zwp_idle_inhibit_manager_v1_interface, 1));
   }
 }
 
@@ -138,6 +142,7 @@ int waybar::Client::main(int argc, char* argv[])
   bars.clear();
   zxdg_output_manager_v1_destroy(xdg_output_manager);
   zwlr_layer_shell_v1_destroy(layer_shell);
+  zwp_idle_inhibit_manager_v1_destroy(idle_inhibit_manager);
   wl_registry_destroy(registry);
   wl_seat_destroy(seat);
   wl_display_disconnect(wl_display);

src/factory.cpp

@@ -24,6 +24,9 @@ waybar::IModule* waybar::Factory::makeModule(const std::string &name) const
       return new waybar::modules::sway::Window(id, bar_, config_[name]);
     }
     #endif
+    if (ref == "idle_inhibitor") {
+      return new waybar::modules::IdleInhibitor(id, bar_, config_[name]);
+    }
     if (ref == "memory") {
       return new waybar::modules::Memory(id, config_[name]);
     }
@@ -43,6 +46,11 @@ waybar::IModule* waybar::Factory::makeModule(const std::string &name) const
       return new waybar::modules::Network(id, config_[name]);
     }
     #endif
+    #ifdef HAVE_LIBUDEV
+    if (ref == "backlight") {
+      return new waybar::modules::Backlight(id, config_[name]);
+    }
+    #endif
     #ifdef HAVE_LIBPULSE
     if (ref == "pulseaudio") {
       return new waybar::modules::Pulseaudio(id, config_[name]);

src/modules/backlight.cpp

@@ -0,0 +1,278 @@
+#include "modules/backlight.hpp"
+
+#include <algorithm>
+#include <chrono>
+#include <memory>
+
+#include <libudev.h>
+
+#include <sys/epoll.h>
+#include <unistd.h>
+
+#include <fmt/format.h>
+
+namespace {
+class FileDescriptor {
+public:
+  explicit FileDescriptor(int fd) : fd_(fd) {}
+  FileDescriptor(const FileDescriptor &other) = delete;
+  FileDescriptor(FileDescriptor &&other) noexcept = delete;
+  FileDescriptor &operator=(const FileDescriptor &other) = delete;
+  FileDescriptor &operator=(FileDescriptor &&other) noexcept = delete;
+  ~FileDescriptor() {
+    if (fd_ != -1) {
+      if (close(fd_) != 0) {
+        fmt::print(stderr, "Failed to close fd: {}\n", errno);
+      }
+    }
+  }
+  int get() const { return fd_; }
+
+private:
+  int fd_;
+};
+
+struct UdevDeleter {
+  void operator()(udev *ptr) { udev_unref(ptr); }
+};
+
+struct UdevDeviceDeleter {
+  void operator()(udev_device *ptr) { udev_device_unref(ptr); }
+};
+
+struct UdevEnumerateDeleter {
+  void operator()(udev_enumerate *ptr) { udev_enumerate_unref(ptr); }
+};
+
+struct UdevMonitorDeleter {
+  void operator()(udev_monitor *ptr) { udev_monitor_unref(ptr); }
+};
+
+void check_eq(int rc, int expected, const char *message = "eq, rc was: ") {
+  if (rc != expected) {
+    throw std::runtime_error(fmt::format(message, rc));
+  }
+}
+
+void check_neq(int rc, int bad_rc, const char *message = "neq, rc was: ") {
+  if (rc == bad_rc) {
+    throw std::runtime_error(fmt::format(message, rc));
+  }
+}
+
+void check0(int rc, const char *message = "rc wasn't 0") {
+  check_eq(rc, 0, message);
+}
+
+void check_gte(int rc, int gte, const char *message = "rc was: ") {
+  if (rc < gte) {
+    throw std::runtime_error(fmt::format(message, rc));
+  }
+}
+
+void check_nn(const void *ptr, const char *message = "ptr was null") {
+  if (ptr == nullptr) {
+    throw std::runtime_error(message);
+  }
+}
+} // namespace
+
+waybar::modules::Backlight::BacklightDev::BacklightDev(std::string name,
+                                                       int actual, int max)
+    : name_(std::move(name)), actual_(actual), max_(max) {}
+
+std::string_view waybar::modules::Backlight::BacklightDev::name() const {
+  return name_;
+}
+
+int waybar::modules::Backlight::BacklightDev::get_actual() const {
+  return actual_;
+}
+
+void waybar::modules::Backlight::BacklightDev::set_actual(int actual) {
+  actual_ = actual;
+}
+
+int waybar::modules::Backlight::BacklightDev::get_max() const { return max_; }
+
+void waybar::modules::Backlight::BacklightDev::set_max(int max) { max_ = max; }
+
+waybar::modules::Backlight::Backlight(const std::string &name,
+                                      const Json::Value &config)
+    : ALabel(config, "{percent}%", 2), name_(name),
+      preferred_device_(
+          config["device"].isString() ? config["device"].asString() : "") {
+  label_.set_name("backlight");
+
+  // Get initial state
+  {
+    std::unique_ptr<udev, UdevDeleter> udev_check{udev_new()};
+    check_nn(udev_check.get(), "Udev check new failed");
+    enumerate_devices(devices_.begin(), devices_.end(),
+                      std::back_inserter(devices_), udev_check.get());
+    if (devices_.empty()) {
+      throw std::runtime_error("No backlight found");
+    }
+    dp.emit();
+  }
+
+  udev_thread_ = [this] {
+    std::unique_ptr<udev, UdevDeleter> udev{udev_new()};
+    check_nn(udev.get(), "Udev new failed");
+
+    std::unique_ptr<udev_monitor, UdevMonitorDeleter> mon{
+        udev_monitor_new_from_netlink(udev.get(), "udev")};
+    check_nn(mon.get(), "udev monitor new failed");
+    check_gte(udev_monitor_filter_add_match_subsystem_devtype(
+                  mon.get(), "backlight", nullptr),
+              0, "udev failed to add monitor filter: ");
+    udev_monitor_enable_receiving(mon.get());
+
+    auto udev_fd = udev_monitor_get_fd(mon.get());
+
+    auto epoll_fd = FileDescriptor{epoll_create1(0)};
+    check_neq(epoll_fd.get(), -1, "epoll init failed: ");
+    epoll_event ctl_event;
+    ctl_event.events = EPOLLIN;
+    ctl_event.data.fd = udev_fd;
+
+    check0(
+        epoll_ctl(epoll_fd.get(), EPOLL_CTL_ADD, ctl_event.data.fd, &ctl_event),
+        "epoll_ctl failed: {}");
+    epoll_event events[EPOLL_MAX_EVENTS];
+
+    while (udev_thread_.isRunning()) {
+      const int event_count =
+          epoll_wait(epoll_fd.get(), events, EPOLL_MAX_EVENTS,
+                     std::chrono::milliseconds{interval_}.count());
+      if (!udev_thread_.isRunning()) {
+        break;
+      }
+      decltype(devices_) devices;
+      {
+        std::scoped_lock<std::mutex> lock(udev_thread_mutex_);
+        devices = devices_;
+      }
+      for (int i = 0; i < event_count; ++i) {
+        const auto &event = events[i];
+        check_eq(event.data.fd, udev_fd, "unexpected udev fd");
+        std::unique_ptr<udev_device, UdevDeviceDeleter> dev{
+            udev_monitor_receive_device(mon.get())};
+        check_nn(dev.get(), "epoll dev was null");
+        upsert_device(devices.begin(), devices.end(),
+                      std::back_inserter(devices), dev.get());
+      }
+
+      // Refresh state if timed out
+      if (event_count == 0) {
+        enumerate_devices(devices.begin(), devices.end(),
+                          std::back_inserter(devices), udev.get());
+      }
+      {
+        std::scoped_lock<std::mutex> lock(udev_thread_mutex_);
+        devices_ = devices;
+      }
+      dp.emit();
+    }
+  };
+}
+
+waybar::modules::Backlight::~Backlight() = default;
+
+auto waybar::modules::Backlight::update() -> void {
+  decltype(devices_) devices;
+  {
+    std::scoped_lock<std::mutex> lock(udev_thread_mutex_);
+    devices = devices_;
+  }
+
+  const auto best =
+      best_device(devices.cbegin(), devices.cend(), preferred_device_);
+  if (best != nullptr) {
+    if (previous_best_.has_value() && previous_best_.value() == *best &&
+        !previous_format_.empty() && previous_format_ == format_) {
+      return;
+    }
+
+    const auto percent =
+        best->get_max() == 0 ? 100 : best->get_actual() * 100 / best->get_max();
+    label_.set_markup(fmt::format(format_,
+                                  fmt::arg("percent", std::to_string(percent)),
+                                  fmt::arg("icon", getIcon(percent))));
+  } else {
+    if (!previous_best_.has_value()) {
+      return;
+    }
+    label_.set_markup("");
+  }
+  previous_best_ = best == nullptr ? std::nullopt : std::optional{*best};
+  previous_format_ = format_;
+}
+
+template <class ForwardIt>
+const waybar::modules::Backlight::BacklightDev *
+waybar::modules::Backlight::best_device(ForwardIt first, ForwardIt last,
+                                        std::string_view preferred_device) {
+  const auto found =
+      std::find_if(first, last, [preferred_device](const auto &dev) {
+        return dev.name() == preferred_device;
+      });
+  if (found != last) {
+    return &(*found);
+  }
+
+  const auto max =
+      std::max_element(first, last, [](const auto &l, const auto &r) {
+        return l.get_max() < r.get_max();
+      });
+
+  return max == last ? nullptr : &(*max);
+}
+
+template <class ForwardIt, class Inserter>
+void waybar::modules::Backlight::upsert_device(ForwardIt first, ForwardIt last,
+                                               Inserter inserter,
+                                               udev_device *dev) {
+  const char *name = udev_device_get_sysname(dev);
+  check_nn(name);
+
+  const char *actual = udev_device_get_sysattr_value(dev, "actual_brightness");
+  check_nn(actual);
+  const int actual_int = std::stoi(actual);
+
+  const char *max = udev_device_get_sysattr_value(dev, "max_brightness");
+  check_nn(max);
+  const int max_int = std::stoi(max);
+
+  auto found = std::find_if(first, last, [name](const auto &device) {
+    return device.name() == name;
+  });
+  if (found != last) {
+    found->set_actual(actual_int);
+    found->set_max(max_int);
+  } else {
+    *inserter = BacklightDev{name, actual_int, max_int};
+    ++inserter;
+  }
+}
+
+template <class ForwardIt, class Inserter>
+void waybar::modules::Backlight::enumerate_devices(ForwardIt first,
+                                                   ForwardIt last,
+                                                   Inserter inserter,
+                                                   udev *udev) {
+  std::unique_ptr<udev_enumerate, UdevEnumerateDeleter> enumerate{
+      udev_enumerate_new(udev)};
+  udev_enumerate_add_match_subsystem(enumerate.get(), "backlight");
+  udev_enumerate_scan_devices(enumerate.get());
+  udev_list_entry *enum_devices =
+      udev_enumerate_get_list_entry(enumerate.get());
+  udev_list_entry *dev_list_entry;
+  udev_list_entry_foreach(dev_list_entry, enum_devices) {
+    const char *path = udev_list_entry_get_name(dev_list_entry);
+    std::unique_ptr<udev_device, UdevDeviceDeleter> dev{
+        udev_device_new_from_syspath(udev, path)};
+    check_nn(dev.get(), "dev new failed");
+    upsert_device(first, last, inserter, dev.get());
+  }
+}

src/modules/battery.cpp

@@ -148,7 +148,9 @@ auto waybar::modules::Battery::update() -> void
   if (status == "Unknown") {
     status = getAdapterStatus(capacity);
   }
-  label_.set_tooltip_text(status);
+  if (tooltipEnabled()) {
+    label_.set_tooltip_text(status);
+  }
   std::transform(status.begin(), status.end(), status.begin(), ::tolower);
   auto format = format_;
   auto state = getState(capacity);

src/modules/clock.cpp

@@ -21,5 +21,16 @@ waybar::modules::Clock::Clock(const std::string& id, const Json::Value& config)
 auto waybar::modules::Clock::update() -> void
 {
   auto localtime = fmt::localtime(std::time(nullptr));
-  label_.set_markup(fmt::format(format_, localtime));
+  auto text = fmt::format(format_, localtime);
+  label_.set_markup(text);
+  
+  if (tooltipEnabled()) {
+    if (config_["tooltip-format"].isString()) {
+      auto tooltip_format = config_["tooltip-format"].asString();
+      auto tooltip_text = fmt::format(tooltip_format, localtime);
+      label_.set_tooltip_text(tooltip_text);
+    } else {
+      label_.set_tooltip_text(text);
+    }
+  }
 }

src/modules/cpu.cpp

@@ -18,7 +18,9 @@ auto waybar::modules::Cpu::update() -> void
   // TODO: as creating dynamic fmt::arg arrays is buggy we have to calc both
   auto cpu_load = getCpuLoad();
   auto [cpu_usage, tooltip] = getCpuUsage();
-  label_.set_tooltip_text(tooltip);
+  if (tooltipEnabled()) {
+    label_.set_tooltip_text(tooltip);
+  }
   label_.set_markup(fmt::format(format_,
     fmt::arg("load", cpu_load), fmt::arg("usage", cpu_usage)));
 }

src/modules/custom.cpp

@@ -53,14 +53,17 @@ void waybar::modules::Custom::continuousWorker()
     char* buff = nullptr;
     size_t len = 0;
     if (getline(&buff, &len, fp_) == -1) {
+      int exit_code = 1;
       if (fp_) {
-        pclose(fp_);
+        exit_code = WEXITSTATUS(pclose(fp_));
         fp_ = nullptr;
       }
       thread_.stop();
-      output_ = { 1, "" };
+      if (exit_code != 0) {
-      std::cerr << name_ + " just stopped, is it endless?" << std::endl;
+        output_ = { exit_code, "" };
-      dp.emit();
+        dp.emit();
+        std::cerr << name_ + " just stopped unexpectedly, is it endless?" << std::endl;
+      }
       return;
     }
 
@@ -88,13 +91,16 @@ auto waybar::modules::Custom::update() -> void
     }
 
     auto str = fmt::format(format_, text_,
+      fmt::arg("alt", alt_),
       fmt::arg("icon", getIcon(percentage_)),
       fmt::arg("percentage", percentage_));
     label_.set_markup(str);
-    if (text_ == tooltip_) {
+    if (tooltipEnabled()) {
-      label_.set_tooltip_text(str);
+      if (text_ == tooltip_) {
-    } else {
+        label_.set_tooltip_text(str);
-      label_.set_tooltip_text(tooltip_);
+      } else {
+        label_.set_tooltip_text(tooltip_);
+      }
     }
     if (class_ != "") {
       if (prevclass_ != "") {
@@ -118,7 +124,11 @@ void waybar::modules::Custom::parseOutputRaw()
   int i = 0;
   while (getline(output, line)) {
     if (i == 0) {
-      text_ = line;
+      if (config_["escape"].isBool() && config_["escape"].asBool()) {
+        text_ = Glib::Markup::escape_text(line);
+      } else {
+        text_ = line;
+      }
       tooltip_ = line;
       class_ = "";
     } else if (i == 1) {
@@ -138,7 +148,16 @@ void waybar::modules::Custom::parseOutputJson()
   std::string line;
   while (getline(output, line)) {
     auto parsed = parser_.parse(line);
-    text_ = parsed["text"].asString();
+    if (config_["escape"].isBool() && config_["escape"].asBool()) {
+      text_ = Glib::Markup::escape_text(parsed["text"].asString());
+    } else {
+      text_ = parsed["text"].asString();
+    }
+    if (config_["escape"].isBool() && config_["escape"].asBool()) {
+      alt_ = Glib::Markup::escape_text(parsed["alt"].asString());
+    } else {
+      alt_ = parsed["alt"].asString();
+    }
     tooltip_ = parsed["tooltip"].asString();
     class_ = parsed["class"].asString();
     if (!parsed["percentage"].asString().empty() && parsed["percentage"].isUInt()) {

src/modules/idle_inhibitor.cpp

@@ -0,0 +1,50 @@
+#include "modules/idle_inhibitor.hpp"
+
+
+waybar::modules::IdleInhibitor::IdleInhibitor(const std::string& id, const Bar& bar, const Json::Value& config)
+  : ALabel(config, "{status}"), bar_(bar), status_("deactivated"), idle_inhibitor_(nullptr)
+{
+  label_.set_name("idle_inhibitor");
+  if (!id.empty()) {
+    label_.get_style_context()->add_class(id);
+  }
+  event_box_.add_events(Gdk::BUTTON_PRESS_MASK);
+  event_box_.signal_button_press_event().connect(
+      sigc::mem_fun(*this, &IdleInhibitor::onClick));
+  dp.emit();
+}
+
+waybar::modules::IdleInhibitor::~IdleInhibitor()
+{
+  if(idle_inhibitor_) {
+    zwp_idle_inhibitor_v1_destroy(idle_inhibitor_);
+    idle_inhibitor_ = nullptr;
+  }
+}
+
+auto waybar::modules::IdleInhibitor::update() -> void
+{
+  label_.set_markup(
+      fmt::format(format_, fmt::arg("status", status_),
+                  fmt::arg("icon", getIcon(0, status_))));
+  if(tooltipEnabled()) {
+    label_.set_tooltip_text(status_);
+  }
+}
+
+bool waybar::modules::IdleInhibitor::onClick(GdkEventButton* const& e)
+{
+  if(e->button == 1) {
+    if (idle_inhibitor_) {
+      zwp_idle_inhibitor_v1_destroy(idle_inhibitor_);
+      idle_inhibitor_ = nullptr;
+      status_ = "deactivated";
+    } else {
+      idle_inhibitor_ = zwp_idle_inhibit_manager_v1_create_inhibitor(
+          bar_.client.idle_inhibit_manager, bar_.surface);
+      status_ = "activated";
+    }
+  }
+  dp.emit();
+  return true;
+}

src/modules/memory.cpp

@@ -20,7 +20,9 @@ auto waybar::modules::Memory::update() -> void
     int used_ram_percentage = 100 * (memtotal_ - memfree_) / memtotal_;
     label_.set_markup(fmt::format(format_, used_ram_percentage));
     auto used_ram_gigabytes = (memtotal_ - memfree_) / std::pow(1024, 2);
-    label_.set_tooltip_text(fmt::format("{:.{}f}Gb used", used_ram_gigabytes, 1));
+    if (tooltipEnabled()) {
+      label_.set_tooltip_text(fmt::format("{:.{}f}Gb used", used_ram_gigabytes, 1));
+    }
     event_box_.show();
   } else {
     event_box_.hide();

src/modules/network.cpp

@@ -65,7 +65,7 @@ void waybar::modules::Network::createInfoSocket()
   }
   nl_socket_disable_seq_check(info_sock_);
   nl_socket_set_nonblocking(info_sock_);
-  nl_socket_modify_cb(info_sock_, NL_CB_MSG_IN, NL_CB_CUSTOM, handleEvents, this);
+  nl_socket_modify_cb(info_sock_, NL_CB_VALID, NL_CB_CUSTOM, handleEvents, this);
   efd_ = epoll_create1(0);
   if (efd_ < 0) {
     throw std::runtime_error("Can't create epoll");
@@ -82,7 +82,7 @@ void waybar::modules::Network::createInfoSocket()
   {
     auto fd = nl_socket_get_fd(info_sock_);
     struct epoll_event event;
-    event.events = EPOLLIN;
+    event.events = EPOLLIN | EPOLLET | EPOLLRDHUP;
     event.data.fd = fd;
     if (epoll_ctl(efd_, EPOLL_CTL_ADD, fd, &event) == -1) {
       throw std::runtime_error("Can't add epoll event");
@@ -119,8 +119,7 @@ void waybar::modules::Network::worker()
     int ec = epoll_wait(efd_, events, 16, -1);
     if (ec > 0) {
       for (auto i = 0; i < ec; i++) {
-        if (events[i].events & EPOLLIN
+        if (events[i].data.fd == nl_socket_get_fd(info_sock_)) {
-          && events[i].data.fd == nl_socket_get_fd(info_sock_)) {
           nl_recvmsgs_default(info_sock_);
         } else {
           thread_.stop();
@@ -313,6 +312,9 @@ out:
 void waybar::modules::Network::getInterfaceAddress() {
   unsigned int cidrRaw;
   struct ifaddrs *ifaddr, *ifa;
+  ipaddr_.clear();
+  netmask_.clear();
+  cidr_ = 0;
   int success = getifaddrs(&ifaddr);
   if (success == 0) {
     ifa = ifaddr;
@@ -333,10 +335,6 @@ void waybar::modules::Network::getInterfaceAddress() {
       ifa = ifa->ifa_next;
     }
     freeifaddrs(ifaddr);
-  } else {
-    ipaddr_.clear();
-    netmask_.clear();
-    cidr_ = 0;
   }
 }
 
@@ -379,13 +377,19 @@ int waybar::modules::Network::handleEvents(struct nl_msg *msg, void *data) {
       need_update = true;
       if (!(rtif->ifi_flags & IFF_RUNNING)) {
         net->disconnected();
+        net->dp.emit();
       }
     }
   }
   if (net->ifid_ <= 0 && !net->config_["interface"].isString()) {
-    // Need to wait before get external interface
+    for (uint8_t i = 0; i < MAX_RETRY; i += 1) {
-    net->thread_.sleep_for(std::chrono::seconds(1));
+      net->ifid_ = net->getExternalInterface();
-    net->ifid_ = net->getExternalInterface();
+      if (net->ifid_ > 0) {
+        break;
+      }
+      // Need to wait before get external interface
+      net->thread_.sleep_for(std::chrono::seconds(1));
+    }
     if (net->ifid_ > 0) {
       char ifname[IF_NAMESIZE];
       if_indextoname(net->ifid_, ifname);

src/modules/pulseaudio.cpp

@@ -39,7 +39,7 @@ waybar::modules::Pulseaudio::Pulseaudio(const std::string& id, const Json::Value
   // events are configured
   if (!config["on-scroll-up"].isString() &&
       !config["on-scroll-down"].isString()) {
-    event_box_.add_events(Gdk::SCROLL_MASK);
+    event_box_.add_events(Gdk::SCROLL_MASK | Gdk::SMOOTH_SCROLL_MASK);
     event_box_.signal_scroll_event().connect(
         sigc::mem_fun(*this, &Pulseaudio::handleScroll));
   }
@@ -202,18 +202,22 @@ auto waybar::modules::Pulseaudio::update() -> void
     format =
       config_["format-muted"].isString() ? config_["format-muted"].asString() : format;
     label_.get_style_context()->add_class("muted");
-  } else if (port_name_.find("a2dp_sink") != std::string::npos) {
-    format = config_["format-bluetooth"].isString()
-      ? config_["format-bluetooth"].asString() : format;
-    label_.get_style_context()->add_class("bluetooth");
   } else {
     label_.get_style_context()->remove_class("muted");
-    label_.get_style_context()->add_class("bluetooth");
+    if (port_name_.find("a2dp_sink") != std::string::npos) {
+      format = config_["format-bluetooth"].isString()
+        ? config_["format-bluetooth"].asString() : format;
+      label_.get_style_context()->add_class("bluetooth");
+    } else {
+      label_.get_style_context()->remove_class("bluetooth");
+    }
   }
   label_.set_markup(
       fmt::format(format, fmt::arg("volume", volume_),
                   fmt::arg("icon", getIcon(volume_, getPortIcon()))));
-  label_.set_tooltip_text(desc_);
+  if (tooltipEnabled()) {
+    label_.set_tooltip_text(desc_);
+  }
   if (scrolling_) {
     scrolling_ = false;
   }

src/modules/sni/item.cpp

@@ -209,7 +209,7 @@ waybar::modules::SNI::Item::getIconByName(std::string name, int request_size) {
     if (size == request_size || size == -1) {
       tmp_size = request_size;
       break;
-    } else if (size < request_size || size > tmp_size) {
+    } else if (size < request_size || (size > tmp_size && tmp_size > 0)) {
       tmp_size = size;
     }
   }

src/modules/sway/mode.cpp

@@ -37,7 +37,9 @@ auto waybar::modules::sway::Mode::update() -> void
     event_box_.hide();
   } else {
     label_.set_markup(fmt::format(format_, mode_));
-    label_.set_tooltip_text(mode_);
+    if (tooltipEnabled()) {
+      label_.set_tooltip_text(mode_);
+    }
     event_box_.show();
   }
 }

src/modules/sway/window.cpp

@@ -48,7 +48,9 @@ void waybar::modules::sway::Window::worker()
 auto waybar::modules::sway::Window::update() -> void
 {
   label_.set_markup(fmt::format(format_, window_));
-  label_.set_tooltip_text(window_);
+  if (tooltipEnabled()) {
+    label_.set_tooltip_text(window_);
+  }
 }
 
 std::tuple<int, std::string> waybar::modules::sway::Window::getFocusedNode(

src/modules/sway/workspaces.cpp

@@ -17,12 +17,7 @@ void waybar::modules::sway::Workspaces::worker()
 {
   thread_ = [this] {
     try {
-      // Wait for the name of the output
+      if (!workspaces_.empty()) {
-      if (!config_["all-outputs"].asBool() && bar_.output_name.empty()) {
-        while (bar_.output_name.empty()) {
-          thread_.sleep_for(std::chrono::milliseconds(150));
-        }
-      } else if (!workspaces_.empty()) {
         ipc_.handleEvent();
       }
       {
@@ -47,8 +42,7 @@ auto waybar::modules::sway::Workspaces::update() -> void
     auto ws = std::find_if(workspaces_.begin(), workspaces_.end(),
       [it](auto node) -> bool { return node["name"].asString() == it->first; });
     if (ws == workspaces_.end() ||
-            (!config_["all-outputs"].asBool() &&
+            (!config_["all-outputs"].asBool() && (*ws)["output"].asString() != bar_.output_name)) {
-             (*ws)["output"].asString() != bar_.output_name)) {
       it = buttons_.erase(it);
       needReorder = true;
     } else {
@@ -82,7 +76,7 @@ auto waybar::modules::sway::Workspaces::update() -> void
         button.get_style_context()->remove_class("urgent");
       }
       if (needReorder) {
-        box_.reorder_child(button, node["num"].asInt());
+        box_.reorder_child(button, getWorkspaceIndex(node["name"].asString()));
       }
       auto icon = getIcon(node["name"].asString(), node);
       if (config_["format"].isString()) {
@@ -101,7 +95,7 @@ auto waybar::modules::sway::Workspaces::update() -> void
   }
 }
 
-void waybar::modules::sway::Workspaces::addWorkspace(Json::Value node)
+void waybar::modules::sway::Workspaces::addWorkspace(const Json::Value &node)
 {
   auto icon = getIcon(node["name"].asString(), node);
   auto format = config_["format"].isString()
@@ -127,7 +121,7 @@ void waybar::modules::sway::Workspaces::addWorkspace(Json::Value node)
     button.signal_scroll_event()
       .connect(sigc::mem_fun(*this, &Workspaces::handleScroll));
   }
-  box_.reorder_child(button, node["num"].asInt());
+  box_.reorder_child(button, getWorkspaceIndex(node["name"].asString()));
   if (node["focused"].asBool()) {
     button.get_style_context()->add_class("focused");
   }
@@ -140,11 +134,10 @@ void waybar::modules::sway::Workspaces::addWorkspace(Json::Value node)
   button.show();
 }
 
-std::string waybar::modules::sway::Workspaces::getIcon(std::string name,
+std::string waybar::modules::sway::Workspaces::getIcon(const std::string &name,
-  Json::Value node)
+  const Json::Value &node)
 {
-  std::vector<std::string> keys = {
+  std::vector<std::string> keys = { name, "urgent", "focused", "visible", "default" };
-    name, "urgent", "focused", "visible", "default"};
   for (auto const& key : keys) {
     if (key == "focused" || key == "visible" || key == "urgent") {
       if (config_["format-icons"][key].isString() && node[key].asBool()) {
@@ -209,7 +202,7 @@ bool waybar::modules::sway::Workspaces::handleScroll(GdkEventScroll *e)
 
 std::string waybar::modules::sway::Workspaces::getPrevWorkspace()
 {
-  for (uint16_t i = 0; i != workspaces_.size(); i += 1) {
+  for (uint16_t i = 0; i < workspaces_.size(); i += 1) {
     if (workspaces_[i]["focused"].asBool()) {
       if (i > 0) {
         return workspaces_[i - 1]["name"].asString();
@@ -222,7 +215,7 @@ std::string waybar::modules::sway::Workspaces::getPrevWorkspace()
 
 std::string waybar::modules::sway::Workspaces::getNextWorkspace()
 {
-  for (uint16_t i = 0; i != workspaces_.size(); i += 1) {
+  for (uint16_t i = 0; i < workspaces_.size(); i += 1) {
     if (workspaces_[i]["focused"].asBool()) {
       if (i + 1U < workspaces_.size()) {
         return workspaces_[i + 1]["name"].asString();
@@ -233,8 +226,20 @@ std::string waybar::modules::sway::Workspaces::getNextWorkspace()
   return "";
 }
 
-waybar::modules::sway::Workspaces::operator Gtk::Widget &() {
+uint16_t waybar::modules::sway::Workspaces::getWorkspaceIndex(const std::string &name)
-  return box_;
+{
+  uint16_t idx = 0;
+  for (const auto &workspace : workspaces_) {
+    if (workspace["name"].asString() == name) {
+      return idx;
+    }
+    if (!config_["all-outputs"].asBool() && workspace["output"].asString() != bar_.output_name) {
+      // Nothing here
+    } else {
+      idx += 1;
+    }
+  }
+  return workspaces_.size();
 }
 
 std::string waybar::modules::sway::Workspaces::trimWorkspaceName(std::string name)
@@ -245,3 +250,7 @@ std::string waybar::modules::sway::Workspaces::trimWorkspaceName(std::string nam
   }
   return name;
 }
+
+waybar::modules::sway::Workspaces::operator Gtk::Widget &() {
+  return box_;
+}