fix: ifdef

Tray beta

include/ALabel.hpp

@@ -10,7 +10,7 @@ class ALabel : public IModule {
     ALabel(const Json::Value&, const std::string format);
     virtual ~ALabel() = default;
     virtual auto update() -> void;
-    virtual std::string getIcon(uint16_t percentage);
+    virtual std::string getIcon(uint16_t, const std::string& alt = "");
     virtual operator Gtk::Widget &();
   protected:
     Gtk::EventBox event_box_;

include/client.hpp

@@ -2,14 +2,10 @@
 
 #include <unistd.h>
 #include <wordexp.h>
-
 #include <fmt/format.h>
-
 #include <gdk/gdk.h>
 #include <wayland-client.h>
-
 #include <gdk/gdkwayland.h>
-
 #include "bar.hpp"
 
 namespace waybar {
@@ -30,14 +26,14 @@ class Client {
     struct wl_seat *seat = nullptr;
     std::vector<std::unique_ptr<Bar>> bars;
 
-private:
+  private:
-  void bindInterfaces();
+    void bindInterfaces();
-  auto setupCss();
+    auto setupCss();
 
-  static void handleGlobal(void *data, struct wl_registry *registry,
+    static void handleGlobal(void *data, struct wl_registry *registry,
-    uint32_t name, const char *interface, uint32_t version);
+      uint32_t name, const char *interface, uint32_t version);
-  static void handleGlobalRemove(void *data,
+    static void handleGlobalRemove(void *data,
-    struct wl_registry *registry, uint32_t name);
+      struct wl_registry *registry, uint32_t name);
 };
 
 }

include/factory.hpp

@@ -9,6 +9,7 @@
 #include "modules/battery.hpp"
 #include "modules/memory.hpp"
 #include "modules/cpu.hpp"
+#include "modules/sni/tray.hpp"
 #ifdef HAVE_LIBNL
 #include "modules/network.hpp"
 #endif
@@ -19,6 +20,8 @@
 
 namespace waybar {
 
+class Bar;
+
 class Factory {
   public:
     Factory(Bar& bar, const Json::Value& config);

include/modules/custom.hpp

@@ -13,10 +13,12 @@ class Custom : public ALabel {
     Custom(const std::string, const Json::Value&);
     auto update() -> void;
   private:
-    void worker();
+    void delayWorker();
+    void continuousWorker();
 
     const std::string name_;
     waybar::util::SleeperThread thread_;
+    waybar::util::command::res output_;
 };
 
 }

include/modules/network.hpp

@@ -17,8 +17,8 @@ class Network : public ALabel {
     ~Network();
     auto update() -> void;
   private:
-    static uint64_t netlinkRequest(int, void*, uint32_t, uint32_t groups = 0);
+    static int netlinkRequest(int, void*, uint32_t, uint32_t groups = 0);
-    static uint64_t netlinkResponse(int, void*, uint32_t, uint32_t groups = 0);
+    static int netlinkResponse(int, void*, uint32_t, uint32_t groups = 0);
     static int scanCb(struct nl_msg*, void*);
 
     void disconnected();
@@ -33,7 +33,7 @@ class Network : public ALabel {
     int ifid_;
     sa_family_t family_;
     int sock_fd_;
-    struct sockaddr_nl nladdr_ = {0};
+    struct sockaddr_nl nladdr_ = {};
     struct nl_sock* sk_ = nullptr;
     int nl80211_id_;
 

include/modules/pulseaudio.hpp

@@ -19,12 +19,15 @@ class Pulseaudio : public ALabel {
     static void sinkInfoCb(pa_context*, const pa_sink_info*, int, void*);
     static void serverInfoCb(pa_context*, const pa_server_info*, void*);
 
+    const std::string getPortIcon() const;
+
     pa_threaded_mainloop* mainloop_;
     pa_mainloop_api* mainloop_api_;
     pa_context* context_;
     uint32_t sink_idx_{0};
     uint16_t volume_;
     bool muted_;
+    std::string port_name_;
     std::string desc_;
 };
 

include/modules/sni/snh.hpp

@@ -0,0 +1,39 @@
+#pragma once
+
+#include <gtkmm.h>
+
+#include <tuple>
+#include <dbus-status-notifier-watcher.h>
+#include "modules/sni/sni.hpp"
+
+namespace waybar::modules::SNI {
+
+class Host {
+  public:
+    Host(Glib::Dispatcher*);
+    std::vector<Item> items;
+  private:
+    static void busAcquired(GDBusConnection*, const gchar*, gpointer);
+    static void nameAppeared(GDBusConnection*, const gchar*, const gchar*,
+      gpointer);
+    static void nameVanished(GDBusConnection*, const gchar*, gpointer);
+    static void proxyReady(GObject*, GAsyncResult*, gpointer);
+    static void registerHost(GObject*, GAsyncResult*, gpointer);
+    static void itemRegistered(SnOrgKdeStatusNotifierWatcher*, const gchar*,
+      gpointer);
+    static void itemUnregistered(SnOrgKdeStatusNotifierWatcher*, const gchar*,
+      gpointer);
+
+    std::tuple<std::string, std::string> getBusNameAndObjectPath(const gchar*);
+    void addRegisteredItem(const gchar* service);
+
+    uint32_t bus_name_id_;
+    uint32_t watcher_id_;
+    std::string bus_name_;
+    std::string object_path_;
+    Glib::Dispatcher* dp_;
+    GCancellable* cancellable_ = nullptr;
+    SnOrgKdeStatusNotifierWatcher* watcher_ = nullptr;
+};
+
+}

include/modules/sni/sni.hpp

@@ -0,0 +1,51 @@
+#pragma once
+
+#include <dbus-status-notifier-item.h>
+#include <gtkmm.h>
+
+namespace waybar::modules::SNI {
+
+class Item {
+public:
+  Item(std::string, std::string, Glib::Dispatcher *);
+
+  std::string bus_name;
+  std::string object_path;
+  Gtk::EventBox event_box;
+
+  int icon_size;
+  int effective_icon_size;
+  Gtk::Image *image;
+  Gtk::Menu *gtk_menu = nullptr;
+  std::string category;
+  std::string id;
+  std::string status;
+
+  std::string title;
+  int32_t window_id;
+  std::string icon_name;
+  Glib::RefPtr<Gdk::Pixbuf> icon_pixmap;
+  std::string overlay_icon_name;
+  std::string attention_icon_name;
+  std::string attention_movie_name;
+  std::string icon_theme_path;
+  std::string menu;
+  bool item_is_menu;
+
+private:
+  static void proxyReady(GObject *obj, GAsyncResult *res, gpointer data);
+  static void getAll(GObject *obj, GAsyncResult *res, gpointer data);
+  static void handleActivate(GObject *, GAsyncResult *, gpointer);
+  static void handleSecondaryActivate(GObject *, GAsyncResult *, gpointer);
+
+  void updateImage();
+  Glib::RefPtr<Gdk::Pixbuf> extractPixBuf(GVariant *variant);
+  Glib::RefPtr<Gdk::Pixbuf> getIconByName(std::string name, int size);
+  bool handleClick(GdkEventButton *const & /*ev*/);
+
+  Glib::Dispatcher *dp_;
+  GCancellable *cancellable_ = nullptr;
+  SnOrgKdeStatusNotifierItem *proxy_ = nullptr;
+};
+
+} // namespace waybar::modules::SNI

include/modules/sni/snw.hpp

@@ -0,0 +1,47 @@
+#pragma once
+
+#include <gtkmm.h>
+#include <dbus-status-notifier-watcher.h>
+
+namespace waybar::modules::SNI {
+
+class Watcher {
+public:
+  Watcher();
+  ~Watcher();
+
+private:
+  typedef enum { GF_WATCH_TYPE_HOST, GF_WATCH_TYPE_ITEM } GfWatchType;
+
+  typedef struct {
+    GfWatchType type;
+    Watcher *watcher;
+    gchar *service;
+    gchar *bus_name;
+    gchar *object_path;
+    guint watch_id;
+  } GfWatch;
+
+  static void busAcquired(GDBusConnection *, const gchar *, gpointer);
+  static gboolean handleRegisterHost(Watcher *, GDBusMethodInvocation *,
+                                     const gchar *);
+  static gboolean handleRegisterItem(Watcher *, GDBusMethodInvocation *,
+                                     const gchar *);
+  static GfWatch *gfWatchFind(GSList *list, const gchar *bus_name,
+                              const gchar *object_path);
+  static GfWatch *gfWatchNew(GfWatchType, const gchar *, const gchar *,
+                             const gchar *, Watcher *);
+  static void nameVanished(GDBusConnection *connection, const char *name,
+                           gpointer data);
+
+  void updateRegisteredItems(SnOrgKdeStatusNotifierWatcher *obj);
+
+  uint32_t bus_name_id_;
+  uint32_t watcher_id_;
+  GSList *hosts_ = nullptr;
+  GSList *items_ = nullptr;
+  SnOrgKdeStatusNotifierWatcher *watcher_ = nullptr;
+};
+
+} // namespace waybar::modules::SNI
+

include/modules/sni/tray.hpp

@@ -0,0 +1,25 @@
+#pragma once
+
+#include <fmt/format.h>
+#include <thread>
+#include "util/json.hpp"
+#include "IModule.hpp"
+#include "modules/sni/snw.hpp"
+#include "modules/sni/snh.hpp"
+
+namespace waybar::modules::SNI {
+
+class Tray : public IModule {
+  public:
+    Tray(const Json::Value&);
+    auto update() -> void;
+    operator Gtk::Widget &();
+  private:
+    std::thread thread_;
+    const Json::Value& config_;
+    Gtk::Box box_;
+    SNI::Watcher watcher_ ;
+    SNI::Host host_;
+};
+
+}

include/modules/sway/window.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <fmt/format.h>
+#include <tuple>
 #include "bar.hpp"
 #include "client.hpp"
 #include "util/chrono.hpp"
@@ -16,7 +17,7 @@ class Window : public ALabel {
     auto update() -> void;
   private:
     void worker();
-    std::string getFocusedNode(Json::Value nodes);
+    std::tuple<int, std::string> getFocusedNode(Json::Value nodes);
     void getFocusedWindow();
 
     Bar& bar_;
@@ -24,6 +25,7 @@ class Window : public ALabel {
     util::JsonParser parser_;
     Ipc ipc_;
     std::string window_;
+    int windowId_;
 };
 
 }

include/modules/sway/workspaces.hpp

@@ -18,7 +18,7 @@ class Workspaces : public IModule {
   private:
     void worker();
     void addWorkspace(Json::Value);
-    std::string getIcon(std::string);
+    std::string getIcon(std::string, Json::Value);
     bool handleScroll(GdkEventScroll*);
     int getPrevWorkspace();
     int getNextWorkspace();

include/util/chrono.hpp

@@ -70,11 +70,18 @@ struct SleeperThread {
     condvar_.notify_all();
   }
 
-  ~SleeperThread()
+  auto stop()
   {
     do_run_ = false;
     condvar_.notify_all();
-    thread_.detach();
+    if (thread_.joinable()) {
+      thread_.detach();
+    }
+  }
+
+  ~SleeperThread()
+  {
+    stop();
   }
 
 private:

include/util/command.hpp

@@ -4,12 +4,12 @@
 
 namespace waybar::util::command {
 
-struct cmd_res {
+struct res {
   int exit_code;
   std::string out;
 };
 
-inline struct cmd_res exec(const std::string cmd)
+inline struct res exec(const std::string cmd)
 {
   FILE* fp(popen(cmd.c_str(), "r"));
   if (!fp) {

meson.build

@@ -1,8 +1,11 @@
 project(
     'waybar', 'cpp', 'c',
-    version: '0.0.5',
+    version: '0.1.0',
     license: 'MIT',
-    default_options : ['cpp_std=c++17'],
+    default_options : [
+        'cpp_std=c++17',
+        'buildtype=release'
+    ],
 )
 
 cpp_args = []
@@ -29,11 +32,12 @@ wayland_cursor = dependency('wayland-cursor')
 wayland_protos = dependency('wayland-protocols')
 wlroots = dependency('wlroots', fallback: ['wlroots', 'wlroots'])
 gtkmm = dependency('gtkmm-3.0')
+dbusmenu_gtk = dependency('dbusmenu-gtk3-0.4', required: get_option('dbusmenu-gtk'))
 jsoncpp = dependency('jsoncpp')
 sigcpp = dependency('sigc++-2.0')
-libnl = dependency('libnl-3.0', required: false)
+libnl = dependency('libnl-3.0', required: get_option('libnl'))
-libnlgen = dependency('libnl-genl-3.0', required: false)
+libnlgen = dependency('libnl-genl-3.0', required: get_option('libnl'))
-libpulse = dependency('libpulse', required: false)
+libpulse = dependency('libpulse', required: get_option('pulseaudio'))
 
 src_files = files(
     'src/factory.cpp',
@@ -48,7 +52,7 @@ src_files = files(
     'src/client.cpp'
 )
 
-if find_program('sway').found()
+if find_program('sway', required : false).found()
     add_project_arguments('-DHAVE_SWAY', language: 'cpp')
     src_files += [
         'src/modules/sway/ipc/client.cpp',
@@ -67,6 +71,16 @@ if libpulse.found()
     src_files += 'src/modules/pulseaudio.cpp'
 endif
 
+if dbusmenu_gtk.found()
+    add_project_arguments('-DHAVE_DBUSMENU', language: 'cpp')
+    src_files += files(
+        'src/modules/sni/tray.cpp',
+        'src/modules/sni/snw.cpp',
+        'src/modules/sni/snh.cpp',
+        'src/modules/sni/sni.cpp'
+    )
+endif
+
 subdir('protocol')
 
 executable(
@@ -83,9 +97,10 @@ executable(
         libinput,
         wayland_cursor,
         gtkmm,
+        dbusmenu_gtk,
         libnl,
         libnlgen,
-        libpulse,
+        libpulse
     ],
     include_directories: [include_directories('include')],
     install: true,

meson_options.txt

@@ -0,0 +1,3 @@
+option('libnl', type: 'feature', value: 'auto', description: 'Enable libnl support for network related features')
+option('pulseaudio', type: 'feature', value: 'auto', description: 'Enable support for pulseaudio')
+option('dbusmenu-gtk', type: 'feature', value: 'auto', description: 'Enable support for tray')

protocol/dbus-menu.xml

@@ -0,0 +1,69 @@
+<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
+"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
+<node>
+<interface name="com.canonical.dbusmenu">
+    <!-- Properties -->
+    <property name="Version" type="u" access="read" />
+    <property name="TextDirection" type="s" access="read" />
+    <property name="Status" type="s" access="read" />
+    <property name="IconThemePath" type="as" access="read" />
+
+    <!-- Functions -->
+    <method name="GetLayout">
+        <arg type="i" name="parentId" direction="in" />
+        <arg type="i" name="recursionDepth" direction="in" />
+        <arg type="as" name="propertyNames" direction="in" />
+        <arg type="u" name="revision" direction="out" />
+        <arg type="(ia{sv}av)" name="layout" direction="out" />
+    </method>
+
+    <method name="GetGroupProperties">
+        <arg type="ai" name="ids" direction="in" />
+        <arg type="as" name="propertyNames" direction="in" />
+        <arg type="a(ia{sv})" name="properties" direction="out" />
+    </method>
+
+    <method name="GetProperty">
+        <arg type="i" name="id" direction="in" />
+        <arg type="s" name="name" direction="in" />
+        <arg type="v" name="value" direction="out" />
+    </method>
+
+    <method name="Event">
+        <arg type="i" name="id" direction="in" />
+        <arg type="s" name="eventId" direction="in" />
+        <arg type="v" name="data" direction="in" />
+        <arg type="u" name="timestamp" direction="in" />
+    </method>
+
+    <method name="EventGroup">
+        <arg type="a(isvu)" name="events" direction="in" />
+        <arg type="ai" name="idErrors" direction="out" />
+    </method>
+
+    <method name="AboutToShow">
+        <arg type="i" name="id" direction="in" />
+        <arg type="b" name="needUpdate" direction="out" />
+    </method>
+
+    <method name="AboutToShowGroup">
+        <arg type="ai" name="ids" direction="in" />
+        <arg type="ai" name="updatesNeeded" direction="out" />
+        <arg type="ai" name="idErrors" direction="out" />
+    </method>
+
+    <!-- Signals -->
+    <signal name="ItemsPropertiesUpdated">
+        <arg type="a(ia{sv})" name="updatedProps" direction="out" />
+        <arg type="a(ias)" name="removedProps" direction="out" />
+    </signal>
+    <signal name="LayoutUpdated">
+        <arg type="u" name="revision" direction="out" />
+        <arg type="i" name="parent" direction="out" />
+    </signal>
+    <signal name="ItemActivationRequested">
+        <arg type="i" name="id" direction="out" />
+        <arg type="u" name="timestamp" direction="out" />
+    </signal>
+</interface>
+</node>

protocol/dbus-status-notifier-item.xml

@@ -0,0 +1,77 @@
+<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
+"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
+<node>
+<interface name="org.kde.StatusNotifierItem">
+    <property name="Category" type="s" access="read"/>
+    <property name="Id" type="s" access="read"/>
+    <property name="Title" type="s" access="read"/>
+    <property name="Status" type="s" access="read"/>
+    <property name="WindowId" type="i" access="read"/>
+    <property name="Menu" type="o" access="read" />
+
+    <!-- main icon -->
+    <!-- names are preferred over pixmaps -->
+    <property name="IconName" type="s" access="read" />
+    <property name="IconThemePath" type="s" access="read" />
+
+    <!-- struct containing width, height and image data-->
+    <!-- implementation has been dropped as of now -->
+    <property name="IconPixmap" type="a(iiay)" access="read" />
+
+    <!-- not used in ayatana code, no test case so far -->
+    <property name="OverlayIconName" type="s" access="read"/>
+    <property name="OverlayIconPixmap" type="a(iiay)" access="read" />
+
+    <!-- Requesting attention icon -->
+    <property name="AttentionIconName" type="s" access="read"/>
+
+    <!--same definition as image-->
+    <property name="AttentionIconPixmap" type="a(iiay)" access="read" />
+
+    <!-- tooltip data -->
+    <!-- unimplemented as of now -->
+    <!--(iiay) is an image-->
+    <property name="ToolTip" type="(sa(iiay)ss)" access="read" />
+
+
+    <!-- interaction: actually, we do not use them. -->
+    <method name="Activate">
+        <arg name="x" type="i" direction="in"/>
+        <arg name="y" type="i" direction="in"/>
+    </method>
+    <method name="SecondaryActivate">
+        <arg name="x" type="i" direction="in"/>
+        <arg name="y" type="i" direction="in"/>
+    </method>
+    <method name="Scroll">
+        <arg name="delta" type="i" direction="in"/>
+        <arg name="dir"   type="s" direction="in"/>
+    </method>
+
+    <!-- Signals: the client wants to change something in the status-->
+    <signal name="NewTitle"></signal>
+    <signal name="NewIcon"></signal>
+    <signal name="NewIconThemePath">
+        <arg type="s" name="icon_theme_path" direction="out" />
+    </signal>
+    <signal name="NewAttentionIcon"></signal>
+    <signal name="NewOverlayIcon"></signal>
+    <signal name="NewToolTip"></signal>
+    <signal name="NewStatus">
+        <arg name="status" type="s" />
+    </signal>
+
+    <!-- ayatana labels -->
+    <!-- These are commented out because GDBusProxy would otherwise require them,
+         but they are not available for KDE indicators
+    -->
+    <!--<signal name="XAyatanaNewLabel">
+        <arg type="s" name="label" direction="out" />
+        <arg type="s" name="guide" direction="out" />
+    </signal>
+    <property name="XAyatanaLabel" type="s" access="read" />
+    <property name="XAyatanaLabelGuide" type="s" access="read" />-->
+
+
+</interface>
+</node>

protocol/dbus-status-notifier-watcher.xml

@@ -0,0 +1,42 @@
+<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN" "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
+<node>
+  <interface name="org.kde.StatusNotifierWatcher">
+
+    <!-- methods -->
+    <method name="RegisterStatusNotifierItem">
+       <arg name="service" type="s" direction="in"/>
+    </method>
+
+    <method name="RegisterStatusNotifierHost">
+       <arg name="service" type="s" direction="in"/>
+    </method>
+
+
+    <!-- properties -->
+
+    <property name="RegisteredStatusNotifierItems" type="as" access="read">
+       <annotation name="org.qtproject.QtDBus.QtTypeName.Out0" value="QStringList"/>
+    </property>
+
+    <property name="IsStatusNotifierHostRegistered" type="b" access="read"/>
+
+    <property name="ProtocolVersion" type="i" access="read"/>
+
+
+    <!-- signals -->
+
+    <signal name="StatusNotifierItemRegistered">
+        <arg type="s"/>
+    </signal>
+
+    <signal name="StatusNotifierItemUnregistered">
+        <arg type="s"/>
+    </signal>
+
+    <signal name="StatusNotifierHostRegistered">
+    </signal>
+
+    <signal name="StatusNotifierHostUnregistered">
+    </signal>
+  </interface>
+</node>

protocol/meson.build

@@ -36,10 +36,32 @@ foreach p : client_protocols
 	client_protos_headers += wayland_scanner_client.process(xml)
 endforeach
 
+gdbus_code = generator(
+    find_program('gdbus-codegen'),
+    output: '@BASENAME@.c',
+    arguments: ['--c-namespace', 'Sn', '--body', '--output', '@OUTPUT@', '@INPUT@']
+)
+
+gdbus_header = generator(
+    find_program('gdbus-codegen'),
+    output: '@BASENAME@.h',
+    arguments: ['--c-namespace', 'Sn', '--header', '--output', '@OUTPUT@', '@INPUT@']
+)
+
+client_protos_src += gdbus_code.process('./dbus-status-notifier-watcher.xml')
+client_protos_headers += gdbus_header.process('./dbus-status-notifier-watcher.xml')
+
+client_protos_src += gdbus_code.process('./dbus-status-notifier-item.xml')
+client_protos_headers += gdbus_header.process('./dbus-status-notifier-item.xml')
+
+client_protos_src += gdbus_code.process('./dbus-menu.xml')
+client_protos_headers += gdbus_header.process('./dbus-menu.xml')
+
 lib_client_protos = static_library(
 	'client_protos',
 	client_protos_src + client_protos_headers,
-	dependencies: [wayland_client]
+	dependencies: [wayland_client, gtkmm],
+	include_directories: include_directories('..'),
 ) # for the include directory
 
 client_protos = declare_dependency(

resources/config

@@ -6,19 +6,23 @@
     // Choose the order of the modules
     "modules-left": ["sway/workspaces", "custom/spotify"],
     "modules-center": ["sway/window"],
-    "modules-right": ["pulseaudio", "network", "cpu", "memory", "battery", "clock"],
+    "modules-right": ["pulseaudio", "network", "cpu", "memory", "battery", "clock", "tray"],
     // Modules configuration
-    "sway/workspaces": {
+    // "sway/workspaces": {
-        // "disable-scroll": true,
+    //     "disable-scroll": true,
-        // "all-outputs": true,
+    //     "all-outputs": true,
-        // "format-icons": {
+    //     "format": "{name}: {icon}",
-        //     "1": "",
+    //     "format-icons": {
-        //     "2": "",
+    //         "1": "",
-        //     "3": "",
+    //         "2": "",
-        //     "4": "",
+    //         "3": "",
-        //     "5": ""
+    //         "4": "",
-        // }
+    //         "5": "",
-    },
+    //         "urgent": "",
+    //         "focused": "",
+    //         "default": ""
+    //     }
+    // },
     "sway/window": {
         "max-length": 50
     },
@@ -43,12 +47,22 @@
     },
     "pulseaudio": {
         "format": "{volume}% {icon}",
+        "format-bluetooth": "{volume}% {icon}",
         "format-muted": "",
-        "format-icons": ["", ""]
+        "format-icons": {
+            "headphones": "",
+            "handsfree": "",
+            "headset": "",
+            "phone": "",
+            "portable": "",
+            "car": "",
+            "default": ["", ""]
+        }
     },
     "custom/spotify": {
         "format": " {}",
         "max-length": 40,
+        "interval": 30, // Remove this if your script is endless and write in loop
         "exec": "$HOME/.config/waybar/mediaplayer.sh", // Script in resources folder
         "exec-if": "pgrep spotify"
     }

resources/style.css

@@ -5,7 +5,7 @@
     font-size: 13px;
 }
 
-window {
+window#waybar {
     background: rgba(43, 48, 59, 0.5);
     border-bottom: 3px solid rgba(100, 114, 125, 0.5);
     color: white;
@@ -18,16 +18,12 @@ window {
     border-bottom: 3px solid transparent;
 }
 
-#workspaces button.icon label {
-    font-size: 10px;
-}
-
 #workspaces button.focused {
     background: #64727D;
     border-bottom: 3px solid white;
 }
 
-#clock, #battery, #cpu, #memory, #network, #pulseaudio, #custom-spotify {
+#clock, #battery, #cpu, #memory, #network, #pulseaudio, #custom-spotify, #tray {
     padding: 0 10px;
     margin: 0 5px;
 }
@@ -94,3 +90,7 @@ window {
     background: #66cc99;
     color: #2a5c45;
 }
+
+#tray {
+    background-color: #2980b9;
+}

src/ALabel.cpp

@@ -24,7 +24,7 @@ auto waybar::ALabel::update() -> void
   // Nothing here
 }
 
-bool waybar::ALabel::handleToggle(GdkEventButton* const& ev)
+bool waybar::ALabel::handleToggle(GdkEventButton* const& /*ev*/)
 {
   alt = !alt;
   if (alt) {
@@ -36,14 +36,25 @@ bool waybar::ALabel::handleToggle(GdkEventButton* const& ev)
   return true;
 }
 
-std::string waybar::ALabel::getIcon(uint16_t percentage)
+std::string waybar::ALabel::getIcon(uint16_t percentage, const std::string& alt)
 {
-  if (!config_["format-icons"] || !config_["format-icons"].isArray()) {
+  auto format_icons = config_["format-icons"];
-    return "";
+  if (format_icons.isObject()) {
+    if (!alt.empty() && format_icons[alt]) {
+      format_icons = format_icons[alt];
+    } else {
+      format_icons = format_icons["default"];
+    }
   }
-  auto size = config_["format-icons"].size();
+  if (format_icons.isArray()) {
-  auto idx = std::clamp(percentage / (100 / size), 0U, size - 1);
+    auto size = format_icons.size();
-  return config_["format-icons"][idx].asString();
+    auto idx = std::clamp(percentage / (100 / size), 0U, size - 1);
+    format_icons = format_icons[idx];
+  }
+  if (format_icons.isString()) {
+    return format_icons.asString();
+  }
+  return "";
 }
 
 waybar::ALabel::operator Gtk::Widget &() {

src/bar.cpp

@@ -21,6 +21,8 @@ waybar::Bar::Bar(const Client& client,
 	zxdg_output_v1_add_listener(xdg_output_, &xdgOutputListener, this);
   window.set_title("waybar");
   window.set_decorated(false);
+  window.set_name("waybar");
+  window.set_resizable(false);
   setupConfig();
   setupCss();
   setupWidgets();
@@ -198,14 +200,14 @@ auto waybar::Bar::setupWidgets() -> void
   getModules(factory, "modules-left");
   getModules(factory, "modules-center");
   getModules(factory, "modules-right");
-  for (auto& module : modules_left_) {
+  for (auto const& module : modules_left_) {
     left.pack_start(*module, false, true, 0);
   }
-  for (auto& module : modules_center_) {
+  for (auto const& module : modules_center_) {
     center.pack_start(*module, true, true, 0);
   }
   std::reverse(modules_right_.begin(), modules_right_.end());
-  for (auto& module : modules_right_) {
+  for (auto const& module : modules_right_) {
     right.pack_end(*module, false, false, 0);
   }
 }

src/client.cpp

@@ -1,10 +1,16 @@
 #include "client.hpp"
 
 waybar::Client::Client(int argc, char* argv[])
-  : gtk_app(Gtk::Application::create(argc, argv, "org.alexays.waybar")),
+  : gtk_app(Gtk::Application::create(argc, argv, "fr.arouillard.waybar")),
-    gdk_display(Gdk::Display::get_default()),
+    gdk_display(Gdk::Display::get_default())
-    wl_display(gdk_wayland_display_get_wl_display(gdk_display->gobj()))
 {
+  if (!gdk_display) {
+    throw std::runtime_error("Can't find display");
+  }
+  if (!GDK_IS_WAYLAND_DISPLAY(gdk_display->gobj())) {
+    throw std::runtime_error("Bar need to run under Wayland");
+  }
+  wl_display = gdk_wayland_display_get_wl_display(gdk_display->gobj());
   auto getFirstValidPath = [] (std::vector<std::string> possiblePaths) {
     wordexp_t p;
 

src/factory.cpp

@@ -14,10 +14,10 @@ waybar::IModule* waybar::Factory::makeModule(const std::string &name) const
     if (name == "sway/workspaces") {
       return new waybar::modules::sway::Workspaces(bar_, config_[name]);
     }
-    #endif
     if (name == "sway/window") {
       return new waybar::modules::sway::Window(bar_, config_[name]);
     }
+    #endif
     if (name == "memory") {
       return new waybar::modules::Memory(config_[name]);
     }
@@ -27,6 +27,11 @@ waybar::IModule* waybar::Factory::makeModule(const std::string &name) const
     if (name == "clock") {
       return new waybar::modules::Clock(config_[name]);
     }
+    #ifdef HAVE_DBUSMENU
+    if (name == "tray") {
+      return new waybar::modules::SNI::Tray(config_[name]);
+    }
+    #endif
     #ifdef HAVE_LIBNL
     if (name == "network") {
       return new waybar::modules::Network(config_[name]);

src/main.cpp

@@ -13,7 +13,7 @@ int main(int argc, char* argv[])
   try {
     waybar::Client c(argc, argv);
     waybar::client = &c;
-    std::signal(SIGUSR1, [] (int signal) {
+    std::signal(SIGUSR1, [] (int /*signal*/) {
       for (auto& bar : waybar::client->bars) {
         (*bar).toggle();
       }

src/modules/battery.cpp

@@ -4,7 +4,7 @@ waybar::modules::Battery::Battery(const Json::Value& config)
   : ALabel(config, "{capacity}%")
 {
   try {
-    for (auto &node : fs::directory_iterator(data_dir_)) {
+    for (auto const& node : fs::directory_iterator(data_dir_)) {
       if (fs::is_directory(node) && fs::exists(node / "capacity")
         && fs::exists(node / "status") && fs::exists(node / "uevent")) {
         batteries_.push_back(node);
@@ -20,7 +20,7 @@ waybar::modules::Battery::Battery(const Json::Value& config)
   if (fd_ == -1) {
     throw std::runtime_error("Unable to listen batteries.");
   }
-  for (auto &bat : batteries_) {
+  for (auto const& bat : batteries_) {
     inotify_add_watch(fd_, (bat / "uevent").c_str(), IN_ACCESS);
   }
   label_.set_name("battery");
@@ -51,7 +51,7 @@ auto waybar::modules::Battery::update() -> void
   try {
     uint16_t total = 0;
     std::string status;
-    for (auto &bat : batteries_) {
+    for (auto const& bat : batteries_) {
       uint16_t capacity;
       std::string _status;
       std::ifstream(bat / "capacity") >> capacity;

src/modules/clock.cpp

@@ -4,7 +4,7 @@ waybar::modules::Clock::Clock(const Json::Value& config)
   : ALabel(config, "{:%H:%M}")
 {
   label_.set_name("clock");
-  uint32_t interval = config_["interval"] ? config_["inveral"].asUInt() : 60;
+  uint32_t interval = config_["interval"] ? config_["interval"].asUInt() : 60;
   thread_ = [this, interval] {
     auto now = waybar::chrono::clock::now();
     dp.emit();

src/modules/cpu.cpp

@@ -4,7 +4,7 @@ waybar::modules::Cpu::Cpu(const Json::Value& config)
   : ALabel(config, "{}%")
 {
   label_.set_name("cpu");
-  uint32_t interval = config_["interval"] ? config_["inveral"].asUInt() : 10;
+  uint32_t interval = config_["interval"] ? config_["interval"].asUInt() : 10;
   thread_ = [this, interval] {
     dp.emit();
     thread_.sleep_for(chrono::seconds(interval));
@@ -13,7 +13,7 @@ waybar::modules::Cpu::Cpu(const Json::Value& config)
 
 auto waybar::modules::Cpu::update() -> void
 {
-  struct sysinfo info = {0};
+  struct sysinfo info = {};
   if (sysinfo(&info) == 0) {
     float f_load = 1.f / (1u << SI_LOAD_SHIFT);
     uint16_t load = info.loads[0] * f_load * 100 / get_nprocs();

src/modules/custom.cpp

@@ -7,13 +7,16 @@ waybar::modules::Custom::Custom(const std::string name,
   if (!config_["exec"]) {
     throw std::runtime_error(name_ + " has no exec path.");
   }
-  label_.set_name("custom-" + name_);
+  if (config_["interval"]) {
-  worker();
+    delayWorker();
+  } else {
+    continuousWorker();
+  }
 }
 
-void waybar::modules::Custom::worker()
+void waybar::modules::Custom::delayWorker()
 {
-  uint32_t interval = config_["interval"] ? config_["inveral"].asUInt() : 30;
+  auto interval = config_["interval"].asUInt();
   thread_ = [this, interval] {
     bool can_update = true;
     if (config_["exec-if"]) {
@@ -21,26 +24,57 @@ void waybar::modules::Custom::worker()
       if (res.exit_code != 0) {
         can_update = false;
         label_.hide();
+        label_.set_name("");
       }
     }
     if (can_update) {
+      output_ = waybar::util::command::exec(config_["exec"].asString());
       dp.emit();
     }
     thread_.sleep_for(chrono::seconds(interval));
   };
 }
 
+void waybar::modules::Custom::continuousWorker()
+{
+  auto cmd = config_["exec"].asString();
+  FILE* fp(popen(cmd.c_str(), "r"));
+  if (!fp) {
+    throw std::runtime_error("Unable to open " + cmd);
+  }
+  thread_ = [this, fp] {
+    char* buff = nullptr;
+    size_t len = 0;
+    if (getline(&buff, &len, fp) == -1) {
+      pclose(fp);
+      thread_.stop();
+      output_ = { 1, "" };
+      dp.emit();
+      return;
+    }
+
+    std::string output = buff;
+
+    // Remove last newline
+    if (!output.empty() && output[output.length()-1] == '\n') {
+      output.erase(output.length()-1);
+    }
+    output_ = { 0, output };
+    dp.emit();
+  };
+}
+
 auto waybar::modules::Custom::update() -> void
 {
-  auto res = waybar::util::command::exec(config_["exec"].asString());
-
   // Hide label if output is empty
-  if (res.out.empty() || res.exit_code != 0) {
+  if (output_.out.empty() || output_.exit_code != 0) {
     label_.hide();
+    label_.set_name("");
   } else {
-    auto str = fmt::format(format_, res.out);
+    label_.set_name("custom-" + name_);
+    auto str = fmt::format(format_, output_.out);
     label_.set_text(str);
     label_.set_tooltip_text(str);
     label_.show();
   }
-}
+}

src/modules/memory.cpp

@@ -4,7 +4,7 @@ waybar::modules::Memory::Memory(const Json::Value& config)
   : ALabel(config, "{}%")
 {
   label_.set_name("memory");
-  uint32_t interval = config_["interval"] ? config_["inveral"].asUInt() : 30;
+  uint32_t interval = config_["interval"] ? config_["interval"].asUInt() : 30;
   thread_ = [this, interval] {
     dp.emit();
     thread_.sleep_for(chrono::seconds(interval));
@@ -13,7 +13,7 @@ waybar::modules::Memory::Memory(const Json::Value& config)
 
 auto waybar::modules::Memory::update() -> void
 {
-  struct sysinfo info = {0};
+  struct sysinfo info = {};
   if (sysinfo(&info) == 0) {
     auto total = info.totalram * info.mem_unit;
     auto freeram = info.freeram * info.mem_unit;

src/modules/network.cpp

@@ -142,7 +142,7 @@ int waybar::modules::Network::getExternalInterface()
   int ifidx = -1;
 
   /* Prepare request. */
-  uint32_t reqlen = NLMSG_SPACE(sizeof(*rt));
+  constexpr uint32_t reqlen = NLMSG_SPACE(sizeof(*rt));
   char req[reqlen] = {0};
 
   /* Build the RTM_GETROUTE request. */
@@ -165,7 +165,7 @@ int waybar::modules::Network::getExternalInterface()
    * consume responses till NLMSG_DONE/NLMSG_ERROR is encountered).
    */
   do {
-    uint64_t len = netlinkResponse(sock_fd_, resp, route_buffer_size);
+    auto len = netlinkResponse(sock_fd_, resp, route_buffer_size);
     if (len < 0) {
       goto out;
     }
@@ -228,7 +228,7 @@ int waybar::modules::Network::getExternalInterface()
               break;
             }
             for (uint32_t i = 0; i < dstlen; i += 1) {
-              c |= *(unsigned char *)(RTA_DATA(attr) + i);
+              c |= *((unsigned char *)RTA_DATA(attr) + i);
             }
             has_destination = (c == 0);
             break;
@@ -255,10 +255,10 @@ out:
   return ifidx;
 }
 
-uint64_t waybar::modules::Network::netlinkRequest(int fd, void *req,
+int waybar::modules::Network::netlinkRequest(int fd, void *req,
   uint32_t reqlen, uint32_t groups)
 {
-  struct sockaddr_nl sa = {0};
+  struct sockaddr_nl sa = {};
   sa.nl_family = AF_NETLINK;
   sa.nl_groups = groups;
   struct iovec iov = { req, reqlen };
@@ -266,11 +266,11 @@ uint64_t waybar::modules::Network::netlinkRequest(int fd, void *req,
   return sendmsg(fd, &msg, 0);
 }
 
-uint64_t waybar::modules::Network::netlinkResponse(int fd, void *resp,
+int waybar::modules::Network::netlinkResponse(int fd, void *resp,
   uint32_t resplen, uint32_t groups)
 {
-  uint64_t ret;
+  int ret;
-  struct sockaddr_nl sa = {0};
+  struct sockaddr_nl sa = {};
   sa.nl_family = AF_NETLINK;
   sa.nl_groups = groups;
   struct iovec iov = { resp, resplen };

src/modules/pulseaudio.cpp

@@ -89,6 +89,7 @@ void waybar::modules::Pulseaudio::sinkInfoCb(pa_context* /*context*/,
     pa->volume_ = volume * 100.0f;
     pa->muted_ = i->mute != 0;
     pa->desc_ = i->description;
+    pa->port_name_ = i->active_port->name;
     pa->dp.emit();
   }
 }
@@ -104,6 +105,27 @@ void waybar::modules::Pulseaudio::serverInfoCb(pa_context *context,
     sinkInfoCb, data);
 }
 
+const std::string waybar::modules::Pulseaudio::getPortIcon() const
+{
+  std::vector<std::string> ports = {
+    "headphones",
+    "speaker",
+    "hdmi",
+    "headset",
+    "handsfree",
+    "portable",
+    "car",
+    "hifi",
+    "phone",
+  };
+  for (auto const& port : ports) {
+    if (port_name_.find(port) != std::string::npos) {
+      return port;
+    }
+  }
+  return "";
+}
+
 auto waybar::modules::Pulseaudio::update() -> void
 {
   auto format = format_;
@@ -111,11 +133,16 @@ auto waybar::modules::Pulseaudio::update() -> void
     format =
       config_["format-muted"] ? config_["format-muted"].asString() : format;
     label_.get_style_context()->add_class("muted");
+  } else if (port_name_.find("a2dp_sink") != std::string::npos) {
+    format = config_["format-bluetooth"]
+      ? config_["format-bluetooth"].asString() : format;
+    label_.get_style_context()->add_class("bluetooth");
   } else {
     label_.get_style_context()->remove_class("muted");
+    label_.get_style_context()->add_class("bluetooth");
   }
   label_.set_label(fmt::format(format,
     fmt::arg("volume", volume_),
-    fmt::arg("icon", getIcon(volume_))));
+    fmt::arg("icon", getIcon(volume_, getPortIcon()))));
   label_.set_tooltip_text(desc_);
 }

src/modules/sni/snh.cpp

@@ -0,0 +1,155 @@
+#include "modules/sni/snh.hpp"
+
+#include <iostream>
+
+using namespace waybar::modules::SNI;
+
+Host::Host(Glib::Dispatcher* dp)
+: dp_(dp)
+{
+  GBusNameOwnerFlags flags = static_cast<GBusNameOwnerFlags>(
+    G_BUS_NAME_OWNER_FLAGS_NONE);
+  bus_name_ = "org.kde.StatusNotifierHost-" + std::to_string(getpid());
+  object_path_ = "/StatusNotifierHost";
+  bus_name_id_ = g_bus_own_name(G_BUS_TYPE_SESSION,
+    bus_name_.c_str(), flags,
+    &Host::busAcquired, nullptr, nullptr, this, nullptr);
+}
+
+void Host::busAcquired(GDBusConnection* connection,
+  const gchar* name, gpointer data)
+{
+  auto host = static_cast<SNI::Host *>(data);
+  host->watcher_id_ = g_bus_watch_name(
+    G_BUS_TYPE_SESSION,
+    "org.kde.StatusNotifierWatcher",
+    G_BUS_NAME_WATCHER_FLAGS_NONE,
+    &Host::nameAppeared, &Host::nameVanished, data, nullptr);
+}
+
+void Host::nameAppeared(GDBusConnection* connection,
+  const gchar* name, const gchar* name_owner, gpointer data)
+{
+  auto host = static_cast<SNI::Host *>(data);
+  if (host->cancellable_ != nullptr) {
+    std::cout << "WTF" << std::endl;
+  }
+  host->cancellable_ = g_cancellable_new();
+  sn_org_kde_status_notifier_watcher_proxy_new(
+    connection,
+    G_DBUS_PROXY_FLAGS_NONE,
+    "org.kde.StatusNotifierWatcher",
+    "/StatusNotifierWatcher",
+    host->cancellable_, &Host::proxyReady, data);
+}
+
+void Host::nameVanished(GDBusConnection* connection,
+  const gchar* name, gpointer data)
+{
+  auto host = static_cast<SNI::Host *>(data);
+  g_cancellable_cancel(host->cancellable_);
+  g_clear_object(&host->cancellable_);
+  g_clear_object(&host->watcher_);
+  host->items.clear();
+}
+
+void Host::proxyReady(GObject* src, GAsyncResult* res,
+  gpointer data)
+{
+  GError* error = nullptr;
+  SnOrgKdeStatusNotifierWatcher* watcher =
+    sn_org_kde_status_notifier_watcher_proxy_new_finish(res, &error);
+  if (g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  auto host = static_cast<SNI::Host *>(data);
+  host->watcher_ = watcher;
+  if (error != nullptr) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  sn_org_kde_status_notifier_watcher_call_register_status_notifier_host(
+    host->watcher_, host->object_path_.c_str(), host->cancellable_,
+    &Host::registerHost, data);
+}
+
+void Host::registerHost(GObject* src, GAsyncResult* res,
+  gpointer data)
+{
+  GError* error = nullptr;
+  sn_org_kde_status_notifier_watcher_call_register_status_notifier_host_finish(
+    SN_ORG_KDE_STATUS_NOTIFIER_WATCHER(src), res, &error);
+  if (g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  auto host = static_cast<SNI::Host *>(data);
+  if (error != nullptr) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return; 
+  }
+  g_signal_connect(host->watcher_, "status-notifier-item-registered",
+    G_CALLBACK(&Host::itemRegistered), data);
+  g_signal_connect(host->watcher_, "status-notifier-item-unregistered",
+    G_CALLBACK(&Host::itemUnregistered), data);
+  auto items =
+    sn_org_kde_status_notifier_watcher_dup_registered_status_notifier_items(host->watcher_);
+  if (items) {
+    for (uint32_t i = 0; items[i] != nullptr; i += 1) {
+      host->addRegisteredItem(items[i]);
+    }
+  }
+  g_strfreev(items);
+}
+
+void Host::itemRegistered(
+  SnOrgKdeStatusNotifierWatcher* watcher, const gchar* service, gpointer data)
+{
+  std::cout << "Item registered" << std::endl;
+  auto host = static_cast<SNI::Host *>(data);
+  host->addRegisteredItem(service);
+}
+
+void Host::itemUnregistered(
+  SnOrgKdeStatusNotifierWatcher* watcher, const gchar* service, gpointer data)
+{
+  auto host = static_cast<SNI::Host *>(data);
+  auto [bus_name, object_path] = host->getBusNameAndObjectPath(service);
+  for (auto it = host->items.begin(); it != host->items.end(); ++it) {
+    if (it->bus_name == bus_name && it->object_path == object_path) {
+      host->items.erase(it);
+      std::cout << "Item Unregistered" << std::endl;
+      break;
+    }
+  }
+  host->dp_->emit();
+}
+
+std::tuple<std::string, std::string> Host::getBusNameAndObjectPath(
+  const gchar* service)
+{
+  std::string bus_name;
+  std::string object_path;
+  gchar* tmp = g_strstr_len(service, -1, "/");
+  if (tmp != nullptr) {
+    gchar** str = g_strsplit(service, "/", 2);
+    bus_name = str[0];
+    object_path = tmp;
+    g_strfreev(str);
+  } else {
+    bus_name = service;
+    object_path = "/StatusNotifierItem";
+  }
+  return { bus_name, object_path };
+}
+
+void Host::addRegisteredItem(const gchar* service)
+{
+  auto [bus_name, object_path] = getBusNameAndObjectPath(service);
+  items.emplace_back(bus_name, object_path, dp_);
+}

src/modules/sni/sni.cpp

@@ -0,0 +1,260 @@
+#include "modules/sni/sni.hpp"
+
+#include <iostream>
+#include <libdbusmenu-gtk/dbusmenu-gtk.h>
+
+waybar::modules::SNI::Item::Item(std::string bn, std::string op,
+                                 Glib::Dispatcher *dp)
+    : bus_name(bn), object_path(op), event_box(), icon_size(16),
+      effective_icon_size(0), image(Gtk::manage(new Gtk::Image())), dp_(dp) {
+  event_box.add(*image);
+  event_box.add_events(Gdk::BUTTON_PRESS_MASK);
+  event_box.signal_button_press_event().connect(
+      sigc::mem_fun(*this, &Item::handleClick));
+  cancellable_ = g_cancellable_new();
+  sn_org_kde_status_notifier_item_proxy_new_for_bus(
+      G_BUS_TYPE_SESSION, G_DBUS_PROXY_FLAGS_NONE, bus_name.c_str(),
+      object_path.c_str(), cancellable_, &Item::proxyReady, this);
+}
+
+void waybar::modules::SNI::Item::proxyReady(GObject *obj, GAsyncResult *res,
+                                            gpointer data) {
+  GError *error = nullptr;
+  SnOrgKdeStatusNotifierItem *proxy =
+      sn_org_kde_status_notifier_item_proxy_new_for_bus_finish(res, &error);
+  if (g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
+    g_error_free(error);
+    return;
+  }
+  auto item = static_cast<SNI::Item *>(data);
+  item->proxy_ = proxy;
+  if (error) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  auto conn = g_dbus_proxy_get_connection(G_DBUS_PROXY(proxy));
+
+  g_dbus_connection_call(conn, item->bus_name.c_str(),
+                         item->object_path.c_str(),
+                         "org.freedesktop.DBus.Properties", "GetAll",
+                         g_variant_new("(s)", "org.kde.StatusNotifierItem"),
+                         G_VARIANT_TYPE("(a{sv})"), G_DBUS_CALL_FLAGS_NONE, -1,
+                         item->cancellable_, &Item::getAll, data);
+}
+
+void waybar::modules::SNI::Item::getAll(GObject *obj, GAsyncResult *res,
+                                        gpointer data) {
+  GError *error = nullptr;
+  auto conn = G_DBUS_CONNECTION(obj);
+  GVariant *properties = g_dbus_connection_call_finish(conn, res, &error);
+  if (g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
+    g_error_free(error);
+    return;
+  }
+  auto item = static_cast<SNI::Item *>(data);
+  if (error) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  GVariantIter *it = nullptr;
+  g_variant_get(properties, "(a{sv})", &it);
+  gchar *key;
+  GVariant *value;
+  while (g_variant_iter_next(it, "{sv}", &key, &value)) {
+    if (g_strcmp0(key, "Category") == 0) {
+      item->category = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "Id") == 0) {
+      item->id = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "Title") == 0) {
+      item->title = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "Status") == 0) {
+      item->status = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "WindowId") == 0) {
+      item->window_id = g_variant_get_int32(value);
+    } else if (g_strcmp0(key, "IconName") == 0) {
+      item->icon_name = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "IconPixmap") == 0) {
+      item->icon_pixmap = item->extractPixBuf(value);
+    } else if (g_strcmp0(key, "OverlayIconName") == 0) {
+      item->overlay_icon_name = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "OverlayIconPixmap") == 0) {
+      // TODO: overlay_icon_pixmap
+    } else if (g_strcmp0(key, "AttentionIconName") == 0) {
+      item->attention_icon_name = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "AttentionIconPixmap") == 0) {
+      // TODO: attention_icon_pixmap
+    } else if (g_strcmp0(key, "AttentionMovieName") == 0) {
+      item->attention_movie_name = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "ToolTip") == 0) {
+      // TODO: tooltip
+    } else if (g_strcmp0(key, "IconThemePath") == 0) {
+      item->icon_theme_path = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "Menu") == 0) {
+      item->menu = g_variant_dup_string(value, nullptr);
+    } else if (g_strcmp0(key, "ItemIsMenu") == 0) {
+      item->item_is_menu = g_variant_get_boolean(value);
+    }
+    g_variant_unref(value);
+    g_free(key);
+  }
+  g_variant_iter_free(it);
+  g_variant_unref(properties);
+  if (item->id.empty() || item->category.empty() || item->status.empty()) {
+    std::cerr << "Invalid Status Notifier Item: " + item->bus_name + "," +
+                     item->object_path
+              << std::endl;
+    return;
+  }
+  if (!item->icon_theme_path.empty()) {
+    GtkIconTheme *icon_theme = gtk_icon_theme_get_default();
+    gtk_icon_theme_append_search_path(icon_theme,
+                                      item->icon_theme_path.c_str());
+  }
+  item->updateImage();
+  item->dp_->emit();
+  // TODO: handle change
+}
+
+Glib::RefPtr<Gdk::Pixbuf>
+waybar::modules::SNI::Item::extractPixBuf(GVariant *variant) {
+  GVariantIter *it;
+  g_variant_get(variant, "a(iiay)", &it);
+  if (it == nullptr) {
+    return Glib::RefPtr<Gdk::Pixbuf>{};
+  }
+  GVariant *val;
+  gint lwidth = 0;
+  gint lheight = 0;
+  gint width;
+  gint height;
+  guchar *array = nullptr;
+  while (g_variant_iter_loop(it, "(ii@ay)", &width, &height, &val)) {
+    if (width > 0 && height > 0 && val != nullptr &&
+        width * height > lwidth * lheight) {
+      auto size = g_variant_get_size(val);
+      /* Sanity check */
+      if (size == 4U * width * height) {
+        /* Find the largest image */
+        gconstpointer data = g_variant_get_data(val);
+        if (data != nullptr) {
+          if (array != nullptr) {
+            g_free(array);
+          }
+          array = static_cast<guchar *>(g_memdup(data, size));
+          lwidth = width;
+          lheight = height;
+        }
+      }
+    }
+  }
+  g_variant_iter_free(it);
+  if (array != nullptr) {
+    /* argb to rgba */
+    for (uint32_t i = 0; i < 4U * lwidth * lheight; i += 4) {
+      guchar alpha = array[i];
+      array[i] = array[i + 1];
+      array[i + 1] = array[i + 2];
+      array[i + 2] = array[i + 3];
+      array[i + 3] = alpha;
+    }
+    return Gdk::Pixbuf::create_from_data(array, Gdk::Colorspace::COLORSPACE_RGB,
+                                         true, 8, lwidth, lheight, 4 * lwidth);
+  }
+  return Glib::RefPtr<Gdk::Pixbuf>{};
+}
+
+void waybar::modules::SNI::Item::updateImage()
+{
+  if (!icon_name.empty()) {
+    auto pixbuf = getIconByName(icon_name, icon_size);
+    if (pixbuf->gobj() == nullptr) {
+      // Try to find icons specified by path and filename
+      try {
+        pixbuf = Gdk::Pixbuf::create_from_file(icon_name);
+        if (pixbuf->gobj() != nullptr) {
+          // An icon specified by path and filename may be the wrong size for
+          // the tray
+          pixbuf->scale_simple(icon_size - 2, icon_size - 2,
+                               Gdk::InterpType::INTERP_BILINEAR);
+        }
+      } catch (Glib::Error &e) {
+        std::cerr << "Exception: " << e.what() << std::endl;
+        pixbuf = getIconByName("image-missing", icon_size);
+      }
+    }
+    if (pixbuf->gobj() == nullptr) {
+      pixbuf = getIconByName("image-missing", icon_size);
+    }
+    image->set(pixbuf);
+  } else if (icon_pixmap) {
+    image->set(icon_pixmap);
+  } else {
+    image->set_from_icon_name("image-missing", Gtk::ICON_SIZE_MENU);
+    image->set_pixel_size(icon_size);
+  }
+  if (!menu.empty()) {
+    auto *dbmenu = dbusmenu_gtkmenu_new(bus_name.data(), menu.data());
+    if (dbmenu)
+      gtk_menu = Glib::wrap(GTK_MENU(dbmenu), false);
+  }
+}
+
+Glib::RefPtr<Gdk::Pixbuf>
+waybar::modules::SNI::Item::getIconByName(std::string name, int request_size) {
+  int icon_size = 0;
+  Glib::RefPtr<Gtk::IconTheme> icon_theme = Gtk::IconTheme::get_default();
+  icon_theme->rescan_if_needed();
+  auto sizes = icon_theme->get_icon_sizes(name.c_str());
+
+  for (auto const &size : sizes) {
+    // -1 == scalable
+    if (size == request_size || size == -1) {
+      icon_size = request_size;
+      break;
+    } else if (size < request_size || size > icon_size) {
+      icon_size = size;
+    }
+  }
+  if (icon_size == 0) {
+    icon_size = request_size;
+  }
+  return icon_theme->load_icon(name.c_str(), icon_size,
+                               Gtk::IconLookupFlags::ICON_LOOKUP_FORCE_SIZE);
+}
+
+void waybar::modules::SNI::Item::handleActivate(GObject *src, GAsyncResult *res,
+                                                gpointer data) {
+  auto item = static_cast<SNI::Item *>(data);
+  sn_org_kde_status_notifier_item_call_activate_finish(item->proxy_, res,
+                                                       nullptr);
+}
+
+void waybar::modules::SNI::Item::handleSecondaryActivate(GObject *src,
+                                                         GAsyncResult *res,
+                                                         gpointer data) {
+  auto item = static_cast<SNI::Item *>(data);
+  sn_org_kde_status_notifier_item_call_secondary_activate_finish(item->proxy_,
+                                                                 res, nullptr);
+}
+
+bool waybar::modules::SNI::Item::handleClick(GdkEventButton *const &ev) {
+  if (ev->type == GDK_BUTTON_PRESS) {
+    if (gtk_menu) {
+      if (!gtk_menu->get_attach_widget()) {
+        gtk_menu->attach_to_widget(event_box);
+      }
+      gtk_menu->popup(ev->button, ev->time);
+    } else {
+      sn_org_kde_status_notifier_item_call_activate(
+          proxy_, ev->x, ev->y, nullptr, &Item::handleActivate, this);
+    }
+  } else if (ev->type == GDK_2BUTTON_PRESS) {
+    sn_org_kde_status_notifier_item_call_secondary_activate(
+        proxy_, ev->x, ev->y, nullptr, &Item::handleSecondaryActivate, this);
+  } else {
+    return false;
+  }
+  return true;
+}

src/modules/sni/snw.cpp

@@ -0,0 +1,183 @@
+#include "modules/sni/snw.hpp"
+
+#include <iostream>
+
+using namespace waybar::modules::SNI;
+
+Watcher::Watcher()
+{
+  GBusNameOwnerFlags flags = static_cast<GBusNameOwnerFlags>(
+    G_BUS_NAME_OWNER_FLAGS_ALLOW_REPLACEMENT
+    | G_BUS_NAME_OWNER_FLAGS_REPLACE);
+  bus_name_id_ = g_bus_own_name(G_BUS_TYPE_SESSION,
+    "org.kde.StatusNotifierWatcher", flags,
+    &Watcher::busAcquired, nullptr, nullptr, this, nullptr);
+  watcher_ = sn_org_kde_status_notifier_watcher_skeleton_new();
+}
+
+Watcher::~Watcher()
+{
+}
+
+void Watcher::busAcquired(GDBusConnection* connection, const gchar* name,
+  gpointer data)
+{
+  GError* error = nullptr;
+  auto host = static_cast<SNI::Watcher*>(data);
+  g_dbus_interface_skeleton_export(G_DBUS_INTERFACE_SKELETON(host->watcher_),
+    connection, "/StatusNotifierWatcher", &error);
+  if (error != nullptr) {
+    std::cerr << error->message << std::endl;
+    g_error_free(error);
+    return;
+  }
+  g_signal_connect_swapped(host->watcher_,
+    "handle-register-status-notifier-item",
+    G_CALLBACK(&Watcher::handleRegisterItem), data);
+  g_signal_connect_swapped(host->watcher_,
+    "handle-register-status-notifier-host",
+    G_CALLBACK(&Watcher::handleRegisterHost), data);
+  sn_org_kde_status_notifier_watcher_set_protocol_version(host->watcher_, 0);
+  sn_org_kde_status_notifier_watcher_set_is_status_notifier_host_registered(
+    host->watcher_, TRUE);
+  std::cout << "Bus aquired" << std::endl;
+}
+
+gboolean Watcher::handleRegisterHost(Watcher* obj,
+  GDBusMethodInvocation* invocation, const gchar* service)
+{
+  const gchar* bus_name = service;
+  const gchar* object_path = "/StatusNotifierHost";
+
+  if (*service == '/') {
+    bus_name = g_dbus_method_invocation_get_sender(invocation);
+    object_path = service;
+  }
+  if (g_dbus_is_name(bus_name) == FALSE) {
+    g_dbus_method_invocation_return_error(invocation, G_DBUS_ERROR,
+      G_DBUS_ERROR_INVALID_ARGS, "D-Bus bus name '%s' is not valid", bus_name);
+    return TRUE;
+  }
+  auto watch = gfWatchFind(obj->hosts_, bus_name, object_path);
+  if (watch != nullptr) {
+    g_dbus_method_invocation_return_error(invocation, G_DBUS_ERROR,
+      G_DBUS_ERROR_INVALID_ARGS, "Status Notifier Host with bus name '%s' and object path '%s' is already registered",
+      bus_name, object_path);
+    return TRUE;
+  }
+  watch = gfWatchNew(GF_WATCH_TYPE_HOST, service, bus_name, object_path, obj);
+  obj->hosts_ = g_slist_prepend(obj->hosts_, watch);
+  sn_org_kde_status_notifier_watcher_set_is_status_notifier_host_registered(
+    obj->watcher_, TRUE);
+  if (g_slist_length(obj->hosts_)) {
+    sn_org_kde_status_notifier_watcher_emit_status_notifier_host_registered(
+      obj->watcher_);
+  }
+  sn_org_kde_status_notifier_watcher_complete_register_status_notifier_host(
+    obj->watcher_, invocation);
+  std::cout << "Host registered: " << bus_name << std::endl;
+  return TRUE;
+}
+
+gboolean Watcher::handleRegisterItem(Watcher* obj,
+  GDBusMethodInvocation* invocation, const gchar* service)
+{
+  const gchar* bus_name = service;
+  const gchar* object_path = "/StatusNotifierItem";
+
+  if (*service == '/') {
+    bus_name = g_dbus_method_invocation_get_sender(invocation);
+    object_path = service;
+  }
+  if (g_dbus_is_name(bus_name) == FALSE) {
+    g_dbus_method_invocation_return_error(invocation, G_DBUS_ERROR,
+      G_DBUS_ERROR_INVALID_ARGS, "D-Bus bus name '%s' is not valid", bus_name);
+    return TRUE;
+  }
+  auto watch = gfWatchFind(obj->items_, bus_name, object_path);
+  if (watch != nullptr) {
+    g_warning("Status Notifier Item with bus name '%s' and object path '%s' is already registered",
+      bus_name, object_path);
+    sn_org_kde_status_notifier_watcher_complete_register_status_notifier_item(
+      obj->watcher_, invocation);
+    return TRUE;
+  }
+  watch = gfWatchNew(GF_WATCH_TYPE_ITEM, service, bus_name, object_path, obj);
+  obj->items_ = g_slist_prepend(obj->items_, watch);
+  obj->updateRegisteredItems(obj->watcher_);
+  gchar* tmp = g_strdup_printf("%s%s", bus_name, object_path);
+  sn_org_kde_status_notifier_watcher_emit_status_notifier_item_registered(
+    obj->watcher_, tmp);
+  g_free(tmp);
+  sn_org_kde_status_notifier_watcher_complete_register_status_notifier_item(
+    obj->watcher_, invocation);
+  return TRUE;
+}
+
+Watcher::GfWatch* Watcher::gfWatchFind(GSList* list, const gchar* bus_name,
+  const gchar* object_path)
+{
+  for (GSList* l = list; l != nullptr; l = g_slist_next (l)) {
+    GfWatch* watch = static_cast<GfWatch*>(l->data);
+    if (g_strcmp0 (watch->bus_name, bus_name) == 0
+      && g_strcmp0 (watch->object_path, object_path) == 0) {
+      return watch;
+    }
+  }
+  return nullptr;
+}
+
+Watcher::GfWatch* Watcher::gfWatchNew(GfWatchType type, const gchar* service,
+  const gchar* bus_name, const gchar* object_path, Watcher* watcher)
+{
+  GfWatch* watch = g_new0(GfWatch, 1);
+  watch->type = type;
+  watch->watcher = watcher;
+  watch->service = g_strdup(service);
+  watch->bus_name = g_strdup(bus_name);
+  watch->object_path = g_strdup(object_path);
+  watch->watch_id = g_bus_watch_name(G_BUS_TYPE_SESSION, bus_name,
+    G_BUS_NAME_WATCHER_FLAGS_NONE, nullptr, &Watcher::nameVanished, watch,
+    nullptr);
+  return watch;
+}
+
+void Watcher::nameVanished(GDBusConnection* connection, const char* name,
+  gpointer data)
+{
+  auto watch = static_cast<GfWatch *>(data);
+  if (watch->type == GF_WATCH_TYPE_HOST) {
+    watch->watcher->hosts_ = g_slist_remove(watch->watcher->hosts_, watch);
+    if (watch->watcher->hosts_ == nullptr)  {
+      sn_org_kde_status_notifier_watcher_set_is_status_notifier_host_registered(
+        watch->watcher->watcher_, FALSE);
+      sn_org_kde_status_notifier_watcher_emit_status_notifier_host_registered(
+        watch->watcher->watcher_);
+    }
+  } else if (watch->type == GF_WATCH_TYPE_ITEM) {
+    watch->watcher->items_ = g_slist_remove(watch->watcher->items_, watch);
+    watch->watcher->updateRegisteredItems(watch->watcher->watcher_);
+    gchar* tmp = g_strdup_printf("%s%s", watch->bus_name, watch->object_path);
+    sn_org_kde_status_notifier_watcher_emit_status_notifier_item_unregistered(
+      watch->watcher->watcher_, tmp);
+    g_free(tmp);
+  }
+}
+
+void Watcher::updateRegisteredItems(SnOrgKdeStatusNotifierWatcher* obj)
+{
+  GVariantBuilder builder;
+  g_variant_builder_init(&builder, G_VARIANT_TYPE("as")); 
+  for (GSList* l = items_; l != nullptr; l = g_slist_next(l)) {
+    GfWatch* watch = static_cast<GfWatch*>(l->data);
+    gchar* item = g_strdup_printf("%s%s", watch->bus_name, watch->object_path);
+    g_variant_builder_add(&builder, "s", item);
+    g_free(item);
+  }
+  GVariant* variant = g_variant_builder_end(&builder);
+  const gchar** items = g_variant_get_strv(variant, nullptr);
+  sn_org_kde_status_notifier_watcher_set_registered_status_notifier_items(
+    obj, items);
+  g_variant_unref(variant);
+  g_free(items);
+}

src/modules/sni/tray.cpp

@@ -0,0 +1,21 @@
+#include "modules/sni/tray.hpp"
+
+#include <iostream>
+
+waybar::modules::SNI::Tray::Tray(const Json::Value &config)
+    : config_(config), watcher_(), host_(&dp) {}
+
+auto waybar::modules::SNI::Tray::update() -> void {
+  for (auto &item : host_.items) {
+    item.event_box.set_tooltip_text(item.title);
+    box_.pack_start(item.event_box);
+  }
+  if (box_.get_children().size() > 0) {
+    box_.set_name("tray");
+    box_.show_all();
+  } else {
+    box_.set_name("");
+  }
+}
+
+waybar::modules::SNI::Tray::operator Gtk::Widget &() { return box_; }

src/modules/sway/ipc/client.cpp

@@ -48,7 +48,7 @@ int waybar::modules::sway::Ipc::open(const std::string& socketPath) const
   addr.sun_path[sizeof(addr.sun_path) - 1] = 0;
   int l = sizeof(struct sockaddr_un);
   if (::connect(fd, reinterpret_cast<struct sockaddr *>(&addr), l) == -1) {
-    throw std::runtime_error("Unable to connect to " + socketPath);
+    throw std::runtime_error("Unable to connect to Sway");
   }
   return fd;
 }

src/modules/sway/window.cpp

@@ -1,7 +1,7 @@
 #include "modules/sway/window.hpp"
 
 waybar::modules::sway::Window::Window(Bar &bar, const Json::Value& config)
-  : ALabel(config, "{}"), bar_(bar)
+  : ALabel(config, "{}"), bar_(bar), windowId_(-1)
 {
   label_.set_name("window");
   ipc_.connect();
@@ -20,6 +20,13 @@ void waybar::modules::sway::Window::worker()
       if ((parsed["change"] == "focus" || parsed["change"] == "title")
         && parsed["container"]["focused"].asBool()) {
         window_ = parsed["container"]["name"].asString();
+        windowId_ = parsed["container"]["id"].asInt();
+        dp.emit();
+      } else if (parsed["change"] == "close"
+        && parsed["container"]["focused"].asBool()
+        && windowId_ == parsed["container"]["id"].asInt()) {
+        window_.clear();
+        windowId_ = -1;
         dp.emit();
       }
     } catch (const std::exception& e) {
@@ -34,18 +41,19 @@ auto waybar::modules::sway::Window::update() -> void
   label_.set_tooltip_text(window_);
 }
 
-std::string waybar::modules::sway::Window::getFocusedNode(Json::Value nodes)
+std::tuple<int, std::string> waybar::modules::sway::Window::getFocusedNode(
+  Json::Value nodes)
 {
-  for (auto &node : nodes) {
+  for (auto const& node : nodes) {
     if (node["focused"].asBool() && node["type"] == "con") {
-      return node["name"].asString();
+      return { node["id"].asInt(), node["name"].asString() };
     }
-    auto res = getFocusedNode(node["nodes"]);
+    auto [id, name] = getFocusedNode(node["nodes"]);
-    if (!res.empty()) {
+    if (id > -1 && !name.empty()) {
-      return res;
+      return { id, name };
     }
   }
-  return std::string();
+  return { -1, std::string() };
 }
 
 void waybar::modules::sway::Window::getFocusedWindow()
@@ -53,7 +61,9 @@ void waybar::modules::sway::Window::getFocusedWindow()
   try {
     auto res = ipc_.sendCmd(IPC_GET_TREE);
     auto parsed = parser_.parse(res.payload);
-    window_ = getFocusedNode(parsed["nodes"]);
+    auto [id, name] = getFocusedNode(parsed["nodes"]);
+    windowId_ = id;
+    window_ = name;
     Glib::signal_idle().connect_once(sigc::mem_fun(*this, &Window::update));
   } catch (const std::exception &e) {
     std::cerr << e.what() << std::endl;

src/modules/sway/workspaces.cpp

@@ -49,7 +49,7 @@ auto waybar::modules::sway::Workspaces::update() -> void
       ++it;
     }
   }
-  for (auto node : workspaces_) {
+  for (auto const& node : workspaces_) {
     if (!config_["all-outputs"].asBool()
       && bar_.output_name != node["output"].asString()) {
       continue;
@@ -78,6 +78,15 @@ auto waybar::modules::sway::Workspaces::update() -> void
       if (needReorder) {
         box_.reorder_child(button, node["num"].asInt());
       }
+      auto icon = getIcon(node["name"].asString(), node);
+      if (config_["format"]) {
+        auto format = config_["format"].asString();
+        button.set_label(fmt::format(format, fmt::arg("icon", icon),
+          fmt::arg("name", node["name"].asString()),
+          fmt::arg("index", node["num"].asString())));
+      } else {
+        button.set_label(icon);
+      }
       button.show();
     }
   }
@@ -88,12 +97,14 @@ auto waybar::modules::sway::Workspaces::update() -> void
 
 void waybar::modules::sway::Workspaces::addWorkspace(Json::Value node)
 {
-  auto icon = getIcon(node["name"].asString());
+  auto icon = getIcon(node["name"].asString(), node);
-  auto pair = buttons_.emplace(node["num"].asInt(), icon);
+  auto format = config_["format"]
+    ? fmt::format(config_["format"].asString(), fmt::arg("icon", icon),
+      fmt::arg("name", node["name"].asString()),
+      fmt::arg("index", node["num"].asString()))
+    : icon;
+  auto pair = buttons_.emplace(node["num"].asInt(), format);
   auto &button = pair.first->second;
-  if (icon != node["name"].asString()) {
-    button.get_style_context()->add_class("icon");
-  }
   box_.pack_start(button, false, false, 0);
   button.set_relief(Gtk::RELIEF_NONE);
   button.signal_clicked().connect([this, pair] {
@@ -123,13 +134,19 @@ void waybar::modules::sway::Workspaces::addWorkspace(Json::Value node)
   button.show();
 }
 
-std::string waybar::modules::sway::Workspaces::getIcon(std::string name)
+std::string waybar::modules::sway::Workspaces::getIcon(std::string name,
+  Json::Value node)
 {
-  if (config_["format-icons"][name]) {
+  std::vector<std::string> keys = {
-    return config_["format-icons"][name].asString();
+    name, "urgent", "focused", "visible", "default"};
-  }
+  for (auto const& key : keys) {
-  if (config_["format-icons"]["default"]) {
+    if (key == "focused" || key == "visible" || key == "urgent") {
-    return config_["format-icons"]["default"].asString();
+      if (config_["format-icons"][key] && node[key].asBool()) {
+        return config_["format-icons"][key].asString();
+      }
+    } else if (config_["format-icons"][key]) {
+      return config_["format-icons"][key].asString();
+    }
   }
   return name;
 }