tobias/waybar
1
0
Fork 0
mirror of https://github.com/rad4day/Waybar.git synced 2023-12-21 10:22:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ensure no NULL tags are set

Browse Source 
Because `mpd_song_get_tag` from libmpdclient can return NULL, verify the
value of tag is valid. Otherwise, set a default string of "N/A". Also
adds configuration to specify what this default string should be.
This commit is contained in:
Cole Helbling 2019-04-20 09:12:30 -07:00
parent d03997bdaa
commit 160837b900
No known key found for this signature in database
GPG Key ID: B37E0F2371016A4C
3 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/modules/mpd.hpp
View File

@ -15,6 +15,7 @@ class MPD : public ALabel {
private: private:
std::thread periodic_updater(); std::thread periodic_updater();
std::string getTag(mpd_tag_type type, unsigned idx = 0);
void setLabel(); void setLabel();
std::string getStateIcon(); std::string getStateIcon();
std::string getOptionIcon(std::string optionName, bool activated); std::string getOptionIcon(std::string optionName, bool activated);

1
resources/config
View File

@ -30,6 +30,7 @@
"format": "{stateIcon} {consumeIcon}{randomIcon}{repeatIcon}{singleIcon}{artist} - {album} - {title} ({elapsedTime:%M:%S}/{totalTime:%M:%S}) ", "format": "{stateIcon} {consumeIcon}{randomIcon}{repeatIcon}{singleIcon}{artist} - {album} - {title} ({elapsedTime:%M:%S}/{totalTime:%M:%S}) ",
"format-disconnected": "Disconnected ", "format-disconnected": "Disconnected ",
"format-stopped": "{consumeIcon}{randomIcon}{repeatIcon}{singleIcon}Stopped ", "format-stopped": "{consumeIcon}{randomIcon}{repeatIcon}{singleIcon}Stopped ",
"unknown-tag": "N/A",
"interval": 2, "interval": 2,
"consume-icons": { "consume-icons": {
"on": " " "on": " "

21
src/modules/mpd.cpp
View File

@ -75,6 +75,17 @@ std::thread waybar::modules::MPD::periodic_updater() {
}); });
} }
std::string waybar::modules::MPD::getTag(mpd_tag_type type, unsigned idx) {
std::string result = config_["unknown-tag"].isString() ? config_["unknown-tag"].asString() : "N/A";
const char* tag = mpd_song_get_tag(song_.get(), type, idx);
// mpd_song_get_tag can return NULL, so make sure it's valid before setting
if (tag)
result = tag;
return result;
}
void waybar::modules::MPD::setLabel() { void waybar::modules::MPD::setLabel() {
if (connection_ == nullptr) { if (connection_ == nullptr) {
label_.get_style_context()->add_class("disconnected"); label_.get_style_context()->add_class("disconnected");
@ -123,11 +134,11 @@ void waybar::modules::MPD::setLabel() {
stateIcon = getStateIcon(); stateIcon = getStateIcon();
artist = mpd_song_get_tag(song_.get(), MPD_TAG_ARTIST, 0); artist = getTag(MPD_TAG_ARTIST);
album_artist = mpd_song_get_tag(song_.get(), MPD_TAG_ALBUM_ARTIST, 0); album_artist = getTag(MPD_TAG_ALBUM_ARTIST);
album = mpd_song_get_tag(song_.get(), MPD_TAG_ALBUM, 0); album = getTag(MPD_TAG_ALBUM);
title = mpd_song_get_tag(song_.get(), MPD_TAG_TITLE, 0); title = getTag(MPD_TAG_TITLE);
date = mpd_song_get_tag(song_.get(), MPD_TAG_DATE, 0); date = getTag(MPD_TAG_DATE);
elapsedTime = std::chrono::seconds(mpd_status_get_elapsed_time(status_.get())); elapsedTime = std::chrono::seconds(mpd_status_get_elapsed_time(status_.get()));
totalTime = std::chrono::seconds(mpd_status_get_total_time(status_.get())); totalTime = std::chrono::seconds(mpd_status_get_total_time(status_.get()));
} }