b4b3d51f33
With the old implementation on Windows a path like "/c:/file/ignore" got converted to "c:\file" and allowed access to files outside of FOLDER
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
#
|
|
# This file is part of Radicale Server - Calendar Server
|
|
#
|
|
# This library is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Radicale. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""
|
|
Helper functions for working with paths
|
|
|
|
"""
|
|
|
|
import os
|
|
import posixpath
|
|
|
|
from . import log
|
|
|
|
|
|
def sanitize_path(path):
|
|
"""Make absolute (with leading slash) to prevent access to other data.
|
|
Preserves an potential trailing slash."""
|
|
trailing_slash = "/" if path.endswith("/") else ""
|
|
path = posixpath.normpath(path)
|
|
new_path = "/"
|
|
for part in path.split("/"):
|
|
if not part or part in (".", ".."):
|
|
continue
|
|
new_path = posixpath.join(new_path, part)
|
|
trailing_slash = "" if new_path.endswith("/") else trailing_slash
|
|
return new_path + trailing_slash
|
|
|
|
|
|
def is_safe_filesystem_path_component(path):
|
|
"""Checks if path is a single component of a local filesystem path
|
|
and is safe to join"""
|
|
if not path:
|
|
return False
|
|
drive, _ = os.path.splitdrive(path)
|
|
if drive:
|
|
return False
|
|
head, _ = os.path.split(path)
|
|
if head:
|
|
return False
|
|
if path in (os.curdir, os.pardir):
|
|
return False
|
|
return True
|
|
|
|
|
|
def path_to_filesystem(path, base_folder):
|
|
"""Converts path to a local filesystem path relative to base_folder
|
|
in a secure manner or raises ValueError."""
|
|
sane_path = sanitize_path(path).strip("/")
|
|
safe_path = base_folder
|
|
if not sane_path:
|
|
return safe_path
|
|
for part in sane_path.split("/"):
|
|
if not is_safe_filesystem_path_component(part):
|
|
log.LOGGER.debug("Can't translate path safely to filesystem: %s",
|
|
path)
|
|
raise ValueError("Unsafe path")
|
|
safe_path = os.path.join(safe_path, part)
|
|
return safe_path |