tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve error message when fsync'ing files fails

Browse Source
This commit is contained in:
Unrud 2017-08-03 19:46:58 +02:00
parent ae54e8556c
commit ba5fe590c9
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
radicale/storage.py
View File

@ -736,7 +736,11 @@ class Collection(BaseCollection):
newline=newline, encoding=None if "b" in mode else self._encoding) newline=newline, encoding=None if "b" in mode else self._encoding)
try: try:
yield tmp yield tmp
self._fsync(tmp.fileno()) try:
self._fsync(tmp.fileno())
except OSError as e:
raise RuntimeError("Fsync'ing file %r failed: %s" %
(path, e)) from e
tmp.close() tmp.close()
os.replace(tmp.name, path) os.replace(tmp.name, path)
except: except:
@ -952,7 +956,11 @@ class Collection(BaseCollection):
fs[-1].write(text) fs[-1].write(text)
# sync everything at once because it's slightly faster. # sync everything at once because it's slightly faster.
for f in fs: for f in fs:
self._fsync(f.fileno()) try:
self._fsync(f.fileno())
except OSError as e:
raise RuntimeError("Fsync'ing file %r failed: %s" %
(f.name, e)) from e
self._sync_directory(self._filesystem_path) self._sync_directory(self._filesystem_path)
@classmethod @classmethod