tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use os.replace instead of os.rename

Browse Source 
On Windows os.replace sets the MOVEFILE_REPLACE_EXISTING flag for MoveFileEx.
On POSIX it's the same as os.rename.
This commit is contained in:
Unrud 2016-08-10 19:26:07 +02:00 committed by GitHub
parent 5c2075cb6c
commit b8126f8d24
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
radicale/storage.py
View File

@ -404,7 +404,7 @@ class Collection(BaseCollection):
else: else:
os.fsync(tmp.fileno()) os.fsync(tmp.fileno())
tmp.close() tmp.close()
os.rename(tmp.name, path) os.replace(tmp.name, path)
except: except:
tmp.close() tmp.close()
os.remove(tmp.name) os.remove(tmp.name)
@ -574,7 +574,7 @@ class Collection(BaseCollection):
@classmethod @classmethod
def move(cls, item, to_collection, to_href): def move(cls, item, to_collection, to_href):
os.rename( os.replace(
path_to_filesystem(item.collection._filesystem_path, item.href), path_to_filesystem(item.collection._filesystem_path, item.href),
path_to_filesystem(to_collection._filesystem_path, to_href)) path_to_filesystem(to_collection._filesystem_path, to_href))
cls._sync_directory(to_collection._filesystem_path) cls._sync_directory(to_collection._filesystem_path)