tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #560 from Unrud/detclose

Browse Source 
Always close files when creating collection
This commit is contained in:
Guillaume Ayoub 2017-03-08 15:55:47 +01:00 committed by GitHub
commit 96248c299e
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
radicale/storage.py
View File

@ -25,6 +25,7 @@ entry.
"""
import contextlib
import errno
import json
import os
@ -583,17 +584,18 @@ class Collection(BaseCollection):
uploads them nonatomic and without existence checks.
"""
with contextlib.ExitStack() as stack:
fs = []
for href, item in vobject_items.items():
if not is_safe_filesystem_path_component(href):
raise UnsafePathError(href)
path = path_to_filesystem(self._filesystem_path, href)
fs.append(open(path, "w", encoding=self.encoding, newline=""))
fs.append(stack.enter_context(
open(path, "w", encoding=self.encoding, newline="")))
fs[-1].write(item.serialize())
# sync everything at once because it's slightly faster.
for f in fs:
self._fsync(f.fileno())
f.close()
self._sync_directory(self._filesystem_path)
@classmethod