tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Log invalid URLs in XML requests

Browse Source 
Before the requests either failed or the invalid hreference was silently dropped.
This commit is contained in:
Unrud 2016-09-04 20:21:23 +02:00
parent d5b8ddd71c
commit 90486f33a5
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
radicale/xmlutils.py
View File

@ -774,6 +774,9 @@ def report(base_prefix, path, xml_request, collection):
unquote(urlparse(href_element.text).path)) unquote(urlparse(href_element.text).path))
if (href_path + "/").startswith(base_prefix + "/"): if (href_path + "/").startswith(base_prefix + "/"):
hreferences.add(href_path[len(base_prefix):]) hreferences.add(href_path[len(base_prefix):])
else:
collection.logger.info(
"Skipping invalid path: %s", href_path)
else: else:
hreferences = (path,) hreferences = (path,)
filters = ( filters = (
@ -785,7 +788,14 @@ def report(base_prefix, path, xml_request, collection):
multistatus = ET.Element(_tag("D", "multistatus")) multistatus = ET.Element(_tag("D", "multistatus"))
for hreference in hreferences: for hreference in hreferences:
try:
name = name_from_path(hreference, collection) name = name_from_path(hreference, collection)
except ValueError:
collection.logger.info("Skipping invalid path: %s", hreference)
response = _item_response(base_prefix, hreference,
found_item=False)
multistatus.append(response)
continue
if name: if name:
# Reference is an item # Reference is an item
item = collection.get(name) item = collection.get(name)