diff --git a/.pylintrc b/.pylintrc deleted file mode 100644 index 3b459a4..0000000 --- a/.pylintrc +++ /dev/null @@ -1,239 +0,0 @@ -[MASTER] - -# Specify a configuration file. -#rcfile= - -# Python code to execute, usually for sys.path manipulation such as -# pygtk.require(). -#init-hook= - -# Profiled execution. -profile=no - -# Add to the black list. It should be a base name, not a -# path. You may set this option multiple times. -#ignore=CVS - -# Pickle collected data for later comparisons. -persistent=yes - -# List of plugins (as comma separated values of python modules names) to load, -# usually to register additional checkers. -load-plugins= - - -[MESSAGES CONTROL] - -# Enable the message, report, category or checker with the given id(s). You can -# either give multiple identifier separated by comma (,) or put this option -# multiple time. -#enable= - -# Disable the message, report, category or checker with the given id(s). You -# can either give multiple identifier separated by comma (,) or put this option -# multiple time. -# Remove warning removal warning -# Remove stupid warning on ** magic -# Remove stupid reimport warning -disable=I0011,W0142,W0404 - - -[REPORTS] - -# Set the output format. Available formats are text, parseable, colorized, msvs -# (visual studio) and html -#output-format=colorized - -# Include message's id in output -#include-ids=yes - -# Put messages in a separate file for each module / package specified on the -# command line instead of printing them on stdout. Reports (if any) will be -# written in a file name "pylint_global.[txt|html]". -#files-output=no - -# Tells whether to display a full report or only the messages -#reports=no - -# Python expression which should return a note less than 10 (10 is the highest -# note). You have access to the variables errors warning, statement which -# respectively contain the number of errors / warnings messages and the total -# number of statements analyzed. This is used by the global evaluation report -# (R0004). -evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) - -# Add a comment according to your evaluation note. This is used by the global -# evaluation report (R0004). -comment=no - - -[TYPECHECK] - -# Tells whether missing members accessed in mixin class should be ignored. A -# mixin class is detected if its name ends with "mixin" (case insensitive). -ignore-mixin-members=yes - -# List of classes names for which member attributes should not be checked -# (useful for classes with attributes dynamically set). -ignored-classes=ParseResult,radicale.config,ldap - -# When zope mode is activated, add a predefined set of Zope acquired attributes -# to generated-members. -zope=no - -# List of members which are set dynamically and missed by pylint inference -# system, and so shouldn't trigger E0201 when accessed. -generated-members= - - -[FORMAT] - -# Maximum number of characters on a single line. -max-line-length=79 - -# Maximum number of lines in a module -max-module-lines=1000 - -# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 -# tab). -indent-string=' ' - - -[VARIABLES] - -# Tells whether we should check for unused import in __init__ files. -init-import=yes - -# A regular expression matching names used for dummy variables (i.e. not used). -dummy-variables-rgx=_ - -# List of additional names supposed to be defined in builtins. Remember that -# you should avoid to define new builtins when possible. -additional-builtins= - - -[MISCELLANEOUS] - -# List of note tags to take in consideration, separated by a comma. -notes=FIXME,XXX,TODO - - -[BASIC] - -# Required attributes for module, separated by a comma -required-attributes= - -# List of builtins function names that should not be used, separated by a comma -bad-functions=map,filter,apply,input - -# Regular expression which should only match correct module names -module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - -# Regular expression which should only match correct module level names -const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ - -# Regular expression which should only match correct class names -class-rgx=[A-Z_][a-zA-Z0-9]+$ - -# Regular expression which should only match correct function names -function-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct method names -method-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct instance attribute names -attr-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct argument names -argument-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct variable names -variable-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct list comprehension / -# generator expression variable names -inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ - -# Good variable names which should always be accepted, separated by a comma -good-names=i,j,_ - -# Bad variable names which should always be refused, separated by a comma -bad-names=foo,bar,baz,toto,tutu,tata - -# Regular expression which should only match functions or classes name which do -# not require a docstring -no-docstring-rgx=__.*__ - - -[SIMILARITIES] - -# Minimum lines number of a similarity. -min-similarity-lines=4 - -# Ignore comments when computing similarities. -ignore-comments=yes - -# Ignore docstrings when computing similarities. -ignore-docstrings=yes - - -[CLASSES] - -# List of interface methods to ignore, separated by a comma. This is used for -# instance to not check methods defines in Zope's Interface base class. -ignore-iface-methods= - -# List of method names used to declare (i.e. assign) instance attributes. -defining-attr-methods=__init__,__new__ - - -[DESIGN] - -# Maximum number of arguments for function / method -max-args=5 - -# Argument names that match this expression will be ignored. Default to name -# with leading underscore -ignored-argument-names=_.* - -# Maximum number of locals for function / method body -max-locals=15 - -# Maximum number of return / yield for function / method body -max-returns=6 - -# Maximum number of branch for function / method body -max-branchs=12 - -# Maximum number of statements in function / method body -max-statements=50 - -# Maximum number of parents for a class (see R0901). -max-parents=7 - -# Maximum number of attributes for a class (see R0902). -max-attributes=7 - -# Minimum number of public methods for a class (see R0903). -min-public-methods=2 - -# Maximum number of public methods for a class (see R0904). -max-public-methods=20 - - -[IMPORTS] - -# Deprecated modules which should not be used, separated by a comma -deprecated-modules=regsub,string,TERMIOS,Bastion,rexec - -# Create a graph of every (i.e. internal and external) dependencies in the -# given file (report RP0402 must not be disabled) -import-graph= - -# Create a graph of external dependencies in the given file (report RP0402 must -# not be disabled) -ext-import-graph= - -# Create a graph of internal dependencies in the given file (report RP0402 must -# not be disabled) -int-import-graph= diff --git a/radicale/__init__.py b/radicale/__init__.py index 93394b6..bbf6104 100644 --- a/radicale/__init__.py +++ b/radicale/__init__.py @@ -396,9 +396,6 @@ class Application: return response(status, headers, answer) - # All these functions must have the same parameters, some are useless - # pylint: disable=W0612,W0613,R0201 - def do_DELETE(self, environ, read_collections, write_collections, content, user): """Manage DELETE request.""" @@ -635,5 +632,3 @@ class Application: answer = xmlutils.report(environ["PATH_INFO"], content, collection) return client.MULTI_STATUS, headers, answer - - # pylint: enable=W0612,W0613,R0201 diff --git a/radicale/__main__.py b/radicale/__main__.py index d1f82be..3fcbcd6 100644 --- a/radicale/__main__.py +++ b/radicale/__main__.py @@ -37,9 +37,6 @@ from . import ( ThreadedHTTPSServer, config, log) -# This is a script, many branches and variables -# pylint: disable=R0912,R0914 - def run(): """Run Radicale as a standalone server.""" # Get command-line options @@ -242,8 +239,6 @@ def serve(configuration, logger): if server: server.handle_request() -# pylint: enable=R0912,R0914 - if __name__ == "__main__": run() diff --git a/radicale/auth.py b/radicale/auth.py index ea43f16..a9696c2 100644 --- a/radicale/auth.py +++ b/radicale/auth.py @@ -147,7 +147,7 @@ class Auth(BaseAuth): """Check if ``hash_value`` and ``password`` match, sha1 method.""" hash_value = hash_value.replace("{SHA}", "").encode("ascii") password = password.encode(self.configuration.get("encoding", "stock")) - sha1 = hashlib.sha1() # pylint: disable=E1101 + sha1 = hashlib.sha1() sha1.update(password) return sha1.digest() == base64.b64decode(hash_value) @@ -163,7 +163,7 @@ class Auth(BaseAuth): password = password.encode(self.configuration.get("encoding", "stock")) hash_value = hash_value[:20] salt_value = hash_value[20:] - sha1 = hashlib.sha1() # pylint: disable=E1101 + sha1 = hashlib.sha1() sha1.update(password) sha1.update(salt_value) return sha1.digest() == hash_value diff --git a/radicale/xmlutils.py b/radicale/xmlutils.py index 57552b9..4337e38 100644 --- a/radicale/xmlutils.py +++ b/radicale/xmlutils.py @@ -71,11 +71,8 @@ def _pretty_xml(element, level=0): element.tail = i for sub_element in element: _pretty_xml(sub_element, level + 1) - # ``sub_element`` is always defined as len(element) > 0 - # pylint: disable=W0631 if not sub_element.tail or not sub_element.tail.strip(): sub_element.tail = i - # pylint: enable=W0631 else: if level and (not element.tail or not element.tail.strip()): element.tail = i @@ -604,8 +601,6 @@ def _propfind_response(path, item, props, user, write=False): tag.text = _href(collection, path) element.append(tag) elif tag == _tag("C", "supported-calendar-component-set"): - # This is not a Todo - # pylint: disable=W0511 human_tag = _tag_from_clark(tag) if is_collection and is_leaf: meta = item.get_meta(human_tag) @@ -619,7 +614,6 @@ def _propfind_response(path, item, props, user, write=False): element.append(comp) else: is404 = True - # pylint: enable=W0511 elif tag == _tag("D", "current-user-principal") and user: tag = ET.Element(_tag("D", "href")) tag.text = _href(collection, "/%s/" % user)