tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimise collection creation by avoiding nested_loop

Browse Source
This commit is contained in:
Florian Mounier 2016-07-07 15:45:01 +02:00
parent 21461ddb4e
commit 364ed3689d
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
radicale/storage.py
View File

@ -35,7 +35,8 @@ import time
from contextlib import contextmanager
from hashlib import md5
from importlib import import_module
from uuid import uuid4
from itertools import groupby
from random import getrandbits
import vobject
@ -372,25 +373,26 @@ class Collection(BaseCollection):
items = []
for content in ("vevent", "vtodo", "vjournal"):
items.extend(getattr(collection, "%s_list" % content, []))
processed_uids = []
for i, item in enumerate(items):
uid = getattr(item, "uid", None)
if uid in processed_uids:
continue
def get_uid(item):
return hasattr(item, 'uid') and item.uid.value
items_by_uid = groupby(
sorted(items, key=get_uid), get_uid)
for uid, items in items_by_uid:
for item in items:
new_collection = vobject.iCalendar()
new_collection.add(item)
if uid:
processed_uids.append(uid)
# search for items with same UID
for oitem in items[i+1:]:
if getattr(oitem, "uid", None) == uid:
new_collection.add(oitem)
self.upload(uuid4().hex, new_collection)
file_name = hex(getrandbits(32))[2:]
self.upload(file_name, new_collection)
elif tag == "VCARD":
self.set_meta("tag", "VADDRESSBOOK")
if collection:
for card in collection:
self.upload(uuid4().hex, card)
file_name = hex(getrandbits(32))[2:]
self.upload(file_name, card)
return self
def list(self):