Optimise collection creation by avoiding nested_loop

radicale/storage.py

@@ -35,7 +35,8 @@ import time
 from contextlib import contextmanager
 from hashlib import md5
 from importlib import import_module
-from uuid import uuid4
+from itertools import groupby
+from random import getrandbits
 
 import vobject
 
@@ -372,25 +373,26 @@ class Collection(BaseCollection):
                 items = []
                 for content in ("vevent", "vtodo", "vjournal"):
                     items.extend(getattr(collection, "%s_list" % content, []))
-                processed_uids = []
+
-                for i, item in enumerate(items):
+                def get_uid(item):
-                    uid = getattr(item, "uid", None)
+                    return hasattr(item, 'uid') and item.uid.value
-                    if uid in processed_uids:
+
-                        continue
+                items_by_uid = groupby(
+                    sorted(items, key=get_uid), get_uid)
+
+                for uid, items in items_by_uid:
+                    for item in items:
                         new_collection = vobject.iCalendar()
                         new_collection.add(item)
-                    if uid:
+                    file_name = hex(getrandbits(32))[2:]
-                        processed_uids.append(uid)
+                    self.upload(file_name, new_collection)
-                        # search for items with same UID
+
-                        for oitem in items[i+1:]:
-                            if getattr(oitem, "uid", None) == uid:
-                                new_collection.add(oitem)
-                    self.upload(uuid4().hex, new_collection)
         elif tag == "VCARD":
             self.set_meta("tag", "VADDRESSBOOK")
             if collection:
                 for card in collection:
-                    self.upload(uuid4().hex, card)
+                    file_name = hex(getrandbits(32))[2:]
+                    self.upload(file_name, card)
         return self
 
     def list(self):