Merge pull request #600 from Unrud/auth
Test and fix auth module. Configurable delay. Improve logging.
This commit is contained in:
commit
1b5bfee96c
3
config
3
config
@ -78,6 +78,9 @@
|
|||||||
# bcrypt and md5 require the passlib library to be installed.
|
# bcrypt and md5 require the passlib library to be installed.
|
||||||
#htpasswd_encryption = bcrypt
|
#htpasswd_encryption = bcrypt
|
||||||
|
|
||||||
|
# Incorrect authentication delay (seconds)
|
||||||
|
#delay = 1
|
||||||
|
|
||||||
|
|
||||||
[rights]
|
[rights]
|
||||||
|
|
||||||
|
@ -34,11 +34,13 @@ import itertools
|
|||||||
import os
|
import os
|
||||||
import posixpath
|
import posixpath
|
||||||
import pprint
|
import pprint
|
||||||
|
import random
|
||||||
import socket
|
import socket
|
||||||
import socketserver
|
import socketserver
|
||||||
import ssl
|
import ssl
|
||||||
import sys
|
import sys
|
||||||
import threading
|
import threading
|
||||||
|
import time
|
||||||
import traceback
|
import traceback
|
||||||
import wsgiref.simple_server
|
import wsgiref.simple_server
|
||||||
import zlib
|
import zlib
|
||||||
@ -312,7 +314,7 @@ class Application:
|
|||||||
status = "%i %s" % (
|
status = "%i %s" % (
|
||||||
status, client.responses.get(status, "Unknown"))
|
status, client.responses.get(status, "Unknown"))
|
||||||
self.logger.info(
|
self.logger.info(
|
||||||
"%s answer status for %s in %s sec: %s",
|
"%s answer status for %s in %.3f seconds: %s",
|
||||||
environ["REQUEST_METHOD"], environ["PATH_INFO"] + depthinfo,
|
environ["REQUEST_METHOD"], environ["PATH_INFO"] + depthinfo,
|
||||||
(time_end - time_begin).total_seconds(), status)
|
(time_end - time_begin).total_seconds(), status)
|
||||||
start_response(status, list(headers.items()))
|
start_response(status, list(headers.items()))
|
||||||
@ -375,13 +377,22 @@ class Application:
|
|||||||
if path == "/.well-known" or path.startswith("/.well-known/"):
|
if path == "/.well-known" or path.startswith("/.well-known/"):
|
||||||
return response(*NOT_FOUND)
|
return response(*NOT_FOUND)
|
||||||
|
|
||||||
if user and not storage.is_safe_path_component(user):
|
if not user:
|
||||||
|
is_authenticated = True
|
||||||
|
elif not storage.is_safe_path_component(user):
|
||||||
# Prevent usernames like "user/calendar.ics"
|
# Prevent usernames like "user/calendar.ics"
|
||||||
self.logger.info("Refused unsafe username: %s", user)
|
self.logger.info("Refused unsafe username: %s", user)
|
||||||
is_authenticated = False
|
is_authenticated = False
|
||||||
else:
|
else:
|
||||||
is_authenticated = self.Auth.is_authenticated(user, password)
|
is_authenticated = self.Auth.is_authenticated(user, password)
|
||||||
is_valid_user = is_authenticated or not user
|
if not is_authenticated:
|
||||||
|
self.logger.info("Failed login attempt: %s", user)
|
||||||
|
# Random delay to avoid timing oracles and bruteforce attacks
|
||||||
|
delay = self.configuration.getfloat("auth", "delay")
|
||||||
|
if delay > 0:
|
||||||
|
random_delay = delay * (0.5 + random.random())
|
||||||
|
self.logger.debug("Sleeping %.3f seconds", random_delay)
|
||||||
|
time.sleep(random_delay)
|
||||||
|
|
||||||
# Create principal collection
|
# Create principal collection
|
||||||
if user and is_authenticated:
|
if user and is_authenticated:
|
||||||
@ -405,19 +416,22 @@ class Application:
|
|||||||
"Request body too large: %d", content_length)
|
"Request body too large: %d", content_length)
|
||||||
return response(*REQUEST_ENTITY_TOO_LARGE)
|
return response(*REQUEST_ENTITY_TOO_LARGE)
|
||||||
|
|
||||||
if is_valid_user:
|
if is_authenticated:
|
||||||
try:
|
try:
|
||||||
status, headers, answer = function(
|
status, headers, answer = function(
|
||||||
environ, base_prefix, path, user)
|
environ, base_prefix, path, user)
|
||||||
except socket.timeout:
|
except socket.timeout:
|
||||||
return response(*REQUEST_TIMEOUT)
|
return response(*REQUEST_TIMEOUT)
|
||||||
|
if (status, headers, answer) == NOT_ALLOWED:
|
||||||
|
self.logger.info("Access denied for %s",
|
||||||
|
"'%s'" % user if user else "anonymous user")
|
||||||
else:
|
else:
|
||||||
status, headers, answer = NOT_ALLOWED
|
status, headers, answer = NOT_ALLOWED
|
||||||
|
|
||||||
if (status, headers, answer) == NOT_ALLOWED and not (
|
if (status, headers, answer) == NOT_ALLOWED and not (
|
||||||
user and is_authenticated):
|
user and is_authenticated):
|
||||||
# Unknown or unauthorized user
|
# Unknown or unauthorized user
|
||||||
self.logger.info("%s refused" % (user or "Anonymous user"))
|
self.logger.debug("Asking client for authentication")
|
||||||
status = client.UNAUTHORIZED
|
status = client.UNAUTHORIZED
|
||||||
realm = self.configuration.get("server", "realm")
|
realm = self.configuration.get("server", "realm")
|
||||||
headers = dict(headers)
|
headers = dict(headers)
|
||||||
|
@ -56,9 +56,8 @@ following significantly more secure schemes are parsable by Radicale:
|
|||||||
import base64
|
import base64
|
||||||
import functools
|
import functools
|
||||||
import hashlib
|
import hashlib
|
||||||
|
import hmac
|
||||||
import os
|
import os
|
||||||
import random
|
|
||||||
import time
|
|
||||||
from importlib import import_module
|
from importlib import import_module
|
||||||
|
|
||||||
|
|
||||||
@ -148,11 +147,12 @@ class Auth(BaseAuth):
|
|||||||
|
|
||||||
def _plain(self, hash_value, password):
|
def _plain(self, hash_value, password):
|
||||||
"""Check if ``hash_value`` and ``password`` match, plain method."""
|
"""Check if ``hash_value`` and ``password`` match, plain method."""
|
||||||
return hash_value == password
|
return hmac.compare_digest(hash_value, password)
|
||||||
|
|
||||||
def _crypt(self, crypt, hash_value, password):
|
def _crypt(self, crypt, hash_value, password):
|
||||||
"""Check if ``hash_value`` and ``password`` match, crypt method."""
|
"""Check if ``hash_value`` and ``password`` match, crypt method."""
|
||||||
return crypt.crypt(password, hash_value) == hash_value
|
return hmac.compare_digest(crypt.crypt(password, hash_value),
|
||||||
|
hash_value)
|
||||||
|
|
||||||
def _sha1(self, hash_value, password):
|
def _sha1(self, hash_value, password):
|
||||||
"""Check if ``hash_value`` and ``password`` match, sha1 method."""
|
"""Check if ``hash_value`` and ``password`` match, sha1 method."""
|
||||||
@ -160,7 +160,7 @@ class Auth(BaseAuth):
|
|||||||
password = password.encode(self.configuration.get("encoding", "stock"))
|
password = password.encode(self.configuration.get("encoding", "stock"))
|
||||||
sha1 = hashlib.sha1()
|
sha1 = hashlib.sha1()
|
||||||
sha1.update(password)
|
sha1.update(password)
|
||||||
return sha1.digest() == base64.b64decode(hash_value)
|
return hmac.compare_digest(sha1.digest(), base64.b64decode(hash_value))
|
||||||
|
|
||||||
def _ssha(self, hash_value, password):
|
def _ssha(self, hash_value, password):
|
||||||
"""Check if ``hash_value`` and ``password`` match, salted sha1 method.
|
"""Check if ``hash_value`` and ``password`` match, salted sha1 method.
|
||||||
@ -169,15 +169,15 @@ class Auth(BaseAuth):
|
|||||||
written with e.g. openssl, and nginx can parse it.
|
written with e.g. openssl, and nginx can parse it.
|
||||||
|
|
||||||
"""
|
"""
|
||||||
hash_value = hash_value.replace(
|
hash_value = base64.b64decode(hash_value.replace(
|
||||||
"{SSHA}", "").encode("ascii").decode("base64")
|
"{SSHA}", "").encode("ascii"))
|
||||||
password = password.encode(self.configuration.get("encoding", "stock"))
|
password = password.encode(self.configuration.get("encoding", "stock"))
|
||||||
hash_value = hash_value[:20]
|
|
||||||
salt_value = hash_value[20:]
|
salt_value = hash_value[20:]
|
||||||
|
hash_value = hash_value[:20]
|
||||||
sha1 = hashlib.sha1()
|
sha1 = hashlib.sha1()
|
||||||
sha1.update(password)
|
sha1.update(password)
|
||||||
sha1.update(salt_value)
|
sha1.update(salt_value)
|
||||||
return sha1.digest() == hash_value
|
return hmac.compare_digest(sha1.digest(), hash_value)
|
||||||
|
|
||||||
def _bcrypt(self, bcrypt, hash_value, password):
|
def _bcrypt(self, bcrypt, hash_value, password):
|
||||||
return bcrypt.verify(password, hash_value)
|
return bcrypt.verify(password, hash_value)
|
||||||
@ -196,6 +196,4 @@ class Auth(BaseAuth):
|
|||||||
login, hash_value = line.split(":")
|
login, hash_value = line.split(":")
|
||||||
if login == user and self.verify(hash_value, password):
|
if login == user and self.verify(hash_value, password):
|
||||||
return True
|
return True
|
||||||
# Random timer to avoid timing oracles and simple bruteforce attacks
|
|
||||||
time.sleep(1 + random.random())
|
|
||||||
return False
|
return False
|
||||||
|
@ -93,7 +93,10 @@ INITIAL_CONFIG = OrderedDict([
|
|||||||
"help": "htpasswd filename"}),
|
"help": "htpasswd filename"}),
|
||||||
("htpasswd_encryption", {
|
("htpasswd_encryption", {
|
||||||
"value": "bcrypt",
|
"value": "bcrypt",
|
||||||
"help": "htpasswd encryption method"})])),
|
"help": "htpasswd encryption method"}),
|
||||||
|
("delay", {
|
||||||
|
"value": "1",
|
||||||
|
"help": "incorrect authentication delay"})])),
|
||||||
("rights", OrderedDict([
|
("rights", OrderedDict([
|
||||||
("type", {
|
("type", {
|
||||||
"value": "owner_only",
|
"value": "owner_only",
|
||||||
|
@ -21,15 +21,15 @@ Radicale tests with simple requests and authentication.
|
|||||||
"""
|
"""
|
||||||
|
|
||||||
import base64
|
import base64
|
||||||
import hashlib
|
|
||||||
import logging
|
import logging
|
||||||
import os
|
import os
|
||||||
import shutil
|
import shutil
|
||||||
import tempfile
|
import tempfile
|
||||||
|
|
||||||
|
import pytest
|
||||||
from radicale import Application, config
|
from radicale import Application, config
|
||||||
|
|
||||||
from . import BaseTest
|
from .test_base import BaseTest
|
||||||
|
|
||||||
|
|
||||||
class TestBaseAuthRequests(BaseTest):
|
class TestBaseAuthRequests(BaseTest):
|
||||||
@ -39,38 +39,80 @@ class TestBaseAuthRequests(BaseTest):
|
|||||||
|
|
||||||
"""
|
"""
|
||||||
def setup(self):
|
def setup(self):
|
||||||
|
self.configuration = config.load()
|
||||||
|
self.logger = logging.getLogger("radicale_test")
|
||||||
self.colpath = tempfile.mkdtemp()
|
self.colpath = tempfile.mkdtemp()
|
||||||
|
self.configuration.set("storage", "filesystem_folder", self.colpath)
|
||||||
|
# Disable syncing to disk for better performance
|
||||||
|
self.configuration.set("storage", "filesystem_fsync", "False")
|
||||||
|
# Required on Windows, doesn't matter on Unix
|
||||||
|
self.configuration.set("storage", "close_lock_file", "True")
|
||||||
|
# Set incorrect authentication delay to a very low value
|
||||||
|
self.configuration.set("auth", "delay", "0.002")
|
||||||
|
|
||||||
def teardown(self):
|
def teardown(self):
|
||||||
shutil.rmtree(self.colpath)
|
shutil.rmtree(self.colpath)
|
||||||
|
|
||||||
def test_root(self):
|
def _test_htpasswd(self, htpasswd_encryption, htpasswd_content):
|
||||||
"""Htpasswd authentication."""
|
"""Test htpasswd authentication with user "tmp" and password "bepo"."""
|
||||||
htpasswd_file_path = os.path.join(self.colpath, ".htpasswd")
|
htpasswd_file_path = os.path.join(self.colpath, ".htpasswd")
|
||||||
with open(htpasswd_file_path, "wb") as fd:
|
with open(htpasswd_file_path, "w") as f:
|
||||||
fd.write(b"tmp:{SHA}" + base64.b64encode(
|
f.write(htpasswd_content)
|
||||||
hashlib.sha1(b"bepo").digest()))
|
self.configuration.set("auth", "type", "htpasswd")
|
||||||
|
self.configuration.set("auth", "htpasswd_filename", htpasswd_file_path)
|
||||||
configuration = config.load()
|
self.configuration.set("auth", "htpasswd_encryption",
|
||||||
configuration.set("auth", "type", "htpasswd")
|
htpasswd_encryption)
|
||||||
configuration.set("auth", "htpasswd_filename", htpasswd_file_path)
|
self.application = Application(self.configuration, self.logger)
|
||||||
configuration.set("auth", "htpasswd_encryption", "sha1")
|
for user, password, expeced_status in (
|
||||||
|
("tmp", "bepo", 207), ("tmp", "tmp", 401), ("tmp", "", 401),
|
||||||
self.application = Application(
|
("unk", "unk", 401), ("unk", "", 401), ("", "", 401)):
|
||||||
configuration, logging.getLogger("radicale_test"))
|
|
||||||
|
|
||||||
status, headers, answer = self.request(
|
status, headers, answer = self.request(
|
||||||
"GET", "/", HTTP_AUTHORIZATION="dG1wOmJlcG8=")
|
"PROPFIND", "/",
|
||||||
assert status == 200
|
HTTP_AUTHORIZATION="Basic %s" % base64.b64encode(
|
||||||
assert "Radicale works!" in answer
|
("%s:%s" % (user, password)).encode()).decode())
|
||||||
|
assert status == expeced_status
|
||||||
|
|
||||||
|
def test_htpasswd_plain(self):
|
||||||
|
self._test_htpasswd("plain", "tmp:bepo")
|
||||||
|
|
||||||
|
def test_htpasswd_sha1(self):
|
||||||
|
self._test_htpasswd("sha1", "tmp:{SHA}UWRS3uSJJq2itZQEUyIH8rRajCM=")
|
||||||
|
|
||||||
|
def test_htpasswd_ssha(self):
|
||||||
|
self._test_htpasswd("ssha", "tmp:{SSHA}qbD1diw9RJKi0DnW4qO8WX9SE18W")
|
||||||
|
|
||||||
|
def test_htpasswd_md5(self):
|
||||||
|
try:
|
||||||
|
import passlib # noqa: F401
|
||||||
|
except ImportError:
|
||||||
|
pytest.skip("passlib is not installed")
|
||||||
|
self._test_htpasswd("md5", "tmp:$apr1$BI7VKCZh$GKW4vq2hqDINMr8uv7lDY/")
|
||||||
|
|
||||||
|
def test_htpasswd_crypt(self):
|
||||||
|
try:
|
||||||
|
import crypt # noqa: F401
|
||||||
|
except ImportError:
|
||||||
|
pytest.skip("crypt is not installed")
|
||||||
|
self._test_htpasswd("crypt", "tmp:dxUqxoThMs04k")
|
||||||
|
|
||||||
|
def test_htpasswd_bcrypt(self):
|
||||||
|
try:
|
||||||
|
from passlib.hash import bcrypt
|
||||||
|
from passlib.exc import MissingBackendError
|
||||||
|
except ImportError:
|
||||||
|
pytest.skip("passlib is not installed")
|
||||||
|
try:
|
||||||
|
bcrypt.encrypt("test-bcrypt-backend")
|
||||||
|
except MissingBackendError:
|
||||||
|
pytest.skip("bcrypt backend for passlib is not installed")
|
||||||
|
self._test_htpasswd(
|
||||||
|
"bcrypt",
|
||||||
|
"tmp:$2y$05$oD7hbiQFQlvCM7zoalo/T.MssV3VNTRI3w5KDnj8NTUKJNWfVpvRq")
|
||||||
|
|
||||||
def test_custom(self):
|
def test_custom(self):
|
||||||
"""Custom authentication."""
|
"""Custom authentication."""
|
||||||
configuration = config.load()
|
self.configuration.set("auth", "type", "tests.custom.auth")
|
||||||
configuration.set("auth", "type", "tests.custom.auth")
|
self.application = Application(self.configuration, self.logger)
|
||||||
self.application = Application(
|
|
||||||
configuration, logging.getLogger("radicale_test"))
|
|
||||||
|
|
||||||
status, headers, answer = self.request(
|
status, headers, answer = self.request(
|
||||||
"GET", "/", HTTP_AUTHORIZATION="dG1wOmJlcG8=")
|
"GET", "/", HTTP_AUTHORIZATION="dG1wOmJlcG8=")
|
||||||
assert status == 200
|
assert status == 200
|
||||||
|
Loading…
Reference in New Issue
Block a user