tobias/radicale
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace collection in Collection.create_collection

Browse Source
This commit is contained in:
Unrud 2016-08-08 06:08:01 +02:00
parent 9f2cbb81a3
commit 0675328a02
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
radicale/storage.py
View File

@ -294,6 +294,10 @@ class BaseCollection:
def create_collection(cls, href, collection=None, props=None): def create_collection(cls, href, collection=None, props=None):
"""Create a collection. """Create a collection.
If the collection already exists and neither ``collection`` nor
``props`` are set, this method shouldn't do anything. Otherwise the
existing collection must be replaced.
``collection`` is a list of vobject components. ``collection`` is a list of vobject components.
``props`` are metadata values for the collection. ``props`` are metadata values for the collection.
@ -551,6 +555,11 @@ class Collection(BaseCollection):
for card in collection: for card in collection:
self.upload(self._find_available_file_name(), card) self.upload(self._find_available_file_name(), card)
# This operation is not atomic on the filesystem level but it's
# very unlikely that one rename operations succeeds while the
# other fails or that only one gets written to disk.
if os.path.exists(filesystem_path):
os.rename(filesystem_path, os.path.join(tmp_dir, "delete"))
os.rename(tmp_filesystem_path, filesystem_path) os.rename(tmp_filesystem_path, filesystem_path)
sync_directory(parent_dir) sync_directory(parent_dir)