Commit Graph

1868 Commits

Author SHA1 Message Date
lilydjwg
65e4f18bb4 format exception using traceback.format_exception_only for error messages
because many exceptions return empty strings for `str(exc)`, or lack
information (e.g. the exception name).
2022-04-06 13:54:34 +08:00
Rodolfo García Peñas (kix)
253f97a3e9
Merge pull request #86 from dopefishh/communicate-syncmode-to-synchooks
Communicate syncmode to synchooks
2022-03-25 11:43:10 +01:00
Rodolfo García Peñas (kix)
b5001c2ae7
Merge pull request #98 from nicolas33/706-int-not-subscriptable
don't fail to report error when exception args are not as expected
2022-03-25 11:42:21 +01:00
Rodolfo García Peñas (kix)
725022991a
Merge pull request #112 from alessio-pascolini/fix-nonetype-decode
Update IMAP.py
2022-03-25 11:41:21 +01:00
Rodolfo García Peñas (kix)
dd0edb1446
Merge pull request #113 from hubearth/master
Allow filtering of folders with spaces
2022-03-25 11:39:48 +01:00
lilydjwg
90be450f4d fix imap4-utf-7 decoding errors
>>> import offlineimap.imaputil
>>> b'&g0l6Pw-'.decode('imap4-utf-7')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/ldata/src/offlineimap3/offlineimap/imaputil.py", line 406, in utf7m_decode
    for c in binary.decode():
AttributeError: 'memoryview' object has no attribute 'decode'

Signed-off-by: lilydjwg <lilydjwg@gmail.com>
2022-03-25 18:29:43 +08:00
Hubert Pineault
7b408b0c58 Allow filtering of folders with spaces
This patch adds support to filter folders with the space caracter.

When the folder includes spaces, the folder name must be quoted.
This commit is basicaly a copy-paste of commit 81bd57e4

Signed-off-by: Hubert Pineault <hpineault@riseup.net>
2022-03-22 00:46:39 -04:00
alessio-pascolini
210c23bdee
Update IMAP.py
Return before decoding items of imapdata, None cannot be decoded.
2022-03-08 10:22:11 +01:00
Nicolas Sebrecht
f418754087 don't fail to report error when exception args are not as expected
Also, quit the "elif" logic because each case is raising an exception.

Fixes #97
Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
2021-10-31 00:03:02 +02:00
Rodolfo García Peñas (kix)
557ca854c2 v8.0.0 2021-10-18 15:00:16 +02:00
Rodolfo García Peñas (kix)
f8cfe98d9c Include offlineimap and pid in non interactive logs
This patch includes the "offlineimap" string and the proccess id
in the output for non interactive logs and syslog logs.

Now, the output is something like this (syslog):

Oct 11 21:55:10 yangon offlineimap[635798]: Syncing foo: IMAP -> Maildir
Oct 11 21:55:10 yangon offlineimap[635798]: Syncing foo bar: IMAP -> Maildir
Oct 11 21:55:10 yangon offlineimap[635798]: Syncing INBOX: IMAP -> Maildir
Oct 11 21:55:10 yangon offlineimap[635798]: Syncing bar: IMAP -> Maildir
Oct 11 21:55:10 yangon offlineimap[635798]: Syncing Trash: IMAP -> Maildir

Closes #88
2021-10-12 18:00:51 +02:00
Rodolfo García Peñas (kix)
ea4b0438fe Support for IMAPv4 ID extension
This patch enables the ID extension of IMAPv4.

The patch sends the client name and the client version to the server.

Usually, the server doesn't require it, but in some cases the server
drop de connection if the ID is not send.

#Close #71
2021-10-12 11:58:47 +02:00
Rodolfo García Peñas (kix)
3ef991c83e Revert "Use system sslcacertfile by default"
This reverts commit a4863b2f04.
2021-10-12 10:30:09 +02:00
Rodolfo García Peñas (kix)
31149d1b1f Revert "disable verification of ssl certs via CA if fingerpint is set"
This reverts commit 871b1175f1.
2021-10-12 10:30:00 +02:00
Mart Lubbers
7748de52fb Communicate syncmode to synchooks
This patch sets the environment variable OFFLINEIMAPSYNCMODE to either
full, quick or idle depending on the context of the pre- and
postsynchook.

Adding the context as an argument was considered but this would break
existing configurations and it makes calling a program directly more
cumbersome. Some programs (e.g. imapfilter) may not know what to do with
this extra argument.

Signed-off-by: Mart Lubbers <mart@martlubbers.net>
2021-09-07 09:43:16 +02:00
peeweep
c21a7fa0a3 BUG: Right format for host using remotehosteval
Similarly to 7a428537, reading the host
using remotehosteval returns a bytes objects instead an utf-8 string.

This patch includes support for both string and bytes objects.
2021-08-14 07:02:45 +08:00
Rodolfo García Peñas (kix)
6a88896607 Handle socks connection errors
This patch handles the socks connection problems. First, move the "msg"
variable to the places where the variable is used. This variable could
be unset in the for loop, so is better move to these places.

This patch also removes the "msg" variable set in th except blocks, like
except socket.error as msg, because the variable is not used.

The patch also removes the "i" variable, not used.

Finally, the patch correct some typos.

Close: #67

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
2021-08-07 20:57:46 +02:00
Rodolfo García Peñas (kix)
48f2df4267 Handle connection refused messages
This patch handle the connection refused messages. One of these messages
is related to returned zeros.
2021-08-07 20:33:06 +02:00
Rodolfo García Peñas (kix)
81bd57e434 Allow create and delete folders with spaces
This patch adds support to create and delete folders with the space
character.

When the folder includes spaces, all the folder name must be quoted.

Close: #58

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
2021-08-07 15:46:37 +02:00
Rodolfo García Peñas (kix)
1a0c29a00e OS rename raises an exception on Windows
This patch checks the exception raises by os.rename()
on Windows and provide the same behavior than Linux.

This patch is related to issue #37, issue 5.
This patch sets closes the issue 37.
closes #37
2021-07-25 15:53:09 +02:00
Rodolfo García Peñas (kix)
c305f47e84 OSError does not include __getitem__
This patch removes the issue about using [] with
OSError instances. This es an old method from Python2.

This patch is related to issue #37, issue 4.
2021-07-25 15:53:09 +02:00
Rodolfo García Peñas (kix)
33f3b4b1aa Do not use UNIX signals in Windows
This patch does not use the signals in Windows. just avoid these calls.

This patch is related to issue #37, issue 3.
2021-07-25 15:53:09 +02:00
Rodolfo García Peñas (kix)
09fc0ece61 imaplib2 version function
The new imaplib2 version >= 3.06 includes a function "version()",
and this patch uses the old style __version__ value and the new
function.

This patch is related to issue #37, issue 2.
2021-07-25 15:53:09 +02:00
Rodolfo García Peñas (kix)
a6fd6b1ded Include portalocker in imaplibutil.py
This patch include the usage of portalocker for Windows environments,
because fcntl is not available.

This patch is related to issue #37, issue 1.
2021-07-25 15:50:47 +02:00
Rodolfo García Peñas (kix)
fe443e6bd3
Merge pull request #72 from jishac/encoding_edge_cases
Encoding: edge cases and error handling
2021-06-09 06:03:54 +02:00
Joseph Ishac
9e0fb59bdf Adding missing import of NoBoundaryInMultipartDefect 2021-06-07 22:18:31 -04:00
Joseph Ishac
5b976fc5da Making error handling when parsing messages consistent 2021-06-07 21:57:54 -04:00
Joseph Ishac
9bebcbe4f7 Adding utilities to Base class.
Moving the quoted boundary fix to the Base class so that it can be used
by any subclass that needs to read an email.  Adding another utility to
extract message-id from a raw email.
2021-06-07 20:26:26 -04:00
Joseph Ishac
b4f100c92c Merge branch to add extra debugging to imap parsing into encoding_edge_cases branch 2021-06-07 14:07:43 -04:00
Joseph Ishac
b0aad911ab Adding some extra error handling when parsing from imaplib 2021-06-07 14:05:07 -04:00
Rodolfo García Peñas (kix)
721d579a32
Merge pull request #66 from duritong/fix-fingerprint-verification
disable verification of ssl certs via CA if fingerpint is set
2021-05-09 11:28:17 +02:00
Rodolfo García Peñas (kix)
f6848015ff
Merge pull request #55 from sudipm-mukherjee/gmail
BUG: Gmail FETCH error with synclabels enabled
2021-05-09 11:24:03 +02:00
Rodolfo García Peñas (kix)
edef557bf3
Merge pull request #54 from sudipm-mukherjee/curses
BUG: Right format for password from Curses
2021-05-09 11:23:24 +02:00
mh
871b1175f1 disable verification of ssl certs via CA if fingerpint is set
Up to a4863b2 offlineimap did not include a default CA bundle. And
folks who set cert_fingerprint (because they might connect to a
host using a self-signed cert or an onion service without the onion
address in the SANs) were able to validate their certificates.

Since a4863b2 you always have a `sslcacertfile` configured (since
it always falls back to the os one) and thus the old way didn't
work anymore.

If a use defines a `cert_fingerprint` there is not much use to
validate the cert through the CA chain, since the fingerprint
is the stronges verification you can get. Therefor we can disable
verfication when `cert_fingerprint` is set.

This enables users to fetch emails again from onion services or
hosts using self-signed certifcates, but doesn't question nor
change any other behavior.

Fixes #41
2021-04-29 14:34:06 +02:00
Joseph Ishac
84b96e1daa Adding re.DOTALL to catch potentially folded lines and fixed formatting 2021-04-14 17:08:16 -04:00
Joseph Ishac
a4532294ae Correcting an issue where dbg_output was not defined when the server was
unreachable due to an optimization in PR#56.  Since message-id is more
useful to better pin point the correct message, removing dbg_output.

Also fixing https://github.com/OfflineIMAP/offlineimap3/issues/62 by
correcting broken multipart boundaries or raising an error if as_bytes()
fails.  Related python bug submitted: https://bugs.python.org/issue43818
although this workaround should be sufficent in the interim.

Signed-off-by: Joseph Ishac <jishac@nasa.gov>
2021-04-14 14:54:25 -04:00
Joseph Ishac
f024bb9e4c Wrap bytes check in a wrapper to be a bit more efficient 2021-04-14 11:19:22 -04:00
Joseph Ishac
0345390aa1 Fixed oversight in regular expression (boundary cannot be empty) 2021-04-14 11:14:44 -04:00
Joseph Ishac
b78af75064 Adding a handler to detect the unlikely edge case where a message may
have an improperly quoted boundary that can cause the python library to
fail to reproduce the original message with msg.as_bytes().  See:
https://bugs.python.org/issue43818 and
https://github.com/OfflineIMAP/offlineimap3/issues/62
2021-04-13 00:01:26 -04:00
Joseph Ishac
6a45eef3b5 Fixed a minor bug discovered if server is unreachable when debugging 2021-04-12 22:58:58 -04:00
Joseph Ishac
7e7349d8ed Final Testing of IMAP and MailDir complete. GMAIL should be patched as well and I reviewed the code several times. However, I cannot test it, testers wanted!
This commit: Minor bug fixes from testing

Should finalize implementation of enhancement #48
https://github.com/OfflineIMAP/offlineimap3/issues/48

And fix issues #43 and #44
https://github.com/OfflineIMAP/offlineimap3/issues/43
https://github.com/OfflineIMAP/offlineimap3/issues/44

Signed-off-by: Joseph Ishac <jishac@nasa.gov>
Tested-by: Joseph Ishac <jishac@nasa.gov>
2021-02-23 20:12:55 -05:00
Joseph Ishac
259bf83607 Fixing up the rest of the parsing and IMAP functions, and GMAIL classes as well. Also adding is_debugging() to the UI to allow us to quickly determine if we should build some of the expensive debug objects 2021-02-23 16:17:54 -05:00
Joseph Ishac
5fc08e529b BUG: behavior of fetch now only returns a single entry, the use of
data[0][0] here is a carry over from the old behavior of offlineimap
(python2)
2021-02-22 23:27:45 -05:00
Joseph Ishac
3166723baa Removing obsolete emailutil.py. The date functionality was pulled into folder/Base.py which now handles messages as binary objects 2021-02-21 23:20:39 -05:00
Joseph Ishac
14b318b0e2 Formatting and adding the requirements that were removed as part of the "Included charset detection" patch that was reverted. Added all but chardet~=3.0.4 which is not needed with this fix. 2021-02-21 23:09:33 -05:00
Joseph Ishac
f71ef226bf Merge branch 'master' into multiple_encoding_support. Dropping patch
for "Included charset detection"
2021-02-21 22:36:30 -05:00
Joseph Ishac
c8b275cdc3 Revert "Included charset detection"
This reverts commit 62490ff183.
2021-02-21 22:31:49 -05:00
Sudip Mukherjee
8b88441759 BUG: Gmail FETCH error with synclabels enabled
If synclabels is enabled then offlineimap is sending '1:*' to imaplib2,
and imaplib2 while creating the FETCH command is quoting the sequence
and the command becomes:
b"JFFJ10 FETCH '1:*' (FLAGS X-GM-LABELS UID)\r\n"

Remove the single-quotes to prevent that and also consider the response
as bytes.

Closes: #52

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
2021-02-20 00:34:01 +00:00
Sudip Mukherjee
3afd3395bd BUG: Exception with debug logs
When ui is set to 'Curses Blinkenlights' and debug logs are enabled,
we get an exception with 'embedded null character'.

Remove the NULL from the log, keeping the log message same as before.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
2021-02-20 00:20:36 +00:00
Sudip Mukherjee
c11232cf53 BUG: Right format for password from Curses
Reading the password from Curses Blinkenlights returns a bytes objects
instead an utf-8 string.

This patch will decode if bytes is provided.

Closes: #49

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
2021-02-20 00:20:36 +00:00