tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,661 Commits 1 Branch 0 Tags 9.2 MiB
20e3323718
Commit Graph

291 Commits

Author SHA1 Message Date
Rodolfo García Peñas (kix)
20e3323718 Base.py added docstrings 
This patch adds multiple docstrings.
 2020-11-01 09:47:17 +01:00
Rodolfo García Peñas (kix)
62bfead5e4 Maildir.py split long lines 
This patch split long lines in less 80 chars.
 2020-11-01 09:29:31 +01:00
Rodolfo García Peñas (kix)
646cb4354b Maildir.py renamed variable names 
This patch renames some variables to avoid these warnings:

Variable name "e" doesn't conform to snake_case naming style (invalid-name)
 2020-11-01 09:26:42 +01:00
Rodolfo García Peñas (kix)
5c6e95103e Maildir.py added docstrings 
This patch adds the docstring for the class and for two methods.
 2020-11-01 09:21:08 +01:00
Rodolfo García Peñas (kix)
e12a702128 GmailMaildir.py Removed __init__ 
First, in Python 3 we don't need call the super().__init__ explicitly, because Python does it. So, we can remove the line:

super().__init__(reposname, account)

If we leafe the method __init__ empty, the parent __init__ method is not called, we need remove the __init__ and then Python uses the parent __init__ method.
 2020-11-01 09:13:17 +01:00
Rodolfo García Peñas (kix)
5f338454ee GmailMaildir.py Removed parent class for super call 
The super() call in Python 3 does not need the parent class. The MRO get it.
 2020-11-01 09:06:35 +01:00
Rodolfo García Peñas (kix)
caea1b7baa GmailMaildir.py included class docstring 
Only added docstring for the class.
 2020-11-01 09:03:37 +01:00
Rodolfo García Peñas (kix)
c2fce5de38 Gmail.py removed parent class in super calls 
In Python 3 we don't need specify the class for these calls, the MRO find it.
 2020-11-01 09:02:09 +01:00
Rodolfo García Peñas (kix)
3f7e9fe1bd Gmail.py Changed comments to docstring 
This patch changes the comments in these functions to docstrings
and remove pylint warnings.
 2020-11-01 08:57:43 +01:00
Rodolfo García Peñas (kix)
fc2055de8c Gmail.py else statement not needed 
Always is else here.
 2020-11-01 08:54:16 +01:00
Rodolfo García Peñas (kix)
0454e3e2f1 Gmail.py swap if block 
I swapped this if - else block, with the "is not". Code now is clear.
 2020-11-01 08:53:08 +01:00
Rodolfo García Peñas (kix)
4198fa8201 Gmail.py else statement not needed 
We don't need speficify the else here. Always is else.
 2020-11-01 08:51:03 +01:00
Rodolfo García Peñas (kix)
d50a28a68f repository add docstring to files 
This patch includes the docstrings for all files, removing the pylint
warning
 2020-11-01 08:43:16 +01:00
Rodolfo García Peñas (kix)
23f67019cc Base.py long lines style 
This patch changes long lines (>80 chars) to lines <80 chars.
The patch only changes the style.
 2020-10-31 16:43:52 +01:00
Rodolfo García Peñas (kix)
332a6d7240 IMAP.py long lines style 
This patch changes long lines (>80 chars) to lines <80 chars.
The patch only changes the style.
 2020-10-31 16:14:53 +01:00
Rodolfo García Peñas (kix)
1ce229ca9d IMAP.py comparison with None should use is 
Comparison with None should be "is" not "=="
 2020-10-31 16:12:02 +01:00
Rodolfo García Peñas (kix)
2f2f4ef918 IMAP.py long lines style 
This patch changes long lines (>80 chars) to lines <80 chars.
The patch only changes the style.
 2020-10-31 16:09:34 +01:00
Rodolfo García Peñas (kix)
5033340c2f IMAP.py should use encoding to read the file 
This patch includes the word "encoding" to select the right argument in remotepassfile.
 2020-10-31 15:53:45 +01:00
Rodolfo García Peñas (kix)
0e90bcbf38 IMAP.py too many arguments for string format 
We need only two arguments, not three. We can remove the self argument.
 2020-10-31 15:37:50 +01:00
Rodolfo García Peñas (kix)
352133dcc0 call to setDaemon uses Bool argument 
The argument 1 should be True in these files.
 2020-10-31 15:35:54 +01:00
Rodolfo García Peñas (kix)
a4863b2f04 Use system sslcacertfile by default 
This patch includes a new functionality to get the sslcacertfile.

With this patch is possible to remove the sslcacertfile variable form the
.offlineimaprc and use the system's default. This could be easy for new users.

With this patch, the user can use ssl without the sslcacertfile option
in .offlineimaprc, use sslcacertfile = <empty> (no include anything
after the equal sign, os specify the sslcacertfile as previosly.

Currently, these are the options:

    User specifies sslacertfile -> OK
    User specifies sslacertfile=OS-DEFAULT
        If the system's default is provided -> OK
        If the system's default is not provided -> Fail
    User do not specifies sslacertfile -> Fail
    User specifies empty sslacertfile -> Fail

With the new option (this patch).

    User specifies sslacertfile -> OK
    User specifies sslacertfile=OS-DEFAULT or
    User do not specifies sslacertfile or
    User specifies empty sslacertfile
        If the system's default is provided -> OK
        If the system's default is not provided -> Fail

Closes #14
 2020-10-26 12:10:49 +01:00
Rodolfo García Peñas (kix)
47f7b1ba3c get_os_sslcertfile_searchpath do not check iterable 
Now, location is always an iterable, so we don't need check it.
 2020-10-25 17:32:38 +01:00
Rodolfo García Peñas (kix)
f66bfb0026 Renamed utils/distro.py 
The file utils/distro.py is renamed to utils/distro_utils.py
because we need import the distro file to update some calls.

The file is used in IMAP.py, I need change the import.
 2020-10-25 16:33:52 +01:00
Rodolfo García Peñas (kix)
0c04611ca4 Changed doxygen parameter 
The parameter regtype does not exists, it is reqtype.
 2020-10-10 17:48:30 +02:00
Rodolfo García Peñas (kix)
7fff7fc458 repository/__init__.py remove try import python2 
This patch removes the dup code between try and catch

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
 2020-09-03 21:36:10 +02:00
Rodolfo García Peñas (kix)
35b588f57e six: changed offlineimap/repository/__init__.py 
This patch removes the library six, compatible with python2.

I need change these re-raise calls.

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
 2020-09-03 21:36:05 +02:00
Rodolfo García Peñas (kix)
6321a66287 six: changed offlineimap/repository/IMAP.py 
This patch removes the library six, compatible with python2.

I need change this re-raise call.

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
 2020-09-03 21:36:04 +02:00
Rodolfo García Peñas (kix)
6f622c7b27 repository/IMAP.py getselectors updated 
In the patch "IMAP list folders" we updated the function getselectors
to return '""'. We use this variable in the folders, but also here.

Because the variable is never '', we need update it with this change, to
test that the variable has value, but is not empty.

Signed-off-by: Rodolfo García Peñas (kix) <kix@kix.es>
 2020-09-03 21:35:49 +02:00
Rodolfo García Peñas (kix)
caaa953616 IMAP.py list folders 
This patch changes the refernce to "", because now the empty string
is not saved as '""', is just '', so the fecth command fails.

Then, I changed the fech call to "" "*", using refernce "" and pattern
"*".
 2020-09-01 18:21:27 +02:00
Rodolfo García Peñas (kix)
ccbe42fb64 repository/Maildir.py changed not var in 
This patch changes:

if not var1 in var2

with

if var1 not in var2
 2020-08-30 14:25:55 +02:00
Rodolfo García Peñas (kix)
9779d5444a repository/IMAP.py Removed initialitation 
We don't need initialite this variable here.
 2020-08-30 14:21:04 +02:00
Rodolfo García Peñas (kix)
78b010d149 repository/IMAP.py Removed extra characters 
These characters can be removed.
 2020-08-30 14:19:34 +02:00
Rodolfo García Peñas (kix)
75f979d45b repository/Gmail.py Unused argument 
I removed this argument. The function is not used.
 2020-08-30 14:17:10 +02:00
Rodolfo García Peñas (kix)
3aba335109 repository/Base.py changed not var in 
This patch changes:

if not var1 in var2

with

if var1 not in var2
 2020-08-30 14:15:49 +02:00
Rodolfo García Peñas (kix)
ad0920de72 repository/Base.py Changed indentation 
I joined the lines to avoid indentantion warning
 2020-08-30 14:14:45 +02:00
Rodolfo García Peñas (kix)
2248a85f64 repository/__init__.py Removed unused variable 
This variable is not used.
 2020-08-30 14:13:27 +02:00
Rodolfo García Peñas (kix)
e496525b8b repository/__init__.py Removed extra chars 
These parenthesis are not needed.
 2020-08-30 14:12:35 +02:00
Rodolfo García Peñas (kix)
30afe4645e offlineimap/repository files singleton-comparison 
This patch change these errors in the repository folder

C0121: Comparison to None should be 'expr is None' (singleton-comparison)
C0121: Comparison to None should be 'expr is not None' (singleton-comparison)
 2020-08-30 11:03:57 +02:00
Rodolfo García Peñas (kix)
a186f65444 Maildir removed extra slash 
This slash should be removed. I also join the lines.
 2020-08-30 10:57:42 +02:00
Rodolfo García Peñas (kix)
e77440552c Do not make object inheritance 
This patch removes these lintian warnings:

Warning R0205: Class 'X' inherits from object,
can be safely removed from bases in python3 (useless-object-inheritance)
 2020-08-29 21:44:18 +02:00
Rodolfo García Peñas (kix)
bf08bb314d Removed not used imports 
This patch removes the import lines not used
 2020-08-29 21:20:31 +02:00
Rodolfo García Peñas (kix)
7d62441dc2 Changed import order 
These changes close the lintian warning C0411.
 2020-08-29 21:10:16 +02:00
Rodolfo García Peñas (kix)
1df1a39b11 Reformat offlineimap/folder/Maildir.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:53:38 +02:00
Rodolfo García Peñas (kix)
8ed3d1ca9a Reformat offlineimap/folder/LocalStatus.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:52:56 +02:00
Rodolfo García Peñas (kix)
80ee751243 Reformat offlineimap/folder/IMAP.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:51:25 +02:00
Rodolfo García Peñas (kix)
3d1360a7e3 Reformat offlineimap/folder/GmailMaildir.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:50:46 +02:00
Rodolfo García Peñas (kix)
7be7a70d85 Reformat offlineimap/repository/Base.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:49:37 +02:00
Rodolfo García Peñas (kix)
b64430e035 Reformat offlineimap/repository/__init__.py 
Add some spaces, remove lines,... now format is better (lintian).
 2020-08-29 19:48:41 +02:00
Rodolfo García Peñas (kix)
e84e932df4 Changed wrong comparison equal 2020-08-28 12:49:03 +02:00
Rodolfo García Peñas (kix)
5e356b0bf5 Removed codecs 
I removed these calls to codecs because I got the error:

ValueError: can't have text and binary mode at once
 2020-08-28 12:38:15 +02:00