tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

instancelimitedsems does not need a lock but must be used with global

Browse Source 
All the calls to initInstanceLimit are at initialization time from the same
thread.

Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
This commit is contained in:
Nicolas Sebrecht 2016-05-17 03:11:26 +02:00
parent c843f34876
commit f93b0963fa
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
offlineimap/threadutil.py
View File

@ -222,16 +222,16 @@ class ExitNotifyThread(Thread):
###################################################################### ######################################################################
instancelimitedsems = {} instancelimitedsems = {}
instancelimitedlock = Lock()
def initInstanceLimit(instancename, instancemax): def initInstanceLimit(instancename, instancemax):
"""Initialize the instance-limited thread implementation to permit """Initialize the instance-limited thread implementation to permit
up to intancemax threads with the given instancename.""" up to intancemax threads with the given instancename."""
instancelimitedlock.acquire() global instancelimitedsems
if not instancename in instancelimitedsems: if not instancename in instancelimitedsems:
instancelimitedsems[instancename] = BoundedSemaphore(instancemax) instancelimitedsems[instancename] = BoundedSemaphore(instancemax)
instancelimitedlock.release()
class InstanceLimitedThread(ExitNotifyThread): class InstanceLimitedThread(ExitNotifyThread):
def __init__(self, instancename, *args, **kwargs): def __init__(self, instancename, *args, **kwargs):
@ -239,10 +239,14 @@ class InstanceLimitedThread(ExitNotifyThread):
super(InstanceLimitedThread, self).__init__(*args, **kwargs) super(InstanceLimitedThread, self).__init__(*args, **kwargs)
def start(self): def start(self):
global instancelimitedsems
instancelimitedsems[self.instancename].acquire() instancelimitedsems[self.instancename].acquire()
ExitNotifyThread.start(self) ExitNotifyThread.start(self)
def run(self): def run(self):
global instancelimitedsems
try: try:
ExitNotifyThread.run(self) ExitNotifyThread.run(self)
finally: finally: