tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Don't CHECK imapserver after each APPEND"

Browse Source 
This reverts commit 47390e03d6.

It is one of two potential candidates for the APPENDUID
regression that John Wiegley reported. We need to examine this
carefully before reintroducing this patch.

Resolved Changelog.draft.rst conflict.
This commit is contained in:
Sebastian Spaeth 2012-02-24 08:31:31 +01:00
parent d1e6e1f09e
commit bc73c11239
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changelog.draft.rst
View File

@ -30,6 +30,8 @@ Changes
we would not propagate local folders to the remote repository. we would not propagate local folders to the remote repository.
(now tested in test03) (now tested in test03)
* Revert "* Slight performance enhancement uploading mails to an IMAP
server in the common case." It might have led to instabilities.
Bug Fixes Bug Fixes
--------- ---------

9
offlineimap/folder/IMAP.py
View File

@ -568,6 +568,10 @@ class IMAPFolder(BaseFolder):
"failed (error). Server reponded: %s\nMessage content was: " "failed (error). Server reponded: %s\nMessage content was: "
"%s" % (self, self.getrepository(), str(e), dbg_output), "%s" % (self, self.getrepository(), str(e), dbg_output),
OfflineImapError.ERROR.MESSAGE) OfflineImapError.ERROR.MESSAGE)
# Checkpoint. Let it write out stuff, etc. Eg searches for
# just uploaded messages won't work if we don't do this.
typ, dat = imapobj.check()
assert(typ == 'OK')
# get the new UID, default to 0 (=unknown) # get the new UID, default to 0 (=unknown)
uid = 0 uid = 0
@ -587,11 +591,6 @@ class IMAPFolder(BaseFolder):
"'%s'" % str(resp)) "'%s'" % str(resp))
else: else:
# Don't support UIDPLUS # Don't support UIDPLUS
# Checkpoint. Let it write out stuff, etc. Eg searches for
# just uploaded messages won't work if we don't do this.
typ, dat = imapobj.check()
assert(typ == 'OK')
uid = self.savemessage_searchforheader(imapobj, headername, uid = self.savemessage_searchforheader(imapobj, headername,
headervalue) headervalue)
# If everything failed up to here, search the message # If everything failed up to here, search the message