tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

threading: simplify names

Browse Source 
Improve comments.

Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
This commit is contained in:
Nicolas Sebrecht 2016-05-17 02:04:48 +02:00
parent 23f96ba880
commit 9f8aa38d62
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
offlineimap/init.py
View File

@ -392,7 +392,7 @@ class OfflineImap:
name='Sync Runner', name='Sync Runner',
kwargs={'accounts': syncaccounts, 'config': self.config}) kwargs={'accounts': syncaccounts, 'config': self.config})
t.start() t.start()
threadutil.exitnotifymonitorloop() threadutil.monitor()
if not options.dryrun: if not options.dryrun:
offlineimap.mbnames.write(True) offlineimap.mbnames.write(True)

9
offlineimap/syncmaster.py
View File

@ -16,7 +16,7 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
from offlineimap.threadutil import threadlist, InstanceLimitedThread, NORMAL_EXIT from offlineimap.threadutil import threadlist, InstanceLimitedThread, STOP_MONITOR
from offlineimap.accounts import SyncableAccount from offlineimap.accounts import SyncableAccount
from threading import currentThread from threading import currentThread
@ -32,10 +32,11 @@ def syncaccount(config, accountname):
return thread return thread
def syncitall(accounts, config): def syncitall(accounts, config):
"""The target when in multithreading mode.""" """The target when in multithreading mode for running accounts threads."""
# Special exit message for SyncRunner thread, so main thread can exit. # Special exit message for the monitor to stop looping so the main thread
currentThread().exit_message = NORMAL_EXIT # can exit.
currentThread().exit_message = STOP_MONITOR
threads = threadlist() # The collection of threads. threads = threadlist() # The collection of threads.
for accountname in accounts: for accountname in accounts:
# Start a new thread per account and store it in the collection. # Start a new thread per account and store it in the collection.

6
offlineimap/threadutil.py
View File

@ -25,7 +25,7 @@ import os.path
from offlineimap.ui import getglobalui from offlineimap.ui import getglobalui
NORMAL_EXIT = 'SYNCRUNNER_EXITED_NORMALLY' STOP_MONITOR = 'STOP_MONITOR'
###################################################################### ######################################################################
# General utilities # General utilities
@ -86,7 +86,7 @@ class threadlist:
exitthreads = Queue() exitthreads = Queue()
def exitnotifymonitorloop(): def monitor():
"""An infinite "monitoring" loop watching for finished ExitNotifyThread's. """An infinite "monitoring" loop watching for finished ExitNotifyThread's.
This one is supposed to run in the main thread. This one is supposed to run in the main thread.
@ -128,7 +128,7 @@ def exitnotifymonitorloop():
" and the ui did not stop the program."% " and the ui did not stop the program."%
(repr(thread.exit_exception), type(thread.exit_exception))) (repr(thread.exit_exception), type(thread.exit_exception)))
elif thread.exit_message == NORMAL_EXIT: elif thread.exit_message == STOP_MONITOR:
break # Exit the loop here. break # Exit the loop here.
else: else:
ui.threadExited(thread) ui.threadExited(thread)