tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make exit via 'q' key work again in Blinkenlights UI

Browse Source 
With the new abort signal handler, we can send a signal that lets us
exit cleanly. Make use of this, rather than crashing out in ugly ways.

This affects only the Blinkenlights UI when pressing 'q'.

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
This commit is contained in:
Sebastian Spaeth 2012-01-07 14:59:42 +01:00
parent 415c7d7979
commit 968dcd5780
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Changelog.draft.rst
View File

@ -19,5 +19,8 @@ Changes
Bug Fixes
---------
* Abort sleep in blinkenlights UI led to crash ('abort_signal' not existing),
* [Blinkenlights UI] Abort sleep led to crash ('abort_signal' not existing),
regression from 6.5.0.
* [Blinkenlights UI] Make exit via 'q' key work again cleanly
regression from 6.5.0.

8
offlineimap/ui/Curses.py
View File

@ -487,11 +487,9 @@ class Blinkenlights(UIBase, CursesUtil):
if key < 1 or key > 255:
return
if chr(key) == 'q':
# Request to quit.
#TODO: this causes us to bail out in main loop when the thread exits
#TODO: review and rework this mechanism.
currentThread().set_exit_exception(SystemExit("User requested shutdown"))
self.terminate()
# Request to quit completely.
self.warn("Requested shutdown via 'q'")
offlineimap.accounts.Account.set_abort_event(self.config, 3)
try:
index = int(chr(key))
except ValueError: