From 932e826d7cedc714f00f7959a2ea022ec6162a4c Mon Sep 17 00:00:00 2001 From: Nicolas Sebrecht Date: Sun, 6 Mar 2016 22:06:02 +0100 Subject: [PATCH] folder: Maildir: add comments about FMD5 issues Signed-off-by: Nicolas Sebrecht --- offlineimap/folder/Maildir.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/offlineimap/folder/Maildir.py b/offlineimap/folder/Maildir.py index f5b208c..91af24a 100644 --- a/offlineimap/folder/Maildir.py +++ b/offlineimap/folder/Maildir.py @@ -135,6 +135,13 @@ class MaildirFolder(BaseFolder): foldermatch = folderstr in filename # If there was no folder MD5 specified, or if it mismatches, # assume it is a foreign (new) message and ret: uid, fmd5 = None, None + + # XXX: This is wrong behaviour: if FMD5 is missing or mismatches, assume + # the mail is new and **fix UID to None** to avoid any conflict. + + # XXX: If UID is missing, I have no idea what FMD5 can do. Should be + # fixed to None in this case, too. + if foldermatch: uidmatch = re_uidmatch.search(filename) if uidmatch: