tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Recache folder list after creating a new folder

Browse Source 
If we create a new folder we would previously not update our folder
list, which led to us skipping the synchronization of those new folders
during the initial run (subsequent runs would pick it up).

Invalidate the folder cache when we create a folder during folder
structure sync. Regetting the whole list from an IMAP server might be
slightly suboptimal from a performance point, but it is easy and will
lead to consistent results. Hopefully we will not have to create new
folders on each new run.

Reported-by: Daniel Shahaf <d.s@daniel.shahaf.name>
Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
This commit is contained in:
Sebastian Spaeth
2011-09-30 08:58:08 +02:00
parent 3f7749016f
commit 4e89bbfe6e
5 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
offlineimap/repository/Base.py
View File

@@ -144,7 +144,8 @@ class BaseRepository(object, CustomConfig.ConfigHelperMixin):
src_repo = self
src_folders = src_repo.getfolders()
dst_folders = dst_repo.getfolders()
# Do we need to refresh the folder list afterwards?
src_haschanged, dst_haschanged = False, False
# Create hashes with the names, but convert the source folders
# to the dest folder's sep.
src_hash = {}
@@ -160,6 +161,7 @@ class BaseRepository(object, CustomConfig.ConfigHelperMixin):
if src_folder.sync_this and not src_name in dst_hash:
try:
dst_repo.makefolder(src_name)
dst_haschanged = True # Need to refresh list
except OfflineImapError, e:
self.ui.error(e, exc_info()[2],
"Creating folder %s on repository %s" %\
@@ -203,6 +205,7 @@ class BaseRepository(object, CustomConfig.ConfigHelperMixin):
try:
src_repo.makefolder(newsrc_name)
src_haschanged = True # Need to refresh list
except OfflineImapError, e:
self.ui.error(e, exc_info()[2],
"Creating folder %s on repository %s" %\
@@ -211,7 +214,13 @@ class BaseRepository(object, CustomConfig.ConfigHelperMixin):
status_repo.makefolder(newsrc_name.replace(
src_repo.getsep(), status_repo.getsep()))
# Find deleted folders.
# We don't delete folders right now.
# TODO: We don't delete folders right now.
#Forget old list of cached folders so we get new ones if needed
if src_haschanged:
self.forgetfolders()
if dst_haschanged:
dst_repo.forgetfolders()
def startkeepalive(self):
"""The default implementation will do nothing."""