tobias/docker-offlineimap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

imapserver: use boolean where it makes sense

Browse Source 
Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
This commit is contained in:
Nicolas Sebrecht 2016-05-19 08:32:38 +02:00
parent 46a6bcbf1c
commit 0b32e787c7
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
offlineimap/imapserver.py
View File

@ -46,7 +46,7 @@ try:
except ImportError: except ImportError:
pass pass
class IMAPServer: class IMAPServer(object):
"""Initializes all variables from an IMAPRepository() instance """Initializes all variables from an IMAPRepository() instance
Various functions, such as acquireconnection() return an IMAP4 Various functions, such as acquireconnection() return an IMAP4
@ -58,6 +58,7 @@ class IMAPServer:
GSS_STATE_STEP = 0 GSS_STATE_STEP = 0
GSS_STATE_WRAP = 1 GSS_STATE_WRAP = 1
def __init__(self, repos): def __init__(self, repos):
self.ui = getglobalui() self.ui = getglobalui()
self.repos = repos self.repos = repos
@ -479,9 +480,9 @@ class IMAPServer:
# Must be careful here that if we fail we should bail out gracefully # Must be careful here that if we fail we should bail out gracefully
# and release locks / threads so that the next attempt can try... # and release locks / threads so that the next attempt can try...
success = 0 success = False
try: try:
while not success: while success is not True:
# Generate a new connection. # Generate a new connection.
if self.tunnel: if self.tunnel:
self.ui.connecting('tunnel', self.tunnel) self.ui.connecting('tunnel', self.tunnel)
@ -490,7 +491,7 @@ class IMAPServer:
timeout=socket.getdefaulttimeout(), timeout=socket.getdefaulttimeout(),
use_socket=self.proxied_socket, use_socket=self.proxied_socket,
) )
success = 1 success = True
elif self.usessl: elif self.usessl:
self.ui.connecting(self.hostname, self.port) self.ui.connecting(self.hostname, self.port)
imapobj = imaplibutil.WrappedIMAP4_SSL( imapobj = imaplibutil.WrappedIMAP4_SSL(
@ -520,7 +521,7 @@ class IMAPServer:
try: try:
self.__authn_helper(imapobj) self.__authn_helper(imapobj)
self.goodpassword = self.password self.goodpassword = self.password
success = 1 success = True
except OfflineImapError as e: except OfflineImapError as e:
self.passworderror = str(e) self.passworderror = str(e)
raise raise