mirrors/pferd
1
0
Fork 0
mirror of https://github.com/Garmelon/PFERD.git synced 2023-12-21 10:23:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Warn if using concurrent tasks with kit-ilias-web

Browse Source
This commit is contained in:
Joscha 2021-05-31 21:07:13 +02:00
parent 49ad1b6e46
commit f40820c41f
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -25,6 +25,7 @@ ambiguous situations.
### Added ### Added
- `credential-file` authenticator - `credential-file` authenticator
- `--credential-file` option for `kit-ilias-web` command - `--credential-file` option for `kit-ilias-web` command
- Warning if using concurrent tasks with `kit-ilias-web`
### Fixed ### Fixed
- Date parsing now also works correctly in non-group exercises - Date parsing now also works correctly in non-group exercises

7
PFERD/crawl/ilias/kit_ilias_web_crawler.py
View File

@ -21,7 +21,6 @@ TargetType = Union[str, int]
class KitIliasWebCrawlerSection(HttpCrawlerSection): class KitIliasWebCrawlerSection(HttpCrawlerSection):
def target(self) -> TargetType: def target(self) -> TargetType:
target = self.s.get("target") target = self.s.get("target")
if not target: if not target:
@ -164,6 +163,12 @@ class KitIliasWebCrawler(HttpCrawler):
auth = section.auth(authenticators) auth = section.auth(authenticators)
super().__init__(name, section, config, shared_auth=auth) super().__init__(name, section, config, shared_auth=auth)
if section.tasks() > 1:
log.warn("""
Please avoid using too many parallel requests as these are the KIT ILIAS
instance's greatest bottleneck.
""".strip())
self._shibboleth_login = KitShibbolethLogin( self._shibboleth_login = KitShibbolethLogin(
auth, auth,
section.tfa_auth(authenticators), section.tfa_auth(authenticators),