From c8eff04ae0dc4b6528e5e8f25fb38b52fe6fd249 Mon Sep 17 00:00:00 2001
From: I-Al-Istannen <i-al-istannen@users.noreply.github.com>
Date: Wed, 19 Feb 2025 14:56:32 +0100
Subject: [PATCH] Make thread titles link to original ILIAS thread

---
 PFERD/crawl/ilias/file_templates.py    |  4 +++-
 PFERD/crawl/ilias/ilias_web_crawler.py | 20 +++++++++++---------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/PFERD/crawl/ilias/file_templates.py b/PFERD/crawl/ilias/file_templates.py
index e148875..ae8bb1e 100644
--- a/PFERD/crawl/ilias/file_templates.py
+++ b/PFERD/crawl/ilias/file_templates.py
@@ -246,7 +246,9 @@ def learning_module_template(body: bs4.Tag, name: str, prev: Optional[str], next
     return _learning_module_template.replace("{{body}}", body_str).replace("{{name}}", name)
 
 
-def forum_thread_template(name: str, heading: bs4.Tag, content: bs4.Tag) -> str:
+def forum_thread_template(name: str, url: str, heading: bs4.Tag, content: bs4.Tag) -> str:
+    if title := cast(Optional[bs4.Tag], heading.find(name="b")):
+        title.wrap(bs4.Tag(name="a", attrs={"href": url}))
     return _forum_thread_template \
         .replace("{{name}}", name) \
         .replace("{{heading}}", cast(str, heading.prettify())) \
diff --git a/PFERD/crawl/ilias/ilias_web_crawler.py b/PFERD/crawl/ilias/ilias_web_crawler.py
index 76cbe6b..add49ee 100644
--- a/PFERD/crawl/ilias/ilias_web_crawler.py
+++ b/PFERD/crawl/ilias/ilias_web_crawler.py
@@ -761,14 +761,14 @@ instance's greatest bottleneck.
             if download:
                 # This only works because ILIAS keeps the order in the export
                 elem = elements.pop(0)
-                tasks.append(asyncio.create_task(self._download_forum_thread(cl.path, elem)))
+                tasks.append(asyncio.create_task(self._download_forum_thread(cl.path, elem, thread)))
             else:
                 # We only downloaded the threads we "should_try_download"ed. This can be an
                 # over-approximation and all will be fine.
                 # If we selected too few, e.g. because there was a duplicate title and the mtime of the
                 # original is newer than the update of the duplicate.
                 # This causes stale data locally, but I consider this problem acceptable right now.
-                tasks.append(asyncio.create_task(self._download_forum_thread(cl.path, thread)))
+                tasks.append(asyncio.create_task(self._download_forum_thread(cl.path, thread, thread)))
 
         # And execute them
         await self.gather(tasks)
@@ -778,18 +778,20 @@ instance's greatest bottleneck.
     async def _download_forum_thread(
         self,
         parent_path: PurePath,
-        element: Union[IliasForumThread, IliasPageElement]
+        thread: Union[IliasForumThread, IliasPageElement],
+        element: IliasPageElement
     ) -> None:
-        path = parent_path / (_sanitize_path_name(element.name) + ".html")
-        maybe_dl = await self.download(path, mtime=element.mtime)
-        if not maybe_dl or not isinstance(element, IliasForumThread):
+        path = parent_path / (_sanitize_path_name(thread.name) + ".html")
+        maybe_dl = await self.download(path, mtime=thread.mtime)
+        if not maybe_dl or not isinstance(thread, IliasForumThread):
             return
 
         async with maybe_dl as (bar, sink):
             rendered = forum_thread_template(
-                element.name,
-                element.name_tag,
-                await self.internalize_images(element.content_tag)
+                thread.name,
+                element.url,
+                thread.name_tag,
+                await self.internalize_images(thread.content_tag)
             )
             sink.file.write(rendered.encode("utf-8"))
             sink.done()