mirrors/pferd
1
0
Fork 0
mirror of https://github.com/Garmelon/PFERD.git synced 2023-12-21 10:23:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up TODOs

Browse Source
This commit is contained in:
Joscha 2021-05-25 15:54:01 +02:00
parent 5a331663e4
commit aabce764ac
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PFERD/crawl/ilias/kit_ilias_html.py
View File

@ -393,8 +393,7 @@ class IliasPage:
) )
if modification_date_match is None: if modification_date_match is None:
modification_date = None modification_date = None
# TODO: Figure out if this is expected or *always* an error. log.explain(f"Element {name} at {url} has no date.")
log.explain(f"Element {name} at {url} has no date. Properties: {all_properties_text!r}")
else: else:
modification_date_str = modification_date_match.group(1) modification_date_str = modification_date_match.group(1)
modification_date = demangle_date(modification_date_str) modification_date = demangle_date(modification_date_str)
@ -420,9 +419,6 @@ class IliasPage:
if "target=file_" in parsed_url.query: if "target=file_" in parsed_url.query:
return IliasElementType.FILE return IliasElementType.FILE
# TODO: Match based on CMD_CLASS or icon? The folder_like check looks at the icon,
# but we could also match the command class. I am not sure what's more stable.
# Everything with a ref_id can *probably* be opened to reveal nested things # Everything with a ref_id can *probably* be opened to reveal nested things
# video groups, directories, exercises, etc # video groups, directories, exercises, etc
if "ref_id=" in parsed_url.query: if "ref_id=" in parsed_url.query: