From 4f022e2d192552ddef22b169044f2692bc4e1563 Mon Sep 17 00:00:00 2001 From: Joscha Date: Sat, 15 Jan 2022 15:06:02 +0100 Subject: [PATCH] Reword changelog --- CHANGELOG.md | 6 ++---- PFERD/crawl/ilias/kit_ilias_web_crawler.py | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f35a90..76cf836 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,10 +23,8 @@ ambiguous situations. ## Unreleased ### Fixed -- Shibboleth login. It was broken due to URL parser changes and really - *unfortunate* behaviour by aiohttp. -- local video cache on windows if the path was changed to accomodate windows - file system limitations (e.g. replace `:`) +- ILIAS login +- Local video cache if `windows_paths` is enabled ## 3.3.0 - 2022-01-09 diff --git a/PFERD/crawl/ilias/kit_ilias_web_crawler.py b/PFERD/crawl/ilias/kit_ilias_web_crawler.py index b197b6b..a3e37a9 100644 --- a/PFERD/crawl/ilias/kit_ilias_web_crawler.py +++ b/PFERD/crawl/ilias/kit_ilias_web_crawler.py @@ -773,7 +773,7 @@ async def _shib_post(session: aiohttp.ClientSession, url: str, data: Any) -> Bea """ aiohttp unescapes '/' and ':' in URL query parameters which is not RFC compliant and rejected by Shibboleth. Thanks a lot. So now we unroll the requests manually, parse location headers and - build encoded URL objects ourselfs... Who thought mangling location header was a good idea?? + build encoded URL objects ourselves... Who thought mangling location header was a good idea?? """ async with session.post(url, data=data, allow_redirects=False) as response: location = response.headers.get("location")