From 43e1648b3e598765386eeccc3b765f8c441617dc Mon Sep 17 00:00:00 2001
From: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Date: Thu, 29 Apr 2021 19:02:59 +0530
Subject: [PATCH] Improve scripts for menu-scroll - also fixes
 menu-scroll-position not working in search page

---
 layouts/partials/footer.html | 12 ++++--------
 layouts/partials/header.html |  2 +-
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/layouts/partials/footer.html b/layouts/partials/footer.html
index aa4c0561..153c436d 100644
--- a/layouts/partials/footer.html
+++ b/layouts/partials/footer.html
@@ -23,14 +23,10 @@
 {{- partial "extend_footer.html" . }}
 
 <script>
-    window.onload = function () {
-        if (localStorage.getItem("menu-scroll-position")) {
-            document.getElementById('menu').scrollLeft = localStorage.getItem("menu-scroll-position");
-        }
-    }
-
-    function menu_on_scroll() {
-        localStorage.setItem("menu-scroll-position", document.getElementById('menu').scrollLeft);
+    let menu = document.getElementById('menu')
+    menu.scrollLeft = localStorage.getItem("menu-scroll-position");
+    menu.onscroll = function () {
+        localStorage.setItem("menu-scroll-position", menu.scrollLeft);
     }
 
     document.querySelectorAll('a[href^="#"]').forEach(anchor => {
diff --git a/layouts/partials/header.html b/layouts/partials/header.html
index e23db226..173763b4 100644
--- a/layouts/partials/header.html
+++ b/layouts/partials/header.html
@@ -139,7 +139,7 @@
             </span>
         </div>
         {{- $currentPage := . }}
-        <ul id="menu" onscroll="menu_on_scroll()">
+        <ul id="menu">
             {{- range .Site.Menus.main }}
             {{- $menu_item_url := (cond (strings.HasSuffix .URL "/") .URL (printf "%s/" .URL) ) | absLangURL }}
             {{- $page_url:= $currentPage.Permalink | absLangURL }}